Eric Paris b298cecb3d scsi: mpt: suppress debugobjects warning ... Addresses http://bugzilla.kernel.org/show_bug.cgi?id=13133 ODEBUG: object is on stack, but not annotated ------------[ cut here ]------------ WARNING: at lib/debugobjects.c:253 __debug_object_init+0x1f3/0x276() Hardware name: VMware Virtual Platform Modules linked in: mptspi(+) mptscsih mptbase scsi_transport_spi ext3 jbd mbcache Pid: 540, comm: insmod Not tainted 2.6.28-mm1 #2 Call Trace: [<c042c51c>] warn_slowpath+0x74/0x8a [<c0469600>] ? start_critical_timing+0x96/0xb7 [<c060c8ea>] ? _spin_unlock_irqrestore+0x2f/0x3c [<c0446fad>] ? trace_hardirqs_off_caller+0x18/0xaf [<c044704f>] ? trace_hardirqs_off+0xb/0xd [<c060c8ea>] ? _spin_unlock_irqrestore+0x2f/0x3c [<c042cb84>] ? release_console_sem+0x1a5/0x1ad [<c05013e6>] __debug_object_init+0x1f3/0x276 [<c0501494>] debug_object_init+0x13/0x17 [<c0433c56>] init_timer+0x10/0x1a [<e08e5b54>] mpt_config+0x1c1/0x2b7 [mptbase] [<e08e3b82>] ? kmalloc+0x8/0xa [mptbase] [<e08e3b82>] ? kmalloc+0x8/0xa [mptbase] [<e08e6fa2>] mpt_do_ioc_recovery+0x950/0x1212 [mptbase] [<c04496c2>] ? __lock_acquire+0xa69/0xacc [<c060c8f1>] ? _spin_unlock_irqrestore+0x36/0x3c [<c060c3af>] ? _spin_unlock_irq+0x22/0x26 [<c04f2d8b>] ? string+0x2b/0x76 [<c04f310e>] ? vsnprintf+0x338/0x7b3 [<c04496c2>] ? __lock_acquire+0xa69/0xacc [<c060c8ea>] ? _spin_unlock_irqrestore+0x2f/0x3c [<c04496c2>] ? __lock_acquire+0xa69/0xacc [<c044897d>] ? debug_check_no_locks_freed+0xeb/0x105 [<c060c8f1>] ? _spin_unlock_irqrestore+0x36/0x3c [<c04488bc>] ? debug_check_no_locks_freed+0x2a/0x105 [<c0446b8c>] ? lock_release_holdtime+0x43/0x48 [<c043f742>] ? up_read+0x16/0x29 [<c05076f8>] ? pci_get_slot+0x66/0x72 [<e08e89ca>] mpt_attach+0x881/0x9b1 [mptbase] [<e091c8e5>] mptspi_probe+0x11/0x354 [mptspi] Noticing that every caller of mpt_config has its CONFIGPARMS struct declared on the stack and thus the &pCfg->timer is always on the stack I changed init_timer() to init_timer_on_stack() and it seems to have shut up..... Cc: "Moore, Eric Dean" <Eric.Moore@lsil.com> Cc: James Bottomley <James.Bottomley@HansenPartnership.com> Cc: Thomas Gleixner <tglx@linutronix.de> Acked-by: "Desai, Kashyap" <Kashyap.Desai@lsi.com> Cc: <stable@kernel.org> [2.6.29.x] Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2009-04-21 13:41:50 -07:00
..
lsi	[SCSI] mpt fusion: Update MPI Headers to version 01.05.19	2009-01-13 10:36:01 -06:00
Kconfig	[SCSI] mpt fusion: Kconfig cleanup	2007-10-12 14:48:53 -04:00
Makefile	[SCSI] mpt fusion: logging support in Kconfig, Makefile, mptbase.h and addition of mptdebug.h	2007-07-28 11:25:35 -04:00
mptbase.c	scsi: mpt: suppress debugobjects warning	2009-04-21 13:41:50 -07:00
mptbase.h	[SCSI] mpt fusion: Add Firmware debug support	2009-01-13 10:36:02 -06:00
mptctl.c	[SCSI] fusion: Move a dereference below a NULL test	2009-01-02 12:11:15 -06:00
mptctl.h	[SCSI] mpt fusion : Updated copyright statment with 2008 included	2008-06-05 09:27:17 -05:00
mptdebug.h	[SCSI] mpt fusion : Updated copyright statment with 2008 included	2008-06-05 09:27:17 -05:00
mptfc.c	[SCSI] replace __FUNCTION__ with __func__	2008-07-27 10:31:49 -04:00
mptlan.c	fusion: convert devices to new API	2009-01-07 18:04:45 -08:00
mptlan.h	mptlan: Kill directly reference of netdev->priv	2008-12-03 21:13:37 -08:00
mptsas.c	[SCSI] mptsas: remove unneeded check	2009-04-03 09:23:10 -05:00
mptsas.h	[SCSI] mpt fusion : Updated copyright statment with 2008 included	2008-06-05 09:27:17 -05:00
mptscsih.c	[SCSI] mpt fusion: Add Firmware debug support	2009-01-13 10:36:02 -06:00
mptscsih.h	[SCSI] mpt fusion : Updated copyright statment with 2008 included	2008-06-05 09:27:17 -05:00
mptspi.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6	2008-07-15 18:58:04 -07:00