Florian Fainelli 9fb20801da net: Fix ip_mc_{dec,inc}_group allocation context ... After 4effd28c12 ("bridge: join all-snoopers multicast address"), I started seeing the following sleep in atomic warnings: [ 26.763893] BUG: sleeping function called from invalid context at mm/slab.h:421 [ 26.771425] in_atomic(): 1, irqs_disabled(): 0, pid: 1658, name: sh [ 26.777855] INFO: lockdep is turned off. [ 26.781916] CPU: 0 PID: 1658 Comm: sh Not tainted 5.0.0-rc4 #20 [ 26.787943] Hardware name: BCM97278SV (DT) [ 26.792118] Call trace: [ 26.794645] dump_backtrace+0x0/0x170 [ 26.798391] show_stack+0x24/0x30 [ 26.801787] dump_stack+0xa4/0xe4 [ 26.805182] ___might_sleep+0x208/0x218 [ 26.809102] __might_sleep+0x78/0x88 [ 26.812762] kmem_cache_alloc_trace+0x64/0x28c [ 26.817301] igmp_group_dropped+0x150/0x230 [ 26.821573] ip_mc_dec_group+0x1b0/0x1f8 [ 26.825585] br_ip4_multicast_leave_snoopers.isra.11+0x174/0x190 [ 26.831704] br_multicast_toggle+0x78/0xcc [ 26.835887] store_bridge_parm+0xc4/0xfc [ 26.839894] multicast_snooping_store+0x3c/0x4c [ 26.844517] dev_attr_store+0x44/0x5c [ 26.848262] sysfs_kf_write+0x50/0x68 [ 26.852006] kernfs_fop_write+0x14c/0x1b4 [ 26.856102] __vfs_write+0x60/0x190 [ 26.859668] vfs_write+0xc8/0x168 [ 26.863059] ksys_write+0x70/0xc8 [ 26.866449] __arm64_sys_write+0x24/0x30 [ 26.870458] el0_svc_common+0xa0/0x11c [ 26.874291] el0_svc_handler+0x38/0x70 [ 26.878120] el0_svc+0x8/0xc while toggling the bridge's multicast_snooping attribute dynamically. Pass a gfp_t down to igmpv3_add_delrec(), introduce __igmp_group_dropped() and introduce __ip_mc_dec_group() to take a gfp_t argument. Similarly introduce ____ip_mc_inc_group() and __ip_mc_inc_group() to allow caller to specify gfp_t. IPv6 part of the patch appears fine. Fixes: 4effd28c12 ("bridge: join all-snoopers multicast address") Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-02-03 12:11:12 -08:00
..
netfilter	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf	2019-01-28 10:51:51 -08:00
Kconfig	docs: fix some broken documentation references	2018-09-20 11:09:53 -06:00
Makefile	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-11-04 09:26:51 +09:00
br.c	net: bridge: Handle NETDEV_PRE_CHANGEADDR from ports	2018-12-13 18:41:38 -08:00
br_arp_nd_proxy.c	net: bridge: convert neigh_suppress_enabled option to a bit	2018-09-26 10:04:23 -07:00
br_device.c	bridge: support for ndo_fdb_get	2018-12-16 14:42:34 -08:00
br_fdb.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-01-21 14:41:32 -08:00
br_forward.c	net: bridge: Fix ethernet header pointer before check skb forwardable	2019-01-17 21:55:15 -08:00
br_if.c	net: bridge: Issue NETDEV_PRE_CHANGEADDR	2018-12-13 18:41:38 -08:00
br_input.c	net: bridge: add no_linklocal_learn bool option	2018-11-27 15:04:15 -08:00
br_ioctl.c	net: bridge: add notifications for the bridge dev on vlan change	2017-11-02 15:53:40 +09:00
br_mdb.c	net: switchdev: Add extack argument to switchdev_port_obj_add()	2018-12-12 16:34:21 -08:00
br_multicast.c	net: Fix ip_mc_{dec,inc}_group allocation context	2019-02-03 12:11:12 -08:00
br_netfilter_hooks.c	netfilter: physdev: relax br_netfilter dependency	2019-01-18 15:02:33 +01:00
br_netfilter_ipv6.c	net: Fix usage of pskb_trim_rcsum	2019-01-18 14:05:14 -08:00
br_netlink.c	net: bridge: remove unneeded variable 'err'	2018-12-18 15:50:13 -08:00
br_netlink_tunnel.c	bridge: netlink: make setlink/dellink notifications more accurate	2017-10-29 11:03:43 +09:00
br_nf_core.c	xfrm: Move dst->path into struct xfrm_dst	2017-11-30 09:54:26 -05:00
br_private.h	net: Add extack argument to ndo_fdb_add()	2019-01-17 15:18:47 -08:00
br_private_stp.h	net: bridge: add helper to set topology change	2016-12-10 21:27:23 -05:00
br_private_tunnel.h	bridge: netlink: make setlink/dellink notifications more accurate	2017-10-29 11:03:43 +09:00
br_stp.c	net: bridge: add notifications for the bridge dev on vlan change	2017-11-02 15:53:40 +09:00
br_stp_bpdu.c	net: introduce __skb_put_[zero, data, u8]	2017-06-20 13:30:14 -04:00
br_stp_if.c	net: bridge: add notifications for the bridge dev on vlan change	2017-11-02 15:53:40 +09:00
br_stp_timer.c	net: bridge: Convert timers to use timer_setup()	2017-11-03 15:42:49 +09:00
br_switchdev.c	switchdev: Add extack argument to call_switchdev_notifiers()	2019-01-17 15:18:47 -08:00
br_sysfs_br.c	net: bridge: mark hash_elasticity as obsolete	2018-12-05 17:01:51 -08:00
br_sysfs_if.c	net: bridge: remove redundant checks for null p->dev and p->br	2018-11-25 10:25:43 -08:00
br_vlan.c	net: bridge: Fix VLANs memory leak	2019-01-08 16:53:54 -05:00
br_vlan_tunnel.c	bridge: vlan_tunnel: explicitly reset metadata attrs to NULL on failure	2017-02-17 13:33:41 -05:00