NeilBrown 312045eef9 md: remove check for MD_RECOVERY_NEEDED in action_store. ... md currently doesn't allow a 'sync_action' such as 'reshape' to be set while MD_RECOVERY_NEEDED is set. This s a problem, particularly since commit 738a273806 as that can cause ->check_shape to call mddev_resume() which sets MD_RECOVERY_NEEDED. So by the time we come to start 'reshape' it is very likely that MD_RECOVERY_NEEDED is still set. Testing for this flag is not really needed and is in any case very racy as it can be set at any moment - asynchronously. Any race between setting a sync_action and setting MD_RECOVERY_NEEDED must already be handled properly in some locked code, probably md_check_recovery(), so remove the test here. The test on MD_RECOVERY_RUNNING is also racy in the 'reshape' case so we should test it again after getting mddev_lock(). As this fixes a race and a regression which can cause 'reshape' to fail, it is suitable for -stable kernels since 4.1 Reported-by: Xiao Ni <xni@redhat.com> Fixes: 738a273806 ("md/raid5: fix allocation of 'scribble' array.") Cc: stable@vger.kernel.org (v4.1+) Signed-off-by: NeilBrown <neilb@suse.com>		2015-12-21 11:10:06 +11:00
..
bcache	Merge branch 'for-4.4/io-poll' of git://git.kernel.dk/linux-block	2015-11-10 17:23:49 -08:00
persistent-data	dm btree: fix bufio buffer leaks in dm_btree_del() error path	2015-12-10 10:30:18 -05:00
Kconfig	raid5-cache: add crc32c Kconfig dependency	2015-11-09 09:09:52 +11:00
Makefile	raid5: add basic stripe log	2015-10-24 17:16:19 +11:00
bitmap.c	md-cluster: Use a small window for resync	2015-10-12 01:32:05 -05:00
bitmap.h	md-cluster: Use a small window for resync	2015-10-12 01:32:05 -05:00
dm-bio-prison.c	block: add a bi_error field to struct bio	2015-07-29 08:55:15 -06:00
dm-bio-prison.h	dm bio prison: add dm_cell_promote_or_release()	2015-05-29 14:19:06 -04:00
dm-bio-record.h	dm: Refactor for new bio cloning/splitting	2013-11-23 22:33:55 -08:00
dm-bufio.c	dm: convert ffs to __ffs	2015-10-31 19:06:01 -04:00
dm-bufio.h	dm snapshot: use dm-bufio prefetch	2014-01-14 23:23:03 -05:00
dm-builtin.c	dm sysfs: fix a module unload race	2014-01-14 23:23:04 -05:00
dm-cache-block-types.h	dm cache: revert "remove remainder of distinct discard block size"	2014-11-10 15:25:30 -05:00
dm-cache-metadata.c	- Revert a dm-multipath change that caused a regression for unprivledged	2015-11-04 21:19:53 -08:00
dm-cache-metadata.h	dm cache: add fail io mode and needs_check flag	2015-06-11 17:13:00 -04:00
dm-cache-policy-cleaner.c	- Revert a dm-multipath change that caused a regression for unprivledged	2015-11-04 21:19:53 -08:00
dm-cache-policy-internal.h	dm cache: age and write back cache entries even without active IO	2015-06-11 17:13:01 -04:00
dm-cache-policy-mq.c	dm: convert ffs to __ffs	2015-10-31 19:06:01 -04:00
dm-cache-policy-smq.c	dm: convert ffs to __ffs	2015-10-31 19:06:01 -04:00
dm-cache-policy.c	dm cache: add policy name to status output	2014-01-16 13:44:11 -05:00
dm-cache-policy.h	dm cache: age and write back cache entries even without active IO	2015-06-11 17:13:01 -04:00
dm-cache-target.c	dm: drop NULL test before kmem_cache_destroy() and mempool_destroy()	2015-10-31 19:06:00 -04:00
dm-crypt.c	dm crypt: fix a possible hang due to race condition on exit	2015-11-19 13:38:30 -05:00
dm-delay.c	dm delay: document that offsets are specified in sectors	2015-10-31 19:06:05 -04:00
dm-era-target.c	dm persistent data: eliminate unnecessary return values	2015-10-31 19:06:02 -04:00
dm-exception-store.c	- Revert a dm-multipath change that caused a regression for unprivledged	2015-11-04 21:19:53 -08:00
dm-exception-store.h	dm snapshot: add new persistent store option to support overflow	2015-10-09 16:57:03 -04:00
dm-flakey.c	dm: refactor ioctl handling	2015-10-31 19:05:59 -04:00
dm-io.c	dm: drop NULL test before kmem_cache_destroy() and mempool_destroy()	2015-10-31 19:06:00 -04:00
dm-ioctl.c	char: make misc_deregister a void function	2015-08-05 10:35:49 -07:00
dm-kcopyd.c	mm, page_alloc: distinguish between being unable to sleep, unwilling to sleep and avoiding waking kswapd	2015-11-06 17:50:42 -08:00
dm-linear.c	dm linear: remove redundant target name from error messages	2015-10-31 19:06:03 -04:00
dm-log-userspace-base.c	dm: drop NULL test before kmem_cache_destroy() and mempool_destroy()	2015-10-31 19:06:00 -04:00
dm-log-userspace-transfer.c	dm log userspace transfer: match wait_for_completion_timeout return type	2015-04-15 12:10:20 -04:00
dm-log-userspace-transfer.h	…
dm-log-writes.c	dm: refactor ioctl handling	2015-10-31 19:05:59 -04:00
dm-log.c	…
dm-mpath.c	dm mpath: fix infinite recursion in ioctl when no paths and !queue_if_no_path	2015-11-17 14:19:00 -05:00
dm-mpath.h	…
dm-path-selector.c	…
dm-path-selector.h	…
dm-queue-length.c	…
dm-raid.c	dm raid: fix round up of default region size	2015-10-02 12:02:31 -04:00
dm-raid1.c	Merge tag 'dm-4.3-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm	2015-09-02 16:35:26 -07:00
dm-region-hash.c	dm: convert ffs to __ffs	2015-10-31 19:06:01 -04:00
dm-round-robin.c	…
dm-service-time.c	…
dm-snap-persistent.c	- Revert a dm-multipath change that caused a regression for unprivledged	2015-11-04 21:19:53 -08:00
dm-snap-transient.c	dm snapshot: add new persistent store option to support overflow	2015-10-09 16:57:03 -04:00
dm-snap.c	dm snapshot: add new persistent store option to support overflow	2015-10-09 16:57:03 -04:00
dm-stats.c	dm stats: report precise_timestamps and histogram in @stats_list output	2015-08-18 17:20:03 -04:00
dm-stats.h	dm stats: support precise timestamps	2015-06-17 12:40:40 -04:00
dm-stripe.c	Merge tag 'dm-4.3-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm	2015-09-02 16:35:26 -07:00
dm-switch.c	dm switch: simplify conditional in alloc_region_table()	2015-10-31 19:06:06 -04:00
dm-sysfs.c	dm: add 'use_blk_mq' module param and expose in per-device ro sysfs attr	2015-04-15 12:10:17 -04:00
dm-table.c	block: Inline blk_integrity in struct gendisk	2015-10-21 14:42:42 -06:00
dm-target.c	dm: allocate requests in target when stacking on blk-mq devices	2015-02-09 13:06:47 -05:00
dm-thin-metadata.c	dm thin metadata: fix bug when taking a metadata snapshot	2015-12-09 13:18:12 -05:00
dm-thin-metadata.h	dm thin metadata: add dm_thin_remove_range()	2015-06-11 17:13:04 -04:00
dm-thin.c	dm thin: fix regression in advertised discard limits	2015-11-23 14:54:46 -05:00
dm-uevent.c	…
dm-uevent.h	…
dm-verity.c	dm: refactor ioctl handling	2015-10-31 19:05:59 -04:00
dm-zero.c	block: add a bi_error field to struct bio	2015-07-29 08:55:15 -06:00
dm.c	dm: do not reuse dm_blk_ioctl block_device input as local variable	2015-11-17 14:18:49 -05:00
dm.h	block: kill merge_bvec_fn() completely	2015-08-13 12:31:57 -06:00
faulty.c	block: add a bi_error field to struct bio	2015-07-29 08:55:15 -06:00
linear.c	block: kill merge_bvec_fn() completely	2015-08-13 12:31:57 -06:00
linear.h	…
md-cluster.c	md-cluster: remove mddev arg from add_resync_info()	2015-10-24 17:16:18 +11:00
md-cluster.h	md-cluster: Fix adding of new disk with new reload code	2015-10-12 03:35:30 -05:00
md.c	md: remove check for MD_RECOVERY_NEEDED in action_store.	2015-12-21 11:10:06 +11:00
md.h	MD: change journal disk role to disk 0	2015-12-18 15:19:16 +11:00
multipath.c	md: suspend i/o during runtime blk_integrity_unregister	2015-10-21 14:43:38 -06:00
multipath.h	…
raid0.c	md/raid0: apply base queue limits *before* disk_stack_limits	2015-10-02 17:23:44 +10:00
raid0.h	block: kill merge_bvec_fn() completely	2015-08-13 12:31:57 -06:00
raid1.c	md updates for 4.4.	2015-11-04 21:12:47 -08:00
raid1.h	md-cluster: Use a small window for resync	2015-10-12 01:32:05 -05:00
raid5-cache.c	raid5-cache: start raid5 readonly if journal is missing	2015-11-01 13:48:29 +11:00
raid5.c	md updates for 4.4.	2015-11-04 21:12:47 -08:00
raid5.h	raid5-cache: IO error handling	2015-11-01 13:48:29 +11:00
raid10.c	md/raid10: fix data corruption and crash during resync	2015-12-18 15:19:16 +11:00
raid10.h	md/raid10: ensure device failure recorded before write request returns.	2015-08-31 19:43:45 +02:00