Vlastimil Babka 7810e6781e mm, page_alloc: do not break __GFP_THISNODE by zonelist reset ... In __alloc_pages_slowpath() we reset zonelist and preferred_zoneref for allocations that can ignore memory policies. The zonelist is obtained from current CPU's node. This is a problem for __GFP_THISNODE allocations that want to allocate on a different node, e.g. because the allocating thread has been migrated to a different CPU. This has been observed to break SLAB in our 4.4-based kernel, because there it relies on __GFP_THISNODE working as intended. If a slab page is put on wrong node's list, then further list manipulations may corrupt the list because page_to_nid() is used to determine which node's list_lock should be locked and thus we may take a wrong lock and race. Current SLAB implementation seems to be immune by luck thanks to commit 511e3a0588 ("mm/slab: make cache_grow() handle the page allocated on arbitrary node") but there may be others assuming that __GFP_THISNODE works as promised. We can fix it by simply removing the zonelist reset completely. There is actually no reason to reset it, because memory policies and cpusets don't affect the zonelist choice in the first place. This was different when commit 183f6371aa ("mm: ignore mempolicies when using ALLOC_NO_WATERMARK") introduced the code, as mempolicies provided their own restricted zonelists. We might consider this for 4.17 although I don't know if there's anything currently broken. SLAB is currently not affected, but in kernels older than 4.7 that don't yet have 511e3a0588 ("mm/slab: make cache_grow() handle the page allocated on arbitrary node") it is. That's at least 4.4 LTS. Older ones I'll have to check. So stable backports should be more important, but will have to be reviewed carefully, as the code went through many changes. BTW I think that also the ac->preferred_zoneref reset is currently useless if we don't also reset ac->nodemask from a mempolicy to NULL first (which we probably should for the OOM victims etc?), but I would leave that for a separate patch. Link: http://lkml.kernel.org/r/20180525130853.13915-1-vbabka@suse.cz Signed-off-by: Vlastimil Babka <vbabka@suse.cz> Fixes: 183f6371aa ("mm: ignore mempolicies when using ALLOC_NO_WATERMARK") Acked-by: Mel Gorman <mgorman@techsingularity.net> Cc: Michal Hocko <mhocko@kernel.org> Cc: David Rientjes <rientjes@google.com> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com> Cc: Vlastimil Babka <vbabka@suse.cz> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2018-06-07 17:34:38 -07:00
..
kasan	kasan: fix memory hotplug during boot	2018-05-25 18:12:11 -07:00
Kconfig	mm: introduce ARCH_HAS_PTE_SPECIAL	2018-06-07 17:34:35 -07:00
Kconfig.debug	kmemcheck: rip it out	2017-11-15 18:21:05 -08:00
Makefile	mm: restructure memfd code	2018-06-07 17:34:35 -07:00
backing-dev.c	memcg: writeback: use memcg->cgwb_list directly	2018-06-07 17:34:36 -07:00
balloon_compaction.c	virtio_balloon: fix deadlock on OOM	2017-11-14 23:57:38 +02:00
bootmem.c	mm: docs: fix parameter names mismatch	2018-02-06 18:32:48 -08:00
cleancache.c	docs/vm: rename documentation files to .rst	2018-04-16 14:18:15 -06:00
cma.c	Revert "mm/cma: manage the memory of the CMA area by using the ZONE_MOVABLE"	2018-05-24 10:07:50 -07:00
cma.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
cma_debug.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
compaction.c	Revert "mm/cma: manage the memory of the CMA area by using the ZONE_MOVABLE"	2018-05-24 10:07:50 -07:00
debug.c	mm/debug.c: provide useful debugging information for VM_BUG	2018-01-04 16:45:09 -08:00
debug_page_ref.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
dmapool.c	lib/vsprintf.c: remove %Z support	2017-02-27 18:43:47 -08:00
early_ioremap.c	mm/early_ioremap: Fix boot hang with earlyprintk=efi,keep	2017-12-11 14:54:44 +01:00
fadvise.c	mm: add ksys_fadvise64_64() helper; remove in-kernel call to sys_fadvise64_64()	2018-04-02 20:16:10 +02:00
failslab.c	mm: make should_failslab always available for fault injection	2018-04-05 21:36:26 -07:00
filemap.c	mm: use new return type vm_fault_t	2018-06-07 17:34:36 -07:00
frame_vector.c	mm/frame_vector.c: release a semaphore in 'get_vaddr_frames()'	2017-12-14 16:00:48 -08:00
frontswap.c	docs/vm: rename documentation files to .rst	2018-04-16 14:18:15 -06:00
gup.c	mm, gup: prevent pmd checking race in follow_pmd_mask()	2018-06-07 17:34:35 -07:00
gup_benchmark.c	mm/gup_benchmark: handle gup failures	2018-04-13 17:10:27 -07:00
highmem.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
hmm.c	Merge branch 'mm-rst' into docs-next	2018-04-16 14:25:08 -06:00
huge_memory.c	mm: use page->deferred_list	2018-06-07 17:34:37 -07:00
hugetlb.c	mm, hugetlbfs: pass fault address to no page handler	2018-06-07 17:34:36 -07:00
hugetlb_cgroup.c	mm: rename page_counter's count/limit into usage/max	2018-06-07 17:34:35 -07:00
hwpoison-inject.c	mm/memory_failure: Remove unused trapno from memory_failure	2018-01-23 12:17:42 -06:00
init-mm.c	mm: introduce arg_lock to protect arg_start|end and env_start|end in mm_struct	2018-06-07 17:34:34 -07:00
internal.h	Changes for 4.18:	2018-06-05 13:24:20 -07:00
interval_tree.c	mm/interval_tree.c: use vma_pages() helper	2018-01-31 17:18:37 -08:00
khugepaged.c	page cache: use xa_lock	2018-04-11 10:28:39 -07:00
kmemleak-test.c	mm: convert printk(KERN_<LEVEL> to pr_<level>	2016-03-17 15:09:34 -07:00
kmemleak.c	mm: kernel-doc: add missing parameter descriptions	2018-04-05 21:36:27 -07:00
ksm.c	mm/ksm: move [set_]page_stable_node from ksm.h to ksm.c	2018-06-07 17:34:36 -07:00
list_lru.c	mm: make counting of list_lru_one::nr_items lockless	2018-04-05 21:36:27 -07:00
maccess.c	mm: docs: fix parameter names mismatch	2018-02-06 18:32:48 -08:00
madvise.c	mm/memory_failure: Remove unused trapno from memory_failure	2018-01-23 12:17:42 -06:00
memblock.c	mm/memblock: print memblock_remove	2018-06-07 17:34:36 -07:00
memcontrol.c	mm: memcg: allow lowering memory.swap.max below the current usage	2018-06-07 17:34:37 -07:00
memfd.c	mm: restructure memfd code	2018-06-07 17:34:35 -07:00
memory-failure.c	mm, migrate: remove reason argument from new_page_t	2018-04-11 10:28:32 -07:00
memory.c	mm: remove odd HAVE_PTE_SPECIAL	2018-06-07 17:34:35 -07:00
memory_hotplug.c	mm: move is_pageblock_removable_nolock() to mm/memory_hotplug.c	2018-06-07 17:34:36 -07:00
mempolicy.c	mm: unclutter THP migration	2018-04-11 10:28:32 -07:00
mempool.c	mempool: Add mempool_init()/mempool_exit()	2018-05-14 13:14:23 -06:00
memtest.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
migrate.c	mm: migrate: fix double call of radix_tree_replace_slot()	2018-05-11 17:28:45 -07:00
mincore.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
mlock.c	mm, mlock, vmscan: no more skipping pagevecs	2018-02-21 15:35:42 -08:00
mm_init.c	mm: convert printk(KERN_<LEVEL> to pr_<level>	2016-03-17 15:09:34 -07:00
mmap.c	mm: change return type to vm_fault_t	2018-06-07 17:34:36 -07:00
mmu_context.c	sched/headers: Prepare to move the task_lock()/unlock() APIs to <linux/sched/task.h>	2017-03-02 08:42:38 +01:00
mmu_notifier.c	mm, mmu_notifier: annotate mmu notifiers with blockable invalidate callbacks	2018-01-31 17:18:38 -08:00
mmzone.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
mprotect.c	sched/numa: avoid trapping faults and attempting migration of file-backed dirty pages	2018-04-11 10:28:31 -07:00
mremap.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
msync.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nobootmem.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nommu.c	mm: use new return type vm_fault_t	2018-06-07 17:34:36 -07:00
oom_kill.c	mm: rename page_counter's count/limit into usage/max	2018-06-07 17:34:35 -07:00
page-writeback.c	writeback: safer lock nesting	2018-04-20 17:18:35 -07:00
page_alloc.c	mm, page_alloc: do not break __GFP_THISNODE by zonelist reset	2018-06-07 17:34:38 -07:00
page_counter.c	memcg: introduce memory.min	2018-06-07 17:34:36 -07:00
page_ext.c	mm/page_ext.c: make page_ext_init a noop when CONFIG_PAGE_EXTENSION but nothing uses it	2018-01-31 17:18:39 -08:00
page_idle.c	mm: thp: fix potential clearing to referenced flag in page_idle_clear_pte_refs_one()	2018-04-05 21:36:25 -07:00
page_io.c	block: convert to bio_first_bvec_all & bio_first_page_all	2018-01-06 09:18:00 -07:00
page_isolation.c	mm, migrate: remove reason argument from new_page_t	2018-04-11 10:28:32 -07:00
page_owner.c	mm/page_owner.c: make early_page_owner_param() __init	2018-04-05 21:36:26 -07:00
page_poison.c	mm/page_poison.c: make early_page_poison_param() __init	2018-04-05 21:36:26 -07:00
page_vma_mapped.c	mm, page_vma_mapped: Introduce pfn_in_hpage()	2018-01-22 12:15:57 -08:00
pagewalk.c	mm: kernel-doc: add missing parameter descriptions	2018-04-05 21:36:27 -07:00
percpu-internal.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
percpu-km.c	percpu: allow select gfp to be passed to underlying allocators	2018-02-18 05:33:01 -08:00
percpu-stats.c	mm: reuse DEFINE_SHOW_ATTRIBUTE() macro	2018-04-05 21:36:25 -07:00
percpu-vm.c	percpu: allow select gfp to be passed to underlying allocators	2018-02-18 05:33:01 -08:00
percpu.c	arch: remove obsolete architecture ports	2018-04-02 20:20:12 -07:00
pgtable-generic.c	mm: do not lose dirty and accessed bits in pmdp_invalidate()	2018-01-31 17:18:38 -08:00
process_vm_access.c	mm: docs: add blank lines to silence sphinx "Unexpected indentation" errors	2018-02-06 18:32:48 -08:00
quicklist.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
readahead.c	mm: split ->readpages calls to avoid non-contiguous pages lists	2018-06-01 18:37:32 -07:00
rmap.c	Linux 4.17-rc2	2018-04-27 17:13:20 -06:00
rodata_test.c	mm: fix RODATA_TEST failure "rodata_test: test data was not read only"	2017-10-03 17:54:24 -07:00
shmem.c	mm/shmem.c: use new return type vm_fault_t	2018-06-07 17:34:37 -07:00
slab.c	slab,slub: remove rcu_head size checks	2018-06-07 17:34:37 -07:00
slab.h	slab, slub: skip unnecessary kasan_cache_shutdown()	2018-04-05 21:36:24 -07:00
slab_common.c	mm: make should_failslab always available for fault injection	2018-04-05 21:36:26 -07:00
slob.c	slab: __GFP_ZERO is incompatible with a constructor	2018-06-07 17:34:34 -07:00
slub.c	slub: remove 'reserved' file from sysfs	2018-06-07 17:34:37 -07:00
sparse-vmemmap.c	mm: merge vmem_altmap_alloc into altmap_alloc_block_buf	2018-01-08 11:46:23 -08:00
sparse.c	mm/sparse.c: pass the __highest_present_section_nr + 1 to alloc_func()	2018-06-07 17:34:35 -07:00
swap.c	mm/swap.c: remove @cold parameter description for release_pages()	2018-04-05 21:36:26 -07:00
swap_cgroup.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
swap_slots.c	mm, memcontrol: move swap charge handling into get_swap_page()	2018-06-07 17:34:34 -07:00
swap_state.c	mm, memcontrol: move swap charge handling into get_swap_page()	2018-06-07 17:34:34 -07:00
swapfile.c	mm: fix nr_rotate_swap leak in swapon() error case	2018-05-25 18:12:10 -07:00
truncate.c	page cache: use xa_lock	2018-04-11 10:28:39 -07:00
usercopy.c	usercopy: WARN() on slab cache usercopy region violations	2018-01-15 12:07:48 -08:00
userfaultfd.c	userfaultfd: prevent non-cooperative events vs mcopy_atomic races	2018-06-07 17:34:38 -07:00
util.c	Merge branch 'mm-rst' into docs-next	2018-04-16 14:25:08 -06:00
vmacache.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
vmalloc.c	mm: vmalloc: pass proper vm_start into debugobjects	2018-06-07 17:34:35 -07:00
vmpressure.c	mm/vmpressure.c: convert to use match_string() helper	2018-06-07 17:34:36 -07:00
vmscan.c	memcg: introduce memory.min	2018-06-07 17:34:36 -07:00
vmstat.c	proc: introduce proc_create_seq{,_data}	2018-05-16 07:23:35 +02:00
workingset.c	page cache: use xa_lock	2018-04-11 10:28:39 -07:00
z3fold.c	z3fold: fix reclaim lock-ups	2018-05-11 17:28:45 -07:00
zbud.c	mm: docs: fix parameter names mismatch	2018-02-06 18:32:48 -08:00
zpool.c	mm/zpool.c: zpool_evictable: fix mismatch in parameter name and kernel-doc	2018-02-21 15:35:43 -08:00
zsmalloc.c	mm: kernel-doc: add missing parameter descriptions	2018-04-05 21:36:27 -07:00
zswap.c	mm, swap, frontswap: fix THP swap if frontswap enabled	2018-02-21 15:35:43 -08:00