Alexander Potapenko 8e2f33c598 misc/vmw_vmci: fix an infoleak in vmci_host_do_receive_datagram() ... commit e5b0d06d9b upstream. `struct vmci_event_qp` allocated by qp_notify_peer() contains padding, which may carry uninitialized data to the userspace, as observed by KMSAN: BUG: KMSAN: kernel-infoleak in instrument_copy_to_user ./include/linux/instrumented.h:121 instrument_copy_to_user ./include/linux/instrumented.h:121 _copy_to_user+0x5f/0xb0 lib/usercopy.c:33 copy_to_user ./include/linux/uaccess.h:169 vmci_host_do_receive_datagram drivers/misc/vmw_vmci/vmci_host.c:431 vmci_host_unlocked_ioctl+0x33d/0x43d0 drivers/misc/vmw_vmci/vmci_host.c:925 vfs_ioctl fs/ioctl.c:51 ... Uninit was stored to memory at: kmemdup+0x74/0xb0 mm/util.c:131 dg_dispatch_as_host drivers/misc/vmw_vmci/vmci_datagram.c:271 vmci_datagram_dispatch+0x4f8/0xfc0 drivers/misc/vmw_vmci/vmci_datagram.c:339 qp_notify_peer+0x19a/0x290 drivers/misc/vmw_vmci/vmci_queue_pair.c:1479 qp_broker_attach drivers/misc/vmw_vmci/vmci_queue_pair.c:1662 qp_broker_alloc+0x2977/0x2f30 drivers/misc/vmw_vmci/vmci_queue_pair.c:1750 vmci_qp_broker_alloc+0x96/0xd0 drivers/misc/vmw_vmci/vmci_queue_pair.c:1940 vmci_host_do_alloc_queuepair drivers/misc/vmw_vmci/vmci_host.c:488 vmci_host_unlocked_ioctl+0x24fd/0x43d0 drivers/misc/vmw_vmci/vmci_host.c:927 ... Local variable ev created at: qp_notify_peer+0x54/0x290 drivers/misc/vmw_vmci/vmci_queue_pair.c:1456 qp_broker_attach drivers/misc/vmw_vmci/vmci_queue_pair.c:1662 qp_broker_alloc+0x2977/0x2f30 drivers/misc/vmw_vmci/vmci_queue_pair.c:1750 Bytes 28-31 of 48 are uninitialized Memory access of size 48 starts at ffff888035155e00 Data copied to user address 0000000020000100 Use memset() to prevent the infoleaks. Also speculatively fix qp_notify_peer_local(), which may suffer from the same problem. Reported-by: syzbot+39be4da489ed2493ba25@syzkaller.appspotmail.com Cc: stable <stable@kernel.org> Fixes: 06164d2b72 ("VMCI: queue pairs implementation.") Signed-off-by: Alexander Potapenko <glider@google.com> Reviewed-by: Vishnu Dasa <vdasa@vmware.com> Link: https://lore.kernel.org/r/20221104175849.2782567-1-glider@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-11-26 09:24:48 +01:00
..
altera-stapl	…
bcm-vk	…
c2port	…
cardreader	misc: rtsx: Fix an error handling path in rtsx_pci_probe()	2022-08-17 14:23:45 +02:00
cb710	…
cxl	cxl: Fix a memory leak in an error handling path	2022-08-25 11:40:36 +02:00
echo	…
eeprom	eeprom: idt_89hpesx: uninitialized data in idt_dbgfs_csr_write()	2022-08-17 14:23:52 +02:00
genwqe	…
habanalabs	habanalabs/gaudi: mask constant value before cast	2022-08-25 11:40:36 +02:00
ibmasm	…
lis3lv02d	…
lkdtm	lkdtm/usercopy: Expand size of "out of frame" object	2022-06-14 18:36:20 +02:00
mei	mei: me: add raptor lake point S DID	2022-06-22 14:22:03 +02:00
ocxl	misc: ocxl: fix possible refcount leak in afu_ioctl()	2022-10-26 12:35:07 +02:00
pvpanic	misc/pvpanic: Convert regular spinlock into trylock on panic path	2022-06-14 18:36:06 +02:00
sgi-gru	…
sgi-xp	…
ti-st	…
uacce	uacce: Handle parent device removal or parent driver module rmmod	2022-08-25 11:40:34 +02:00
vmw_vmci	misc/vmw_vmci: fix an infoleak in vmci_host_do_receive_datagram()	2022-11-26 09:24:48 +01:00
Kconfig	…
Makefile	…
ad525x_dpot-i2c.c	…
ad525x_dpot-spi.c	…
ad525x_dpot.c	…
ad525x_dpot.h	…
apds990x.c	…
apds9802als.c	…
atmel-ssc.c	misc: atmel-ssc: Fix IRQ check in ssc_probe	2022-06-22 14:22:00 +02:00
bh1770glc.c	…
cs5535-mfgpt.c	…
ds1682.c	…
dummy-irq.c	…
dw-xdata-pcie.c	…
enclosure.c	…
fastrpc.c	misc: fastrpc: fix memory corruption on open	2022-09-08 12:28:04 +02:00
gehc-achc.c	…
hi6421v600-irq.c	…
hisi_hikey_usb.c	…
hmc6352.c	…
hpilo.c	…
hpilo.h	…
ibmvmc.c	…
ibmvmc.h	…
ics932s401.c	…
isl29003.c	…
isl29020.c	…
kgdbts.c	kgdbts: fix return value of __setup handler	2022-04-08 14:23:50 +02:00
lattice-ecp3-config.c	…
pch_phub.c	…
pci_endpoint_test.c	misc: pci_endpoint_test: Fix pci_endpoint_test_{copy,write,read}() panic	2022-10-15 07:59:04 +02:00
phantom.c	…
qcom-coincell.c	…
sram-exec.c	…
sram.c	…
sram.h	…
tifm_7xx1.c	…
tifm_core.c	…
tsl2550.c	…
vmw_balloon.c	…
xilinx_sdfec.c	…