Eric Biggers 5bb4005fb6 blk-crypto: make blk_crypto_evict_key() more robust ... commit 5c7cb94452 upstream. If blk_crypto_evict_key() sees that the key is still in-use (due to a bug) or that ->keyslot_evict failed, it currently just returns while leaving the key linked into the keyslot management structures. However, blk_crypto_evict_key() is only called in contexts such as inode eviction where failure is not an option. So actually the caller proceeds with freeing the blk_crypto_key regardless of the return value of blk_crypto_evict_key(). These two assumptions don't match, and the result is that there can be a use-after-free in blk_crypto_reprogram_all_keys() after one of these errors occurs. (Note, these errors *shouldn't* happen; we're just talking about what happens if they do anyway.) Fix this by making blk_crypto_evict_key() unlink the key from the keyslot management structures even on failure. Also improve some comments. Fixes: 1b26283970 ("block: Keyslot Manager for Inline Encryption") Cc: stable@vger.kernel.org Signed-off-by: Eric Biggers <ebiggers@google.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Link: https://lore.kernel.org/r/20230315183907.53675-2-ebiggers@kernel.org Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-05-11 23:00:16 +09:00
..
partitions	…
Kconfig	…
Kconfig.iosched	…
Makefile	…
badblocks.c	…
bdev.c	…
bfq-cgroup.c	block, bfq: fix uaf for bfqq in bic_set_bfqq()	2023-02-09 11:26:36 +01:00
bfq-iosched.c	block, bfq: fix uaf for bfqq in bic_set_bfqq()	2023-02-09 11:26:36 +01:00
bfq-iosched.h	…
bfq-wf2q.c	…
bio-integrity.c	block: bio-integrity: Copy flags when bio_integrity_payload is cloned	2023-03-10 09:39:05 +01:00
bio.c	…
blk-cgroup-rwstat.c	…
blk-cgroup-rwstat.h	…
blk-cgroup.c	…
blk-core.c	blk-mq: release crypto keyslot before reporting I/O complete	2023-05-11 23:00:16 +09:00
blk-crypto-fallback.c	…
blk-crypto-internal.h	blk-mq: release crypto keyslot before reporting I/O complete	2023-05-11 23:00:16 +09:00
blk-crypto.c	blk-crypto: make blk_crypto_evict_key() more robust	2023-05-11 23:00:16 +09:00
blk-exec.c	…
blk-flush.c	…
blk-integrity.c	…
blk-ioc.c	…
blk-iocost.c	blk-iocost: fix divide by 0 error in calc_lcoefs()	2023-03-10 09:39:46 +01:00
blk-iolatency.c	…
blk-ioprio.c	…
blk-ioprio.h	…
blk-lib.c	…
blk-map.c	…
blk-merge.c	blk-mq: release crypto keyslot before reporting I/O complete	2023-05-11 23:00:16 +09:00
blk-mq-cpumap.c	…
blk-mq-debugfs-zoned.c	…
blk-mq-debugfs.c	…
blk-mq-debugfs.h	…
blk-mq-pci.c	…
blk-mq-rdma.c	…
blk-mq-sched.c	blk-mq: correct stale comment of .get_budget	2023-03-10 09:39:04 +01:00
blk-mq-sched.h	…
blk-mq-sysfs.c	…
blk-mq-tag.c	…
blk-mq-tag.h	…
blk-mq-virtio.c	…
blk-mq.c	blk-mq: release crypto keyslot before reporting I/O complete	2023-05-11 23:00:16 +09:00
blk-mq.h	…
blk-pm.c	…
blk-pm.h	…
blk-rq-qos.c	…
blk-rq-qos.h	…
blk-settings.c	…
blk-stat.c	…
blk-stat.h	…
blk-sysfs.c	…
blk-throttle.c	…
blk-timeout.c	…
blk-wbt.c	…
blk-wbt.h	…
blk-zoned.c	…
blk.h	…
bounce.c	…
bsg-lib.c	…
bsg.c	…
disk-events.c	…
elevator.c	…
fops.c	block: don't allow multiple bios for IOCB_NOWAIT issue	2023-03-10 09:39:55 +01:00
genhd.c	…
holder.c	…
ioctl.c	…
ioprio.c	…
keyslot-manager.c	blk-crypto: make blk_crypto_evict_key() more robust	2023-05-11 23:00:16 +09:00
kyber-iosched.c	…
mq-deadline.c	…
opal_proto.h	…
sed-opal.c	…
t10-pi.c	…