Vlad Buslov 67cbf7dedd net: sched: sample: allow accessing psample_group with rtnl ... Recently implemented support for sample action in flow_offload infra leads to following rcu usage warning: [ 1938.234856] ============================= [ 1938.234858] WARNING: suspicious RCU usage [ 1938.234863] 5.3.0-rc1+ #574 Not tainted [ 1938.234866] ----------------------------- [ 1938.234869] include/net/tc_act/tc_sample.h:47 suspicious rcu_dereference_check() usage! [ 1938.234872] other info that might help us debug this: [ 1938.234875] rcu_scheduler_active = 2, debug_locks = 1 [ 1938.234879] 1 lock held by tc/19540: [ 1938.234881] #0: 00000000b03cb918 (rtnl_mutex){+.+.}, at: tc_new_tfilter+0x47c/0x970 [ 1938.234900] stack backtrace: [ 1938.234905] CPU: 2 PID: 19540 Comm: tc Not tainted 5.3.0-rc1+ #574 [ 1938.234908] Hardware name: Supermicro SYS-2028TP-DECR/X10DRT-P, BIOS 2.0b 03/30/2017 [ 1938.234911] Call Trace: [ 1938.234922] dump_stack+0x85/0xc0 [ 1938.234930] tc_setup_flow_action+0xed5/0x2040 [ 1938.234944] fl_hw_replace_filter+0x11f/0x2e0 [cls_flower] [ 1938.234965] fl_change+0xd24/0x1b30 [cls_flower] [ 1938.234990] tc_new_tfilter+0x3e0/0x970 [ 1938.235021] ? tc_del_tfilter+0x720/0x720 [ 1938.235028] rtnetlink_rcv_msg+0x389/0x4b0 [ 1938.235038] ? netlink_deliver_tap+0x95/0x400 [ 1938.235044] ? rtnl_dellink+0x2d0/0x2d0 [ 1938.235053] netlink_rcv_skb+0x49/0x110 [ 1938.235063] netlink_unicast+0x171/0x200 [ 1938.235073] netlink_sendmsg+0x224/0x3f0 [ 1938.235091] sock_sendmsg+0x5e/0x60 [ 1938.235097] ___sys_sendmsg+0x2ae/0x330 [ 1938.235111] ? __handle_mm_fault+0x12cd/0x19e0 [ 1938.235125] ? __handle_mm_fault+0x12cd/0x19e0 [ 1938.235138] ? find_held_lock+0x2b/0x80 [ 1938.235147] ? do_user_addr_fault+0x22d/0x490 [ 1938.235160] __sys_sendmsg+0x59/0xa0 [ 1938.235178] do_syscall_64+0x5c/0xb0 [ 1938.235187] entry_SYSCALL_64_after_hwframe+0x49/0xbe [ 1938.235192] RIP: 0033:0x7ff9a4d597b8 [ 1938.235197] Code: 89 02 48 c7 c0 ff ff ff ff eb bb 0f 1f 80 00 00 00 00 f3 0f 1e fa 48 8d 05 65 8f 0c 00 8b 00 85 c0 75 17 b8 2e 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 58 c3 0f 1f 80 00 00 00 00 48 83 ec 28 89 54 [ 1938.235200] RSP: 002b:00007ffcfe381c48 EFLAGS: 00000246 ORIG_RAX: 000000000000002e [ 1938.235205] RAX: ffffffffffffffda RBX: 000000005d4497f9 RCX: 00007ff9a4d597b8 [ 1938.235208] RDX: 0000000000000000 RSI: 00007ffcfe381cb0 RDI: 0000000000000003 [ 1938.235211] RBP: 0000000000000000 R08: 0000000000000001 R09: 0000000000000006 [ 1938.235214] R10: 0000000000404ec2 R11: 0000000000000246 R12: 0000000000000001 [ 1938.235217] R13: 0000000000480640 R14: 0000000000000012 R15: 0000000000000001 Change tcf_sample_psample_group() helper to allow using it from both rtnl and rcu protected contexts. Fixes: a7a7be6087 ("net/sched: add sample action to the hardware intermediate representation") Signed-off-by: Vlad Buslov <vladbu@mellanox.com> Reviewed-by: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-08-06 14:15:39 -07:00
..
9p	…
bluetooth	Bluetooth: Add support for LE ping feature	2019-07-06 15:29:12 +02:00
caif	…
iucv	…
netfilter	net: flow_offload: add flow_block structure and use it	2019-07-19 21:27:45 -07:00
netns	…
nfc	…
phonet	…
sctp	sctp: rename sp strm_interleave to ep intl_enable	2019-07-08 20:16:25 -07:00
tc_act	net: sched: sample: allow accessing psample_group with rtnl	2019-08-06 14:15:39 -07:00
6lowpan.h	…
Space.h	…
act_api.h	…
addrconf.h	…
af_ieee802154.h	…
af_rxrpc.h	…
af_unix.h	…
af_vsock.h	…
ah.h	…
arp.h	…
atmclip.h	…
ax25.h	…
ax88796.h	…
bond_3ad.h	…
bond_alb.h	…
bond_options.h	bonding: add an option to specify a delay between peer notifications	2019-07-04 12:30:48 -07:00
bonding.h	bonding: add an option to specify a delay between peer notifications	2019-07-04 12:30:48 -07:00
bpf_sk_storage.h	…
busy_poll.h	…
calipso.h	…
cfg80211-wext.h	…
cfg80211.h	{nl,mac}80211: fix interface combinations on crypto controlled devices	2019-07-26 13:50:43 +02:00
cfg802154.h	…
checksum.h	…
cipso_ipv4.h	…
cls_cgroup.h	…
codel.h	…
codel_impl.h	…
codel_qdisc.h	…
compat.h	…
datalink.h	…
dcbevent.h	…
dcbnl.h	…
devlink.h	devlink: Introduce PCI VF port flavour and port attribute	2019-07-09 12:02:13 -07:00
dn.h	…
dn_dev.h	…
dn_fib.h	…
dn_neigh.h	…
dn_nsp.h	…
dn_route.h	…
dsa.h	…
dsfield.h	…
dst.h	net: dst.h: Fix shifting signed 32-bit value by 31 bits problem	2019-07-01 10:48:34 -07:00
dst_cache.h	…
dst_metadata.h	…
dst_ops.h	…
erspan.h	…
esp.h	…
ethoc.h	…
failover.h	…
fib_notifier.h	…
fib_rules.h	net: fib_rules: do not flow dissect local packets	2019-07-11 14:22:53 -07:00
firewire.h	…
flow.h	…
flow_dissector.h	net/flow_dissector: add connection tracking dissection	2019-07-09 12:11:59 -07:00
flow_offload.h	net: flow_offload: add flow_block structure and use it	2019-07-19 21:27:45 -07:00
fou.h	…
fq.h	…
fq_impl.h	…
garp.h	…
gen_stats.h	…
genetlink.h	…
geneve.h	…
gre.h	…
gro_cells.h	…
gtp.h	…
gue.h	net:gue.h:Fix shifting signed 32-bit value by 31 bits problem	2019-07-01 10:58:23 -07:00
hwbm.h	…
icmp.h	…
ieee80211_radiotap.h	…
ieee802154_netdev.h	…
if_inet6.h	…
ife.h	…
ila.h	…
inet6_connection_sock.h	…
inet6_hashtables.h	…
inet_common.h	inet: factor out inet_send_prepare()	2019-07-03 13:51:54 -07:00
inet_connection_sock.h	…
inet_ecn.h	…
inet_frag.h	…
inet_hashtables.h	…
inet_sock.h	…
inet_timewait_sock.h	…
inetpeer.h	…
ip.h	…
ip6_checksum.h	…
ip6_fib.h	…
ip6_route.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-27 21:06:39 -07:00
ip6_tunnel.h	…
ip_fib.h	…
ip_tunnels.h	…
ip_vs.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-07-08 19:48:57 -07:00
ipcomp.h	…
ipconfig.h	…
ipv6.h	ipv6: elide flowlabel check if no exclusive leases exist	2019-07-08 19:38:03 -07:00
ipv6_frag.h	…
ipv6_stubs.h	…
ipx.h	…
iw_handler.h	…
kcm.h	…
l3mdev.h	…
lag.h	…
lapb.h	…
lib80211.h	…
llc.h	…
llc_c_ac.h	…
llc_c_ev.h	…
llc_c_st.h	…
llc_conn.h	…
llc_if.h	…
llc_pdu.h	…
llc_s_ac.h	…
llc_s_ev.h	…
llc_s_st.h	…
llc_sap.h	…
lwtunnel.h	…
mac80211.h	…
mac802154.h	…
mip6.h	…
mld.h	…
mpls.h	…
mpls_iptunnel.h	…
mrp.h	…
ncsi.h	…
ndisc.h	…
neighbour.h	…
net_failover.h	…
net_namespace.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2019-07-11 10:55:49 -07:00
net_ratelimit.h	…
netevent.h	…
netlabel.h	…
netlink.h	…
netprio_cgroup.h	…
netrom.h	…
nexthop.h	…
nl802154.h	…
nsh.h	…
p8022.h	…
page_pool.h	net: core: page_pool: add user refcnt and reintroduce page_pool_destroy	2019-07-08 14:58:04 -07:00
ping.h	…
pkt_cls.h	net: flow_offload: rename tc_setup_cb_t to flow_setup_cb_t	2019-07-19 21:27:45 -07:00
pkt_sched.h	…
pptp.h	…
protocol.h	…
psample.h	…
psnap.h	…
raw.h	…
rawv6.h	…
red.h	…
regulatory.h	…
request_sock.h	…
rose.h	…
route.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-27 21:06:39 -07:00
rsi_91x.h	…
rtnetlink.h	…
rtnh.h	…
sch_generic.h	net: flow_offload: add flow_block structure and use it	2019-07-19 21:27:45 -07:00
scm.h	…
secure_seq.h	…
seg6.h	…
seg6_hmac.h	…
seg6_local.h	…
slhc_vj.h	…
smc.h	…
snmp.h	…
sock.h	coallocate socket_wq with socket itself	2019-07-08 19:25:19 -07:00
sock_reuseport.h	…
stp.h	…
strparser.h	…
switchdev.h	…
tcp.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf	2019-07-25 17:35:03 -07:00
tcp_states.h	…
timewait_sock.h	…
tipc.h	…
tls.h	net/tls: partially revert fix transition through disconnect with close	2019-08-05 13:15:30 -07:00
transp_v6.h	…
tso.h	…
tun_proto.h	…
udp.h	…
udp_tunnel.h	…
udplite.h	…
vsock_addr.h	…
vxlan.h	…
wext.h	…
wimax.h	…
x25.h	…
x25device.h	…
xdp.h	…
xdp_priv.h	…
xdp_sock.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-07-08 19:48:57 -07:00
xfrm.h	xfrm: remove get_mtu indirection from xfrm_type	2019-07-01 06:16:40 +02:00