Borislav Petkov (AMD) d1b93d4017 kbuild: Disable KCSAN for autogenerated *.mod.c intermediaries ... [ Upstream commit 54babdc0343fff2f32dfaafaaa9e42c4db278204 ] When KCSAN and CONSTRUCTORS are enabled, one can trigger the "Unpatched return thunk in use. This should not happen!" catch-all warning. Usually, when objtool runs on the .o objects, it does generate a section .return_sites which contains all offsets in the objects to the return thunks of the functions present there. Those return thunks then get patched at runtime by the alternatives. KCSAN and CONSTRUCTORS add this to the object file's .text.startup section: ------------------- Disassembly of section .text.startup: ... 0000000000000010 <_sub_I_00099_0>: 10: f3 0f 1e fa endbr64 14: e8 00 00 00 00 call 19 <_sub_I_00099_0+0x9> 15: R_X86_64_PLT32 __tsan_init-0x4 19: e9 00 00 00 00 jmp 1e <__UNIQUE_ID___addressable_cryptd_alloc_aead349+0x6> 1a: R_X86_64_PLT32 __x86_return_thunk-0x4 ------------------- which, if it is built as a module goes through the intermediary stage of creating a <module>.mod.c file which, when translated, receives a second constructor: ------------------- Disassembly of section .text.startup: 0000000000000010 <_sub_I_00099_0>: 10: f3 0f 1e fa endbr64 14: e8 00 00 00 00 call 19 <_sub_I_00099_0+0x9> 15: R_X86_64_PLT32 __tsan_init-0x4 19: e9 00 00 00 00 jmp 1e <_sub_I_00099_0+0xe> 1a: R_X86_64_PLT32 __x86_return_thunk-0x4 ... 0000000000000030 <_sub_I_00099_0>: 30: f3 0f 1e fa endbr64 34: e8 00 00 00 00 call 39 <_sub_I_00099_0+0x9> 35: R_X86_64_PLT32 __tsan_init-0x4 39: e9 00 00 00 00 jmp 3e <__ksymtab_cryptd_alloc_ahash+0x2> 3a: R_X86_64_PLT32 __x86_return_thunk-0x4 ------------------- in the .ko file. Objtool has run already so that second constructor's return thunk cannot be added to the .return_sites section and thus the return thunk remains unpatched and the warning rightfully fires. Drop KCSAN flags from the mod.c generation stage as those constructors do not contain data races one would be interested about. Debugged together with David Kaplan <David.Kaplan@amd.com> and Nikolay Borisov <nik.borisov@suse.com>. Reported-by: Paul Menzel <pmenzel@molgen.mpg.de> Closes: https://lore.kernel.org/r/0851a207-7143-417e-be31-8bf2b3afb57d@molgen.mpg.de Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de> Tested-by: Paul Menzel <pmenzel@molgen.mpg.de> # Dell XPS 13 Reviewed-by: Nikolay Borisov <nik.borisov@suse.com> Reviewed-by: Marco Elver <elver@google.com> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-05-17 11:50:53 +02:00
..
atomic	atomics: Fix atomic64_{read_acquire,set_release} fallbacks	2022-04-08 14:23:57 +02:00
basic	.gitignore: prefix local generated files with a slash	2021-05-02 00:43:35 +09:00
clang-tools	gen_compile_commands: fix invalid escape sequence warning	2024-03-26 18:21:12 -04:00
coccinelle	scripts: coccinelle: allow list_entry_is_head() to use pos	2021-08-08 22:00:49 +02:00
dtc	kbuild: Allow kernel installation packaging to override pkg-config	2023-02-01 08:27:30 +01:00
dummy-tools	kbuild: dummy-tools: avoid tmpdir leak in dummy gcc	2022-08-25 11:40:14 +02:00
gcc-plugins	gcc-plugins/stackleak: Avoid .head.text section	2024-04-13 13:01:47 +02:00
gdb	scripts/gdb: fix lx-timerlist for Python3	2023-05-11 23:00:39 +09:00
genksyms	.gitignore: prefix local generated files with a slash	2021-05-02 00:43:35 +09:00
kconfig	kconfig: fix infinite loop when expanding a macro at the end of file	2024-03-26 18:21:34 -04:00
ksymoops	…
mod	modpost: trim leading spaces when processing source files list	2024-02-23 08:55:04 +01:00
package	builddeb: clean generated package content	2023-03-10 09:39:44 +01:00
selinux	selinux: use "grep -E" instead of "egrep"	2022-10-26 12:34:35 +02:00
tracing	ftrace/scripts: Update the instructions for ftrace-bisect.sh	2023-02-01 08:27:23 +01:00
.gitignore	.gitignore: prefix local generated files with a slash	2021-05-02 00:43:35 +09:00
Kbuild.include	kbuild: remove the target in signal traps when interrupted	2022-10-26 12:35:27 +02:00
Kconfig.include	kbuild: check the minimum assembler version in Kconfig	2021-04-25 05:14:41 +09:00
Lindent	…
Makefile	kbuild: Allow kernel installation packaging to override pkg-config	2023-02-01 08:27:30 +01:00
Makefile.asm-generic	kbuild: prefix $(srctree)/ to some included Makefiles	2021-03-15 19:20:48 +09:00
Makefile.build	x86/retbleed: Add fine grained Kconfig knobs	2022-07-23 12:54:10 +02:00
Makefile.clang	kbuild: Add -Werror=ignored-optimization-argument to CLANG_FLAGS	2021-09-19 10:55:18 +09:00
Makefile.clean	kbuild: prefix $(srctree)/ to some included Makefiles	2021-03-15 19:20:48 +09:00
Makefile.compiler	powerpc: remove checks for binutils older than 2.25	2024-01-25 14:52:32 -08:00
Makefile.dtbinst	kbuild: prefix $(srctree)/ to some included Makefiles	2021-03-15 19:20:48 +09:00
Makefile.extrawarn	kbuild: Move -Wenum-{compare-conditional,enum-conversion} into W=1	2024-04-10 16:18:41 +02:00
Makefile.gcc-plugins	gcc-plugins: Undefine LATENT_ENTROPY_PLUGIN when plugin disabled for a file	2022-08-25 11:40:27 +02:00
Makefile.headersinst	kbuild: prefix $(srctree)/ to some included Makefiles	2021-03-15 19:20:48 +09:00
Makefile.host	kbuild: sort hostprogs before passing it to ifneq	2020-08-10 01:32:59 +09:00
Makefile.kasan	kasan: always respect CONFIG_KASAN_STACK	2021-09-24 16:13:35 -07:00
Makefile.kcov	kbuild: include scripts/Makefile.* only when relevant CONFIG is enabled	2020-08-10 01:32:59 +09:00
Makefile.kcsan	Kbuild updates for v5.10	2020-10-22 13:13:57 -07:00
Makefile.lib	kbuild: move objtool_args back to scripts/Makefile.build	2022-05-15 20:18:50 +02:00
Makefile.modfinal	kbuild: Disable KCSAN for autogenerated *.mod.c intermediaries	2024-05-17 11:50:53 +02:00
Makefile.modinst	kbuild: add support for zstd compressed modules	2021-04-25 05:25:06 +09:00
Makefile.modpost	kbuild: Fix include path in scripts/Makefile.modpost	2022-09-05 10:30:06 +02:00
Makefile.package	kbuild: deb-pkg: change the source package name to linux-upstream	2021-04-25 05:30:45 +09:00
Makefile.ubsan	ubsan: remove CONFIG_UBSAN_OBJECT_SIZE	2022-04-13 20:59:27 +02:00
Makefile.userprogs	kbuild: add infrastructure to build userspace programs	2020-05-17 18:52:01 +09:00
adjust_autoksyms.sh	kbuild: redo fake deps at include/ksym/*.h	2021-09-03 08:17:21 +09:00
as-version.sh	kbuild: Switch to 'f' variants of integrated assembler flag	2021-09-03 08:17:20 +09:00
asn1_compiler.c	ASN.1: Fix check for strdup() success	2023-04-26 13:51:56 +02:00
bin2c.c	…
bloat-o-meter	scripts: switch explicitly to Python 3	2021-01-22 06:34:44 +09:00
bootgraph.pl	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 391	2019-06-05 17:37:11 +02:00
bpf_doc.py	bpf, scripts: Correct GPL license name	2024-03-01 13:21:58 +01:00
cc-can-link.sh	…
cc-version.sh	kbuild: collect minimum tool versions into scripts/min-tool-version.sh	2021-04-25 05:14:26 +09:00
check-sysctl-docs	docs: add a script to check sysctl docs	2020-02-25 03:35:16 -07:00
check_extable.sh	scripts: check_extable: fix typo in user error message	2021-09-08 11:50:28 -07:00
checkdeclares.pl	scripts: make some scripts executable	2021-08-10 09:13:25 +09:00
checkincludes.pl	…
checkkconfigsymbols.py	scripts: handle BrokenPipeError for python scripts	2023-03-17 08:49:02 +01:00
checkpatch.pl	Compiler Attributes: add __alloc_size() for better bounds checking	2022-07-12 16:35:01 +02:00
checkstack.pl	checkstack: fix printed address	2023-12-13 18:36:43 +01:00
checksyscalls.sh	checksyscalls: Unconditionally ignore fstat{,at}64	2021-10-07 17:16:28 -07:00
checkversion.pl	scripts: checkversion: modernize linux/version.h search strings	2021-08-05 20:55:39 +09:00
cleanfile	…
cleanpatch	…
coccicheck	scripts: coccicheck: fix troubles on non-English builds	2021-05-18 11:09:59 +02:00
config	kconfig: config script: add a little user help	2021-01-04 10:38:11 +09:00
const_structs.checkpatch	const_structs.checkpatch: add pinctrl_ops and pinmux_ops	2020-10-16 11:11:21 -07:00
decode_stacktrace.sh	scripts/decode_stacktrace.sh: optionally use LLVM utilities	2024-02-23 08:55:13 +01:00
decodecode	scripts/decodecode: add the capability to supply the program counter	2020-10-13 18:38:26 -07:00
depmod.sh	depmod: handle the case of /sbin/depmod without /sbin in PATH	2021-01-01 12:26:39 -08:00
dev-needs.sh	scripts/dev-needs: Add script to list device dependencies	2020-09-04 18:19:37 +02:00
diffconfig	scripts: handle BrokenPipeError for python scripts	2023-03-17 08:49:02 +01:00
documentation-file-ref-check	documentation-file-ref-check: Make git check work for multiple working directories	2021-06-04 11:20:52 -06:00
export_report.pl	modpost: move the namespace field in Module.symvers last	2020-03-17 08:59:03 +09:00
extract-cert.c	cert host tools: Stop complaining about deprecated OpenSSL functions	2022-11-16 09:58:28 +01:00
extract-ikconfig	…
extract-module-sig.pl	…
extract-sys-certs.pl	…
extract-vmlinux	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 378	2019-06-05 17:37:10 +02:00
extract_xc3028.pl	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 339	2019-06-05 17:37:07 +02:00
faddr2line	scripts/faddr2line: Fix regression in name resolution on ppc64le	2022-12-08 11:28:38 +01:00
file-size.sh	…
find-unused-docs.sh	scripts/find-unused-docs: Fix massive false positives	2020-01-27 14:25:06 -07:00
gcc-goto.sh	jump_label: move 'asm goto' support test to Kconfig	2019-01-06 09:46:51 +09:00
gcc-ld	…
gcc-x86_32-has-stack-protector.sh	x86/stackprotector/32: Make the canary into a regular percpu variable	2021-03-08 13:19:05 +01:00
gcc-x86_64-has-stack-protector.sh	…
gen_autoksyms.sh	kbuild: Fix TRIM_UNUSED_KSYMS with LTO_CLANG	2021-09-03 08:12:39 +09:00
gen_ksymdeps.sh	kbuild: redo fake deps at include/ksym/*.h	2021-09-03 08:17:21 +09:00
generate_initcall_order.pl	init: lto: ensure initcall ordering	2021-01-14 08:21:09 -08:00
get_abi.pl	scripts/get_abi: fix source path leak	2024-02-23 08:54:25 +01:00
get_dvb_firmware	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61	2019-05-24 17:36:45 +02:00
get_feat.pl	scripts: get_feat.pl: reduce table width for all features output	2020-12-04 14:34:27 -07:00
get_maintainer.pl	get_maintainer: exclude MAINTAINERS file(s) from --git-fallback	2020-10-16 11:11:19 -07:00
gfp-translate	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 166	2019-05-30 11:26:39 -07:00
headerdep.pl	…
headers_check.pl	…
headers_install.sh	Merge branch 'work.fdpic' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2020-08-07 13:29:39 -07:00
insert-sys-cert.c	…
jobserver-exec	scripts/jobserver-exec: Fix a typo ("envirnoment")	2021-05-17 12:10:03 +09:00
kallsyms.c	kallsyms: fix nonconverging kallsyms table with lld	2021-02-05 17:53:28 +09:00
kernel-doc	stddef: Introduce DECLARE_FLEX_ARRAY() helper	2022-07-12 16:35:03 +02:00
ld-version.sh	kbuild: collect minimum tool versions into scripts/min-tool-version.sh	2021-04-25 05:14:26 +09:00
leaking_addresses.pl	leaking_addresses: Always print a trailing newline	2021-11-18 19:16:16 +01:00
link-vmlinux.sh	kbuild: Fix changing ELF file type for output of gen_btf for big endian	2024-02-23 08:55:05 +01:00
makelst	…
markup_oops.pl	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 373	2019-06-05 17:37:10 +02:00
min-tool-version.sh	Documentation: raise minimum supported version of GCC to 5.1	2021-09-13 10:18:28 -07:00
mkcompile_h	kbuild: mkcompile_h: consider timestamp if KBUILD_BUILD_TIMESTAMP is set	2021-06-17 10:01:12 +09:00
mksysmap	mksysmap: Fix the mismatch of 'L0' symbols in System.map	2022-09-23 14:15:51 +02:00
mkuboot.sh	…
module.lds.S	modules: Ensure natural alignment for .altinstructions and __bug_table sections	2022-08-25 11:40:41 +02:00
modules-check.sh	kbuild: check module name conflict for external modules as well	2021-04-25 05:22:42 +09:00
nsdeps	kbuild: replace LANG=C with LC_ALL=C	2021-05-02 00:43:35 +09:00
objdiff	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 199	2019-05-30 11:29:23 -07:00
pahole-flags.sh	bpf: Add --skip_encoding_btf_inconsistent_proto, --btf_gen_optimized to pahole flags for v1.25	2024-01-25 14:52:31 -08:00
pahole-version.sh	kbuild: Add CONFIG_PAHOLE_VERSION	2023-02-25 12:06:45 +01:00
parse-maintainers.pl	parse-maintainers: Do not sort section content by default	2020-03-26 15:08:27 -07:00
patch-kernel	…
profile2linkerlist.pl	…
prune-kernel	…
recordmcount.c	recordmcount: Fix memory leaks in the uwrite function	2023-05-24 17:36:47 +01:00
recordmcount.h	recordmcount: Correct st_shndx handling	2021-06-18 09:09:17 -04:00
recordmcount.pl	recordmcount.pl: fix typo in s390 mcount regex	2022-01-05 12:42:33 +01:00
remove-stale-files	kbuild: add a script to remove stale generated files	2021-05-02 00:43:35 +09:00
setlocalversion	scripts/setlocalversion: fix a bug when LOCALVERSION is empty	2021-07-18 23:48:14 +09:00
show_delta	tweewide: Fix most Shebang lines	2020-12-08 23:30:04 +09:00
sign-file.c	sign-file: Fix incorrect return values check	2023-12-20 15:17:37 +01:00
sorttable.c	x86/extable: Rework the exception table mechanics	2022-07-29 17:25:25 +02:00
sorttable.h	scripts/sorttable: Implement build-time ORC unwind table sorting	2019-12-13 10:47:58 +01:00
spdxcheck-test.sh	scripts/spdxcheck-test.sh: Drop python2	2021-07-21 15:59:32 +02:00
spdxcheck.py	scripts/spdxcheck.py: Strictly read license files in utf-8	2021-07-12 09:56:50 -06:00
spelling.txt	scripts/spelling.txt: add more spellings to spelling.txt	2021-06-29 10:53:45 -07:00
sphinx-pre-install	scripts: sphinx-pre-install: Fix ctex support on Debian	2022-01-27 11:05:44 +01:00
split-man.pl	tweewide: Fix most Shebang lines	2020-12-08 23:30:04 +09:00
stackdelta	…
stackusage	…
subarch.include	parisc: Fix compile failure when building 64-bit kernel natively	2021-09-01 21:52:02 +02:00
syscallhdr.sh	scripts: check duplicated syscall number in syscall table	2021-07-09 04:00:39 +09:00
syscallnr.sh	scripts: make some scripts executable	2021-08-10 09:13:25 +09:00
syscalltbl.sh	scripts: check duplicated syscall number in syscall table	2021-07-09 04:00:39 +09:00
tags.sh	scripts/tags.sh: Resolve gtags empty index generation	2023-07-05 18:25:05 +01:00
tools-support-relr.sh	Makefile: fix GDB warning with CONFIG_RELR	2021-06-08 13:09:34 +01:00
unifdef.c	unifdef: use memcpy instead of strncpy	2018-11-30 14:45:01 -08:00
ver_linux	Removed the oprofiled version option	2021-05-03 17:23:06 -06:00
xen-hypercalls.sh	scripts: make some scripts executable	2021-08-10 09:13:25 +09:00
xz_wrap.sh	kbuild: add variables for compression tools	2020-06-06 23:42:01 +09:00