Dmitry Safonov 83d817f410 tty: Hold tty_ldisc_lock() during tty_reopen() ... tty_ldisc_reinit() doesn't race with neither tty_ldisc_hangup() nor set_ldisc() nor tty_ldisc_release() as they use tty lock. But it races with anyone who expects line discipline to be the same after hoding read semaphore in tty_ldisc_ref(). We've seen the following crash on v4.9.108 stable: BUG: unable to handle kernel paging request at 0000000000002260 IP: [..] n_tty_receive_buf_common+0x5f/0x86d Workqueue: events_unbound flush_to_ldisc Call Trace: [..] n_tty_receive_buf2 [..] tty_ldisc_receive_buf [..] flush_to_ldisc [..] process_one_work [..] worker_thread [..] kthread [..] ret_from_fork tty_ldisc_reinit() should be called with ldisc_sem hold for writing, which will protect any reader against line discipline changes. Cc: Jiri Slaby <jslaby@suse.com> Cc: stable@vger.kernel.org # b027e2298b ("tty: fix data race between tty_init_dev and flush of buf") Reviewed-by: Jiri Slaby <jslaby@suse.cz> Reported-by: syzbot+3aa9784721dfb90e984d@syzkaller.appspotmail.com Tested-by: Mark Rutland <mark.rutland@arm.com> Tested-by: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> Signed-off-by: Dmitry Safonov <dima@arista.com> Tested-by: Tycho Andersen <tycho@tycho.ws> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-12-05 12:16:33 +01:00
..
accessibility	…
acpi	ACPI / platform: Add SMB0001 HID to forbidden_id_list	2018-11-21 13:30:13 +01:00
amba	…
android	…
ata	libata: blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD	2018-11-12 12:44:19 -07:00
atm	atm: zatm: Fix empty body Clang warnings	2018-10-18 15:39:10 -07:00
auxdisplay	The Compiler Attributes series	2018-11-01 18:34:46 -07:00
base	mm/memory_hotplug: fix online/offline_pages called w.o. mem_hotplug_lock	2018-10-31 08:54:17 -07:00
bcma	…
block	for-linus-20181115	2018-11-16 09:31:59 -06:00
bluetooth	Merge branch 'work.tty-ioctl' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2018-10-24 14:43:41 +01:00
bus	ARM: SoC driver updates for 4.17	2018-10-29 15:16:01 -07:00
cdrom	gdrom: fix mistake in assignment of error	2018-10-25 11:17:40 -06:00
char	ttyprintk: make the printk log level configurable	2018-11-09 08:58:18 -08:00
clk	clk: qcom: gcc: Fix board clock node name	2018-11-09 14:13:55 -08:00
clocksource	Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-11-11 16:41:50 -06:00
connector	…
cpufreq	cpufreq: ti-cpufreq: Only register platform_device when supported	2018-11-19 11:26:06 +01:00
cpuidle	ARM: cpuidle: Convert to use cpuidle_register|unregister()	2018-11-08 18:53:00 +01:00
crypto	crypto: hisilicon - Fix reference after free of memories on error path	2018-11-09 17:35:43 +08:00
dax	…
dca	…
devfreq	…
dio	…
dma	pci-v4.20-changes	2018-10-25 06:50:48 -07:00
dma-buf	udmabuf: set read/write flag when exporting	2018-11-16 08:50:53 +01:00
edac	* skx_edac: Address translation for NVDIMMs (Tony Luck and Qiuxu Zhuo)	2018-11-02 11:17:22 -07:00
eisa	…
extcon	…
firewire	…
firmware	efi: Permit calling efi_mem_reserve_persistent() from atomic context	2018-11-15 10:04:47 +01:00
fmc	…
fpga	fpga: add devm_fpga_region_create	2018-10-16 11:13:50 +02:00
fsi	iov_iter: Separate type from direction and use accessor functions	2018-10-24 00:41:07 +01:00
gnss	serdev: make synchronous write return bytes written	2018-11-27 19:44:21 +01:00
gpio	gpio: mockup: fix indicated direction	2018-11-16 23:06:29 +01:00
gpu	Merge tag 'drm-intel-fixes-2018-11-22' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes	2018-11-23 11:03:21 +10:00
hid	Revert "HID: input: Create a utility class for counting scroll events"	2018-11-22 08:57:38 +01:00
hsi	…
hv	Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up	2018-11-11 09:00:20 -08:00
hwmon	hwmon: (ibmpowernv) Remove bogus __init annotations	2018-11-04 15:55:12 -08:00
hwspinlock	…
hwtracing	stm class: Use memcat_p()	2018-10-11 12:12:55 +02:00
i2c	i2c: nvidia-gpu: make pm_ops static	2018-11-09 17:56:44 +01:00
ide	…
idle	Merge branch 'perf-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-10-23 13:32:18 +01:00
iio	Staging/IIO patches for 4.20-rc1	2018-10-29 10:38:10 -07:00
infiniband	Revert "mm, mmu_notifier: annotate mmu notifiers with blockable invalidate callbacks"	2018-10-26 16:25:19 -07:00
input	Merge branch 'xarray' of git://git.infradead.org/users/willy/linux-dax	2018-10-28 11:35:40 -07:00
iommu	iommu/vt-d: Use memunmap to free memremap	2018-11-22 17:02:21 +01:00
ipack	…
irqchip	irqchip/irq-mvebu-sei: Fix a NULL vs IS_ERR() bug in probe function	2018-11-01 12:38:48 +01:00
isdn	Merge branch 'work.afs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2018-11-01 19:58:52 -07:00
leds	LED fixes for 4.20-rc2	2018-11-08 17:49:04 -06:00
lightnvm	lightnvm: pblk: guarantee that backpointer is respected on writer stall	2018-10-09 08:25:08 -06:00
macintosh	memblock: stop using implicit alignment to SMP_CACHE_BYTES	2018-10-31 08:54:16 -07:00
mailbox	- Convert print users to use the %pOFn format specifier	2018-10-29 10:30:44 -07:00
mcb	…
md	for-linus-20181102	2018-11-02 11:25:48 -07:00
media	media: ipu3-cio2: Use cio2_queues_exit	2018-11-06 07:11:59 -05:00
memory	…
memstick	…
message	…
mfd	chrome-platform for v4.20	2018-10-31 16:47:55 -07:00
misc	misc: atmel-ssc: Fix section annotation on atmel_ssc_get_driver_data	2018-11-11 09:13:19 -08:00
mmc	mmc: sdhci-pci: Workaround GLK firmware failing to restore the tuning value	2018-11-19 14:11:07 +01:00
mtd	mtd: spi-nor: fix selection of uniform erase type in flexible conf	2018-11-20 14:26:59 +01:00
mux	This is the bulk of GPIO changes for the v4.20 series:	2018-10-23 08:45:05 +01:00
net	net: gemini: Fix copy/paste error	2018-11-23 22:35:38 -08:00
nfc	NFC: nfcmrvl_uart: fix OF child-node lookup	2018-10-23 13:28:53 -05:00
ntb	ntb: idt: Alter the driver info comments	2018-11-01 10:33:12 -04:00
nubus	…
nvdimm	libnvdimm for 4.20	2018-10-25 06:31:56 -07:00
nvme	nvme-fc: resolve io failures during connect	2018-11-15 11:37:55 +01:00
nvmem	nvmem: core: fix regression in of_nvmem_cell_get()	2018-11-11 09:15:29 -08:00
of	Devicetree fixes for 4.20-rc:	2018-11-09 16:41:58 -06:00
opp	opp: ti-opp-supply: Correct the supply in _get_optimal_vdd_voltage call	2018-11-13 09:40:29 +05:30
oprofile	…
parisc	parisc: Add alternative coding infrastructure	2018-10-17 17:22:26 +02:00
parport	…
pci	Revert "ACPI/PCI: Pay attention to device-specific _PXM node values"	2018-11-13 08:38:17 -06:00
pcmcia	powerpc updates for 4.20	2018-10-26 14:36:21 -07:00
perf	arm64 updates for 4.20:	2018-10-22 17:30:06 +01:00
phy	USB/PHY patches for 4.20-rc1	2018-10-26 08:14:13 -07:00
pinctrl	pinctrl: meson: fix meson8b ao pull register bits	2018-11-05 09:33:22 +01:00
platform	platform-drivers-x86 for v4.20-1	2018-11-01 08:42:21 -07:00
pnp	…
power	Devicetree updates for 4.20:	2018-10-26 12:09:58 -07:00
powercap	Merge branch 'perf-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-10-23 13:32:18 +01:00
pps	…
ps3	…
ptp	ptp: drop redundant kasprintf() to create worker name	2018-10-28 19:20:06 -07:00
pwm	pwm: lpss: Only set update bit if we are actually changing the settings	2018-10-16 13:16:15 +02:00
rapidio	…
ras	…
regulator	regulator: Regulator updates for next release	2018-10-23 01:54:44 +01:00
remoteproc	remoteproc: qcom: q6v5-mss: Register segments/dumpfn for coredump	2018-10-19 12:54:03 -07:00
reset	ARM: SoC driver updates for 4.17	2018-10-29 15:16:01 -07:00
rpmsg	…
rtc	rtc: pcf2127: fix a kmemleak caused in pcf2127_i2c_gather_write	2018-11-07 17:13:56 +01:00
s390	s390/ism: clear dmbe_mask bit before SMC IRQ handling	2018-11-14 14:21:20 -08:00
sbus	…
scsi	SCSI fixes on 20181121	2018-11-22 08:31:46 -08:00
sfi	mm: remove include/linux/bootmem.h	2018-10-31 08:54:16 -07:00
sh	…
siox	…
slimbus	slimbus: ngd: remove unnecessary check	2018-11-07 14:59:28 +01:00
sn	…
soc	soc: ti: QMSS: Fix usage of irq_set_affinity_hint	2018-11-02 11:22:09 -07:00
soundwire	…
spi	- New Drivers	2018-10-25 06:19:15 -07:00
spmi	…
ssb	…
staging	media: dm365_ipipeif: better annotate a fall though	2018-11-06 06:58:07 -05:00
target	scsi: target/core: Avoid that a kernel oops is triggered when COMPARE AND WRITE fails	2018-11-05 22:16:00 -05:00
tc	TC: Set DMA masks for devices	2018-10-11 09:16:44 -07:00
tee	…
thermal	Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux	2018-10-31 11:28:12 -07:00
thunderbolt	…
tty	tty: Hold tty_ldisc_lock() during tty_reopen()	2018-12-05 12:16:33 +01:00
uio	uio: Fix an Oops on load	2018-11-11 09:21:46 -08:00
usb	USB fixes for 4.20-rc4	2018-11-22 08:39:29 -08:00
uwb	…
vfio	VFIO updates for v4.20	2018-10-31 11:01:38 -07:00
vhost	virtio, vhost: fixes, tweaks	2018-11-01 14:42:49 -07:00
video	fbdev changes for v4.20:	2018-10-31 11:41:37 -07:00
virt	…
virtio	virtio-balloon: VIRTIO_BALLOON_F_PAGE_POISON	2018-10-24 20:57:55 -04:00
visorbus	…
vlynq	…
vme	…
w1	w1: IAD Register is yet readable trough iad sys file. Fix snprintf (%u for unsigned, count for max size).	2018-10-15 20:50:32 +02:00
watchdog	watchdog: ts4800: release syscon device node in ts4800_wdt_probe()	2018-10-22 10:16:28 +02:00
xen	xen: fixes for 4.20-rc2	2018-11-10 08:58:48 -06:00
zorro	…
Kconfig	…
Makefile	…