WSL2-Linux-Kernel/drivers/pinctrl/intel
Mika Westerberg 72923e5488 Revert "pinctrl: intel: Do pin translation when lock IRQ"
This reverts commit 55aedef50d.

Commit 55aedef50d ("pinctrl: intel: Do pin translation when lock IRQ")
added special translation from GPIO number to hardware pin number to
irq_reqres/relres hooks to avoid failure when IRQs are requested. The
actual failure happened inside gpiochip_lock_as_irq() because it calls
gpiod_get_direction() and pinctrl-intel.c::intel_gpio_get_direction()
implementation originally missed the translation so the two hooks made
it work by skipping the ->get_direction() call entirely (it overwrote
the default GPIOLIB provided functions).

The proper fix that adds translation to GPIO callbacks was merged with
commit 96147db1e1 ("pinctrl: intel: Do pin translation in other GPIO
operations as well"). This allows us to use the default GPIOLIB provided
functions again.

In addition as find out by Benjamin Tissoires the two functions
(intel_gpio_irq_reqres()/intel_gpio_irq_relres()) now cause problems of
their own because they operate on pin numbers and pass that pin number
to gpiochip_lock_as_irq() which actually expects a GPIO number.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=199911
Fixes: 55aedef50d ("pinctrl: intel: Do pin translation when lock IRQ")
Reported-and-tested-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
2018-09-25 12:50:00 +02:00
..
Kconfig pinctrl: intel: Convert to use SPDX identifier 2018-07-02 15:52:10 +02:00
Makefile pinctrl: intel: Add Ice Lake PCH pin controller support 2018-06-29 14:51:26 +02:00
pinctrl-baytrail.c pinctrl: baytrail: actually print the apparently misconfigured pin 2018-08-03 19:14:50 +02:00
pinctrl-broxton.c pinctrl: intel: Convert to use SPDX identifier 2018-07-02 15:52:10 +02:00
pinctrl-cannonlake.c pinctrl: cannonlake: Fix HOSTSW_OWN register offset of H variant 2018-09-25 12:48:15 +02:00
pinctrl-cedarfork.c pinctrl: intel: Convert to use SPDX identifier 2018-07-02 15:52:10 +02:00
pinctrl-cherryview.c pinctrl: intel: Convert to use SPDX identifier 2018-07-02 15:52:10 +02:00
pinctrl-denverton.c pinctrl: intel: Convert to use SPDX identifier 2018-07-02 15:52:10 +02:00
pinctrl-geminilake.c pinctrl: intel: Convert to use SPDX identifier 2018-07-02 15:52:10 +02:00
pinctrl-icelake.c pinctrl: intel: Add Ice Lake PCH pin controller support 2018-06-29 14:51:26 +02:00
pinctrl-intel.c Revert "pinctrl: intel: Do pin translation when lock IRQ" 2018-09-25 12:50:00 +02:00
pinctrl-intel.h pinctrl: intel: Convert to use SPDX identifier 2018-07-02 15:52:10 +02:00
pinctrl-lewisburg.c pinctrl: intel: Convert to use SPDX identifier 2018-07-02 15:52:10 +02:00
pinctrl-merrifield.c Char/Misc driver patches for 4.19-rc1 2018-08-18 11:04:51 -07:00
pinctrl-sunrisepoint.c pinctrl: intel: Convert to use SPDX identifier 2018-07-02 15:52:10 +02:00