WSL2-Linux-Kernel/net
Steven Rostedt (Google) 292a089d78 treewide: Convert del_timer*() to timer_shutdown*()
Due to several bugs caused by timers being re-armed after they are
shutdown and just before they are freed, a new state of timers was added
called "shutdown".  After a timer is set to this state, then it can no
longer be re-armed.

The following script was run to find all the trivial locations where
del_timer() or del_timer_sync() is called in the same function that the
object holding the timer is freed.  It also ignores any locations where
the timer->function is modified between the del_timer*() and the free(),
as that is not considered a "trivial" case.

This was created by using a coccinelle script and the following
commands:

    $ cat timer.cocci
    @@
    expression ptr, slab;
    identifier timer, rfield;
    @@
    (
    -       del_timer(&ptr->timer);
    +       timer_shutdown(&ptr->timer);
    |
    -       del_timer_sync(&ptr->timer);
    +       timer_shutdown_sync(&ptr->timer);
    )
      ... when strict
          when != ptr->timer
    (
            kfree_rcu(ptr, rfield);
    |
            kmem_cache_free(slab, ptr);
    |
            kfree(ptr);
    )

    $ spatch timer.cocci . > /tmp/t.patch
    $ patch -p1 < /tmp/t.patch

Link: https://lore.kernel.org/lkml/20221123201306.823305113@linutronix.de/
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Acked-by: Pavel Machek <pavel@ucw.cz> [ LED ]
Acked-by: Kalle Valo <kvalo@kernel.org> [ wireless ]
Acked-by: Paolo Abeni <pabeni@redhat.com> [ networking ]
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2022-12-25 13:38:09 -08:00
..
6lowpan
9p 9p-for-6.2-rc1 2022-12-23 11:39:18 -08:00
802 treewide: Convert del_timer*() to timer_shutdown*() 2022-12-25 13:38:09 -08:00
8021q
appletalk
atm
ax25
batman-adv
bluetooth
bpf
bpfilter
bridge treewide: Convert del_timer*() to timer_shutdown*() 2022-12-25 13:38:09 -08:00
caif
can
ceph Treewide: Stop corrupting socket's task_frag 2022-12-19 17:28:49 -08:00
core treewide: Convert del_timer*() to timer_shutdown*() 2022-12-25 13:38:09 -08:00
dcb
dccp
dns_resolver
dsa
ethernet
ethtool
hsr
ieee802154
ife
ipv4 treewide: Convert del_timer*() to timer_shutdown*() 2022-12-25 13:38:09 -08:00
ipv6 treewide: Convert del_timer*() to timer_shutdown*() 2022-12-25 13:38:09 -08:00
iucv
kcm
key
l2tp
l3mdev
lapb
llc
mac80211 treewide: Convert del_timer*() to timer_shutdown*() 2022-12-25 13:38:09 -08:00
mac802154
mctp
mpls
mptcp
ncsi
netfilter treewide: Convert del_timer*() to timer_shutdown*() 2022-12-25 13:38:09 -08:00
netlabel
netlink
netrom
nfc
nsh
openvswitch
packet
phonet
psample
qrtr
rds
rfkill
rose
rxrpc
sched treewide: Convert del_timer*() to timer_shutdown*() 2022-12-25 13:38:09 -08:00
sctp
smc
strparser
sunrpc treewide: Convert del_timer*() to timer_shutdown*() 2022-12-25 13:38:09 -08:00
switchdev
tipc treewide: Convert del_timer*() to timer_shutdown*() 2022-12-25 13:38:09 -08:00
tls
unix
vmw_vsock
wireless
x25
xdp
xfrm Treewide: Stop corrupting socket's task_frag 2022-12-19 17:28:49 -08:00
Kconfig
Kconfig.debug
Makefile
compat.c
devres.c
socket.c
sysctl_net.c