Paolo Abeni b406472b5a net: ipv4: avoid mixed n_redirects and rate_tokens usage ... Since commit c09551c6ff ("net: ipv4: use a dedicated counter for icmp_v4 redirect packets") we use 'n_redirects' to account for redirect packets, but we still use 'rate_tokens' to compute the redirect packets exponential backoff. If the device sent to the relevant peer any ICMP error packet after sending a redirect, it will also update 'rate_token' according to the leaking bucket schema; typically 'rate_token' will raise above BITS_PER_LONG and the redirect packets backoff algorithm will produce undefined behavior. Fix the issue using 'n_redirects' to compute the exponential backoff in ip_rt_send_redirect(). Note that we still clear rate_tokens after a redirect silence period, to avoid changing an established behaviour. The root cause predates git history; before the mentioned commit in the critical scenario, the kernel stopped sending redirects, after the mentioned commit the behavior more randomic. Reported-by: Xiumei Mu <xmu@redhat.com> Fixes: 1da177e4c3 ("Linux-2.6.12-rc2") Fixes: c09551c6ff ("net: ipv4: use a dedicated counter for icmp_v4 redirect packets") Signed-off-by: Paolo Abeni <pabeni@redhat.com> Acked-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-10-04 17:27:04 -07:00
..
bpfilter	…
netfilter	netfilter: drop bridge nf reset from nf_reset	2019-10-01 18:42:15 +02:00
Kconfig	net: Fix Kconfig indentation	2019-09-26 08:56:17 +02:00
Makefile	…
af_inet.c	net: remove empty inet_exit_net	2019-08-19 18:22:54 -07:00
ah4.c	xfrm: remove type and offload_type map from xfrm_state_afinfo	2019-06-06 08:34:50 +02:00
arp.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cipso_ipv4.c	…
datagram.c	udp: correct reuseport selection with connected sockets	2019-09-16 09:02:18 +02:00
devinet.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-07-08 19:48:57 -07:00
esp4.c	xfrm: remove get_mtu indirection from xfrm_type	2019-07-01 06:16:40 +02:00
esp4_offload.c	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next	2019-07-05 15:01:15 -07:00
fib_frontend.c	ipv4: Add lockdep condition to fix for_each_entry()	2019-08-09 11:01:08 -07:00
fib_lookup.h	ipv4: Use accessors for fib_info nexthop data	2019-06-04 19:26:49 -07:00
fib_notifier.c	…
fib_rules.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-07 11:00:14 -07:00
fib_semantics.c	net: Properly update v4 routes with v6 nexthop	2019-09-05 12:35:58 +02:00
fib_trie.c	net: route dump netlink NLM_F_MULTI flag missing	2019-08-24 16:49:48 -07:00
fou.c	…
gre_demux.c	net: remove unused parameter from skb_checksum_try_convert	2019-07-05 15:30:36 -07:00
gre_offload.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
icmp.c	ipv4/icmp: fix rt dst dev null pointer dereference	2019-08-24 14:49:35 -07:00
igmp.c	net: fix __ip_mc_inc_group usage	2019-08-20 12:48:06 -07:00
inet_connection_sock.c	ipv4: Revert removal of rt_uses_gateway	2019-09-20 18:23:33 -07:00
inet_diag.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
inet_fragment.c	inet: frags: re-introduce skb coalescing for local delivery	2019-08-08 15:55:10 -07:00
inet_hashtables.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-07 11:00:14 -07:00
inet_timewait_sock.c	…
inetpeer.c	…
ip_forward.c	ipv4: Revert removal of rt_uses_gateway	2019-09-20 18:23:33 -07:00
ip_fragment.c	inet: frags: re-introduce skb coalescing for local delivery	2019-08-08 15:55:10 -07:00
ip_gre.c	erspan: remove the incorrect mtu limit for erspan	2019-09-30 11:10:07 -07:00
ip_input.c	netfilter: drop bridge nf reset from nf_reset	2019-10-01 18:42:15 +02:00
ip_options.c	netfilter: nf_tables: add support for matching IPv4 options	2019-06-21 18:35:51 +02:00
ip_output.c	tcp: honor SO_PRIORITY in TIME_WAIT state	2019-09-27 12:05:02 +02:00
ip_sockglue.c	…
ip_tunnel.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 269	2019-06-05 17:30:29 +02:00
ip_tunnel_core.c	ip_tunnel: allow not to count pkts on tstats by setting skb's dev to NULL	2019-06-18 20:48:45 -04:00
ip_vti.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
ipcomp.c	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next	2019-07-05 15:01:15 -07:00
ipconfig.c	…
ipip.c	ipip: validate header length in ipip_tunnel_xmit	2019-07-25 17:23:40 -07:00
ipmr.c	netfilter: drop bridge nf reset from nf_reset	2019-10-01 18:42:15 +02:00
ipmr_base.c	…
metrics.c	…
netfilter.c	…
netlink.c	…
nexthop.c	nexthops: remove redundant assignment to variable err	2019-08-22 12:14:05 -07:00
ping.c	ip: support SO_MARK cmsg	2019-09-13 21:44:19 +02:00
proc.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-17 20:20:36 -07:00
protocol.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
raw.c	netfilter: drop bridge nf reset from nf_reset	2019-10-01 18:42:15 +02:00
raw_diag.c	net: don't warn in inet diag when IPV6 is disabled	2019-07-03 11:26:35 -07:00
route.c	net: ipv4: avoid mixed n_redirects and rate_tokens usage	2019-10-04 17:27:04 -07:00
syncookies.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sysctl_net_ipv4.c	tcp: add new tcp_mtu_probe_floor sysctl	2019-08-09 13:03:30 -07:00
tcp.c	tcp: fix slab-out-of-bounds in tcp_zerocopy_receive()	2019-10-03 12:05:34 -07:00
tcp_bbr.c	tcp_bbr: fix quantization code to not raise cwnd if not probing bandwidth	2019-09-27 20:37:50 +02:00
tcp_bic.c	…
tcp_bpf.c	net/tls: prevent skb_orphan() from leaking TLS plain text with offload	2019-08-08 22:39:35 -07:00
tcp_cdg.c	…
tcp_cong.c	tcp: fix tcp_set_congestion_control() use from bpf hook	2019-07-18 20:33:48 -07:00
tcp_cubic.c	…
tcp_dctcp.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
tcp_dctcp.h	…
tcp_diag.c	tcp: ulp: fix possible crash in tcp_diag_get_aux_size()	2019-09-07 17:32:28 +02:00
tcp_fastopen.c	net: fastopen: robustness and endianness fixes for SipHash	2019-06-22 16:30:37 -07:00
tcp_highspeed.c	…
tcp_htcp.c	…
tcp_hybla.c	…
tcp_illinois.c	…
tcp_input.c	tcp: Add TCP_INFO counter for packets received out-of-order	2019-09-16 16:26:11 +02:00
tcp_ipv4.c	netfilter: drop bridge nf reset from nf_reset	2019-10-01 18:42:15 +02:00
tcp_lp.c	…
tcp_metrics.c	…
tcp_minisocks.c	tcp: honor SO_PRIORITY in TIME_WAIT state	2019-09-27 12:05:02 +02:00
tcp_nv.c	…
tcp_offload.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
tcp_output.c	tcp: force a PSH flag on TSO packets	2019-09-11 23:59:01 +01:00
tcp_rate.c	…
tcp_recovery.c	…
tcp_scalable.c	…
tcp_timer.c	tcp: adjust rto_base in retransmits_timed_out()	2019-10-01 21:40:49 -04:00
tcp_ulp.c	bpf: sockmap/tls, close can race with map free	2019-07-22 16:04:17 +02:00
tcp_vegas.c	…
tcp_vegas.h	…
tcp_veno.c	…
tcp_westwood.c	…
tcp_yeah.c	…
tunnel4.c	…
udp.c	udp: only do GSO if # of segs > 1	2019-10-03 11:47:10 -04:00
udp_diag.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
udp_impl.h	…
udp_offload.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-22 08:59:24 -04:00
udp_tunnel.c	…
udplite.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
xfrm4_input.c	…
xfrm4_output.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
xfrm4_policy.c	ipv4: Revert removal of rt_uses_gateway	2019-09-20 18:23:33 -07:00
xfrm4_protocol.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
xfrm4_state.c	xfrm: remove eth_proto value from xfrm_state_afinfo	2019-06-06 08:34:50 +02:00
xfrm4_tunnel.c	xfrm: remove type and offload_type map from xfrm_state_afinfo	2019-06-06 08:34:50 +02:00