WSL2-Linux-Kernel/drivers/staging/greybus
Jiasheng Jiang c154574b84 staging: greybus: audio: Check null pointer
[ Upstream commit 2e81948177 ]

As the possible alloc failure of devm_kcalloc(), it could return null
pointer.
Therefore, 'strings' should be checked and return NULL if alloc fails to
prevent the dereference of the NULL pointer.
Also, the caller should also deal with the return value of the
gb_generate_enum_strings() and return -ENOMEM if returns NULL.
Moreover, because the memory allocated with devm_kzalloc() will be
freed automatically when the last reference to the device is dropped,
the 'gbe' in gbaudio_tplg_create_enum_kctl() and
gbaudio_tplg_create_enum_ctl() do not need to free manually.
But the 'control' in gbaudio_tplg_create_widget() and
gbaudio_tplg_process_kcontrols() has a specially error handle to
cleanup.
So it should be better to cleanup 'control' when fails.

Fixes: e65579e335 ("greybus: audio: topology: Enable enumerated control support")
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Link: https://lore.kernel.org/r/20220104150628.1987906-1-jiasheng@iscas.ac.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-01-27 11:03:52 +01:00
..
Documentation
tools
Kconfig
Makefile
TODO staging: greybus: Add TODO item about modernizing the pwm code 2020-12-09 15:49:04 +01:00
arche-apb-ctrl.c
arche-platform.c staging: greybus: arche-platform: Ending line with argument 2021-04-02 14:56:34 +02:00
arche_platform.h
audio_apbridgea.c
audio_apbridgea.h
audio_codec.c staging: greybus: codecs: Fix reference counter leak in error handling 2020-11-13 15:34:07 +01:00
audio_codec.h
audio_gb.c
audio_helper.c staging: greybus: Add missing rwsem around snd_ctl_remove() calls 2021-12-01 09:04:41 +01:00
audio_helper.h
audio_manager.c
audio_manager.h
audio_manager_module.c staging: greybus: audio: code indentation and formatting changes 2020-10-26 06:53:10 +01:00
audio_manager_private.h
audio_manager_sysfs.c staging: greybus: minor code style fix 2021-02-13 22:37:50 +01:00
audio_module.c staging/greybus: eliminate use of NAME_SIZE for strings 2021-03-10 09:25:33 +01:00
audio_topology.c staging: greybus: audio: Check null pointer 2022-01-27 11:03:52 +01:00
authentication.c
bootrom.c
camera.c staging: greybus: camera: Switch to memdup_user_nul() 2021-04-02 14:56:38 +02:00
firmware.h
fw-core.c
fw-download.c
fw-management.c
gb-camera.h
gbphy.c bus: Make remove callback return void 2021-07-21 11:53:42 +02:00
gbphy.h
gpio.c
greybus_authentication.h
greybus_firmware.h
hid.c staging: greybus: Fixed a misspelling in hid.c 2021-02-13 22:37:51 +01:00
i2c.c
light.c staging: greybus: light: Use kzalloc for allocating only one thing 2021-01-05 15:26:43 +01:00
log.c
loopback.c
power_supply.c staging: greybus: Switch from strlcpy to strscpy 2021-02-04 17:16:06 +01:00
pwm.c
raw.c
sdio.c staging: greybus: Fix blank line style issue in sdio.c 2021-03-10 09:25:26 +01:00
spi.c
spilib.c staging: greybus: spi: add blank line after variable declaration 2021-05-20 11:40:36 +02:00
spilib.h
uart.c staging: greybus: uart: fix tty use after free 2021-09-14 09:18:18 +02:00
usb.c
vibrator.c