WSL2-Linux-Kernel/drivers/staging
Steven Rostedt (Google) 292a089d78 treewide: Convert del_timer*() to timer_shutdown*()
Due to several bugs caused by timers being re-armed after they are
shutdown and just before they are freed, a new state of timers was added
called "shutdown".  After a timer is set to this state, then it can no
longer be re-armed.

The following script was run to find all the trivial locations where
del_timer() or del_timer_sync() is called in the same function that the
object holding the timer is freed.  It also ignores any locations where
the timer->function is modified between the del_timer*() and the free(),
as that is not considered a "trivial" case.

This was created by using a coccinelle script and the following
commands:

    $ cat timer.cocci
    @@
    expression ptr, slab;
    identifier timer, rfield;
    @@
    (
    -       del_timer(&ptr->timer);
    +       timer_shutdown(&ptr->timer);
    |
    -       del_timer_sync(&ptr->timer);
    +       timer_shutdown_sync(&ptr->timer);
    )
      ... when strict
          when != ptr->timer
    (
            kfree_rcu(ptr, rfield);
    |
            kmem_cache_free(slab, ptr);
    |
            kfree(ptr);
    )

    $ spatch timer.cocci . > /tmp/t.patch
    $ patch -p1 < /tmp/t.patch

Link: https://lore.kernel.org/lkml/20221123201306.823305113@linutronix.de/
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Acked-by: Pavel Machek <pavel@ucw.cz> [ LED ]
Acked-by: Kalle Valo <kvalo@kernel.org> [ wireless ]
Acked-by: Paolo Abeni <pabeni@redhat.com> [ networking ]
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2022-12-25 13:38:09 -08:00
..
axis-fifo
board
emxx_udc
fbtft
fieldbus
gdm724x
greybus staging: greybus: loopback_test: Remove extra blank lines 2022-12-05 13:28:41 +01:00
iio
ks7010
media treewide: Convert del_timer*() to timer_shutdown*() 2022-12-25 13:38:09 -08:00
most
nvec
octeon
olpc_dcon
pi433
qlge
r8188eu staging: r8188eu: use subtype helper in rtw_check_bcn_info 2022-12-05 13:29:32 +01:00
rtl8192e Staging driver changes for 6.2-rc1 2022-12-16 03:27:03 -08:00
rtl8192u staging: rtl8192u: Fix use after free in ieee80211_rx() 2022-12-05 13:24:50 +01:00
rtl8712
rtl8723bs
rts5208
sm750fb Staging driver changes for 6.2-rc1 2022-12-16 03:27:03 -08:00
vc04_services
vme_user vme: Use root_device_register() not underlined version 2022-12-08 17:00:18 +01:00
vt6655 Staging driver changes for 6.2-rc1 2022-12-16 03:27:03 -08:00
vt6656
wlan-ng treewide: Convert del_timer*() to timer_shutdown*() 2022-12-25 13:38:09 -08:00
Kconfig
Makefile