Eric Dumazet b617158dc0 tcp: be more careful in tcp_fragment() ... Some applications set tiny SO_SNDBUF values and expect TCP to just work. Recent patches to address CVE-2019-11478 broke them in case of losses, since retransmits might be prevented. We should allow these flows to make progress. This patch allows the first and last skb in retransmit queue to be split even if memory limits are hit. It also adds the some room due to the fact that tcp_sendmsg() and tcp_sendpage() might overshoot sk_wmem_queued by about one full TSO skb (64KB size). Note this allowance was already present in stable backports for kernels < 4.15 Note for < 4.15 backports : tcp_rtx_queue_tail() will probably look like : static inline struct sk_buff *tcp_rtx_queue_tail(const struct sock *sk) { struct sk_buff *skb = tcp_send_head(sk); return skb ? tcp_write_queue_prev(sk, skb) : tcp_write_queue_tail(sk); } Fixes: f070ef2ac6 ("tcp: tcp_fragment() should apply sane memory limits") Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: Andrew Prout <aprout@ll.mit.edu> Tested-by: Andrew Prout <aprout@ll.mit.edu> Tested-by: Jonathan Lemon <jonathan.lemon@gmail.com> Tested-by: Michal Kubecek <mkubecek@suse.cz> Acked-by: Neal Cardwell <ncardwell@google.com> Acked-by: Yuchung Cheng <ycheng@google.com> Acked-by: Christoph Paasch <cpaasch@apple.com> Cc: Jonathan Looney <jtl@netflix.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-07-21 20:41:24 -07:00
..
9p	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 188	2019-05-30 11:29:21 -07:00
bluetooth	Bluetooth: Add support for LE ping feature	2019-07-06 15:29:12 +02:00
caif	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 194	2019-05-30 11:29:22 -07:00
iucv	…
netfilter	net: flow_offload: add flow_block structure and use it	2019-07-19 21:27:45 -07:00
netns	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-17 20:20:36 -07:00
nfc	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234	2019-06-19 17:09:07 +02:00
phonet	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 336	2019-06-05 17:37:07 +02:00
sctp	sctp: rename sp strm_interleave to ep intl_enable	2019-07-08 20:16:25 -07:00
tc_act	net/sched: Introduce action ct	2019-07-09 12:11:59 -07:00
6lowpan.h	…
Space.h	…
act_api.h	…
addrconf.h	vrf: Increment Icmp6InMsgs on the original netdev	2019-06-12 11:00:11 -07:00
af_ieee802154.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174	2019-05-30 11:26:41 -07:00
af_rxrpc.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
af_unix.h	…
af_vsock.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 321	2019-06-05 17:37:05 +02:00
ah.h	…
arp.h	…
atmclip.h	…
ax25.h	…
ax88796.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
bond_3ad.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 90	2019-05-24 17:37:53 +02:00
bond_alb.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 5	2019-05-21 11:28:40 +02:00
bond_options.h	bonding: add an option to specify a delay between peer notifications	2019-07-04 12:30:48 -07:00
bonding.h	bonding: add an option to specify a delay between peer notifications	2019-07-04 12:30:48 -07:00
bpf_sk_storage.h	…
busy_poll.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 335	2019-06-05 17:37:06 +02:00
calipso.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13	2019-05-21 11:28:45 +02:00
cfg80211-wext.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
cfg80211.h	nl80211: fix VENDOR_CMD_RAW_DATA	2019-07-20 21:37:32 +02:00
cfg802154.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174	2019-05-30 11:26:41 -07:00
checksum.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cipso_ipv4.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13	2019-05-21 11:28:45 +02:00
cls_cgroup.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
codel.h	…
codel_impl.h	…
codel_qdisc.h	…
compat.h	…
datalink.h	…
dcbevent.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 201	2019-05-30 11:29:52 -07:00
dcbnl.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 201	2019-05-30 11:29:52 -07:00
devlink.h	devlink: Introduce PCI VF port flavour and port attribute	2019-07-09 12:02:13 -07:00
dn.h	…
dn_dev.h	…
dn_fib.h	…
dn_neigh.h	…
dn_nsp.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 24	2019-05-21 11:52:39 +02:00
dn_route.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 24	2019-05-21 11:52:39 +02:00
dsa.h	net: dsa: make cpu_dp non const	2019-06-14 20:20:07 -07:00
dsfield.h	…
dst.h	net: dst.h: Fix shifting signed 32-bit value by 31 bits problem	2019-07-01 10:48:34 -07:00
dst_cache.h	…
dst_metadata.h	…
dst_ops.h	…
erspan.h	…
esp.h	…
ethoc.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
failover.h	…
fib_notifier.h	…
fib_rules.h	net: fib_rules: do not flow dissect local packets	2019-07-11 14:22:53 -07:00
firewire.h	…
flow.h	…
flow_dissector.h	net/flow_dissector: add connection tracking dissection	2019-07-09 12:11:59 -07:00
flow_offload.h	net: flow_offload: add flow_block structure and use it	2019-07-19 21:27:45 -07:00
fou.h	…
fq.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 257	2019-06-05 17:30:27 +02:00
fq_impl.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 257	2019-06-05 17:30:27 +02:00
garp.h	…
gen_stats.h	…
genetlink.h	…
geneve.h	…
gre.h	…
gro_cells.h	…
gtp.h	…
gue.h	net:gue.h:Fix shifting signed 32-bit value by 31 bits problem	2019-07-01 10:58:23 -07:00
hwbm.h	net: hwbm: Make the hwbm_pool lock a mutex	2019-06-09 19:40:10 -07:00
icmp.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
ieee80211_radiotap.h	…
ieee802154_netdev.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174	2019-05-30 11:26:41 -07:00
if_inet6.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
ife.h	…
ila.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
inet6_connection_sock.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
inet6_hashtables.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
inet_common.h	inet: factor out inet_send_prepare()	2019-07-03 13:51:54 -07:00
inet_connection_sock.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
inet_ecn.h	…
inet_frag.h	inet: fix compilation warnings in fqdir_pre_exit()	2019-06-23 11:12:12 -07:00
inet_hashtables.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
inet_sock.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
inet_timewait_sock.h	ipv6: tcp: send consistent autoflowlabel in TIME_WAIT state	2019-06-09 20:10:19 -07:00
inetpeer.h	…
ip.h	ipv4: tcp: fix ACK/RST sent with a transmit delay	2019-06-14 19:51:12 -07:00
ip6_checksum.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
ip6_fib.h	ipv6: Dump route exceptions if requested	2019-06-24 10:18:49 -07:00
ip6_route.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-27 21:06:39 -07:00
ip6_tunnel.h	ip6_tunnel: allow not to count pkts on tstats by passing dev as NULL	2019-06-18 20:48:45 -04:00
ip_fib.h	fib_frontend, ip6_fib: Select routes or exceptions dump from RTM_F_CLONED	2019-06-24 10:18:48 -07:00
ip_tunnels.h	…
ip_vs.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-07-08 19:48:57 -07:00
ipcomp.h	…
ipconfig.h	…
ipv6.h	ipv6: elide flowlabel check if no exclusive leases exist	2019-07-08 19:38:03 -07:00
ipv6_frag.h	inet: fix various use-after-free in defrags units	2019-06-19 11:37:47 -04:00
ipv6_stubs.h	ipv6: export function to send route updates	2019-05-22 17:48:43 -07:00
ipx.h	…
iw_handler.h	…
kcm.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
l3mdev.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
lag.h	…
lapb.h	…
lib80211.h	…
llc.h	…
llc_c_ac.h	…
llc_c_ev.h	…
llc_c_st.h	…
llc_conn.h	…
llc_if.h	…
llc_pdu.h	…
llc_s_ac.h	…
llc_s_ev.h	…
llc_s_st.h	…
llc_sap.h	…
lwtunnel.h	…
mac80211.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-22 08:59:24 -04:00
mac802154.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174	2019-05-30 11:26:41 -07:00
mip6.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13	2019-05-21 11:28:45 +02:00
mld.h	…
mpls.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 295	2019-06-05 17:36:38 +02:00
mpls_iptunnel.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 295	2019-06-05 17:36:38 +02:00
mrp.h	…
ncsi.h	…
ndisc.h	…
neighbour.h	…
net_failover.h	…
net_namespace.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2019-07-11 10:55:49 -07:00
net_ratelimit.h	…
netevent.h	…
netlabel.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13	2019-05-21 11:28:45 +02:00
netlink.h	netlink: Add field to skip in-kernel notifications	2019-06-18 09:45:36 -07:00
netprio_cgroup.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
netrom.h	…
nexthop.h	nexthops: Add ipv6 helper to walk all fib6_nh in a nexthop struct	2019-06-10 10:44:56 -07:00
nl802154.h	…
nsh.h	…
p8022.h	…
page_pool.h	net: core: page_pool: add user refcnt and reintroduce page_pool_destroy	2019-07-08 14:58:04 -07:00
ping.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
pkt_cls.h	net: flow_offload: rename tc_setup_cb_t to flow_setup_cb_t	2019-07-19 21:27:45 -07:00
pkt_sched.h	…
pptp.h	…
protocol.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
psample.h	…
psnap.h	…
raw.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
rawv6.h	…
red.h	…
regulatory.h	…
request_sock.h	inet: clear num_timeout reqsk_alloc()	2019-06-19 17:46:57 -04:00
rose.h	…
route.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-27 21:06:39 -07:00
rsi_91x.h	…
rtnetlink.h	…
rtnh.h	…
sch_generic.h	net: flow_offload: add flow_block structure and use it	2019-07-19 21:27:45 -07:00
scm.h	…
secure_seq.h	…
seg6.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
seg6_hmac.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
seg6_local.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
slhc_vj.h	…
smc.h	…
snmp.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sock.h	coallocate socket_wq with socket itself	2019-07-08 19:25:19 -07:00
sock_reuseport.h	bpf: net: Add SO_DETACH_REUSEPORT_BPF	2019-06-15 01:21:19 +02:00
stp.h	…
strparser.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
switchdev.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
tcp.h	tcp: be more careful in tcp_fragment()	2019-07-21 20:41:24 -07:00
tcp_states.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
timewait_sock.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
tipc.h	…
tls.h	net/tls: don't clear TX resync flag on error	2019-07-08 20:21:09 -07:00
transp_v6.h	…
tso.h	…
tun_proto.h	…
udp.h	SPDX update for 5.2-rc3, round 1	2019-05-31 08:34:32 -07:00
udp_tunnel.h	…
udplite.h	…
vsock_addr.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 321	2019-06-05 17:37:05 +02:00
vxlan.h	vxlan: Use FDB_HASH_SIZE hash_locks to reduce contention	2019-06-06 11:08:55 -07:00
wext.h	…
wimax.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 268	2019-06-05 17:30:29 +02:00
x25.h	…
x25device.h	…
xdp.h	xdp: page_pool related fix to cpumap	2019-06-19 11:23:13 -04:00
xdp_priv.h	xdp: add tracepoints for XDP mem	2019-06-19 11:23:13 -04:00
xdp_sock.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-07-08 19:48:57 -07:00
xfrm.h	xfrm: remove get_mtu indirection from xfrm_type	2019-07-01 06:16:40 +02:00