Li Zhong 948e922fc4 scsi: core: map PQ=1, PDT=other values to SCSI_SCAN_TARGET_PRESENT ... commit 84961f28e9 ("[SCSI] Don't add scsi_device for devices that return PQ=1, PDT=0x1f") returns SCSI_SCAN_TARGET_PRESENT if inquiry returns PQ=1, and PDT = 0x1f. However, from the scsi spec, it seemed setting PQ=1, and PDT to the type it is capable to support, can also mean the device is not connected. E.g. we see an IBM/2145 returns PQ=1 and PDT=0 for a non-mapped lun (details attached at the end). This patch changes the check condition a bit, so the check don't require PTD to be 0x1f when PQ=1. $ echo 0 0 1 > /sys/class/scsi_host/host1/scan [ 2483.722186] scsi 1:0:0:1: scsi scan: INQUIRY pass 1 length 36 [ 2483.725687] scsi 1:0:0:1: scsi scan: INQUIRY successful with code 0x0 [ 2483.729171] scsi 1:0:0:1: scsi scan: INQUIRY pass 2 length 109 [ 2483.732481] scsi 1:0:0:1: scsi scan: INQUIRY successful with code 0x0 [ 2483.735911] scsi 1:0:0:1: Direct-Access IBM 2145 0000 PQ: 1 ANSI: 6 [ 2483.741282] scsi 1:0:0:1: Attached scsi generic sg2 type 0 $ tail /proc/scsi/scsi Attached devices: Host: scsi1 Channel: 00 Id: 00 Lun: 00 Vendor: IBM Model: 2145 Rev: 0000 Type: Direct-Access ANSI SCSI revision: 06 Host: scsi0 Channel: 00 Id: 00 Lun: 00 Vendor: IBM Model: 2145 Rev: 0000 Type: Direct-Access ANSI SCSI revision: 06 Host: scsi1 Channel: 00 Id: 00 Lun: 01 Vendor: IBM Model: 2145 Rev: 0000 Type: Direct-Access ANSI SCSI revision: 06 $ lsscsi [0:0:0:0] disk IBM 2145 0000 /dev/sdb [1:0:0:0] disk IBM 2145 0000 /dev/sda [1:0:0:1] disk IBM 2145 0000 - Signed-off-by: Li Zhong <lizhongfs@gmail.com> Reviewed-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>		2019-04-15 22:25:00 -04:00
..
accessibility	…
acpi	device-dax for 5.1	2019-03-16 13:05:32 -07:00
amba	ARM: 8836/1: drivers: amba: Update component matching to use the CoreSight UCI values.	2019-02-26 11:23:49 +00:00
android	…
ata	SCSI misc on 20190306	2019-03-09 16:53:47 -08:00
atm	…
auxdisplay	…
base	device-dax for 5.1	2019-03-16 13:05:32 -07:00
bcma	…
block	for-5.1/block-post-20190315	2019-03-16 12:36:39 -07:00
bluetooth	Bluetooth: mediatek: add support for MediaTek MT7663U and MT7668U UART devices	2019-03-02 19:51:23 +01:00
bus	ARM: SoC driver updates for 5.1	2019-03-06 09:41:12 -08:00
cdrom	…
char	Merge branch 'next-tpm' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security	2019-03-10 17:37:29 -07:00
clk	We have a fairly balanced mix of clk driver updates and clk framework	2019-03-14 08:46:17 -07:00
clocksource	ARM: some cleanups, direct physical timer assignment, cache sanitization	2019-03-15 15:00:28 -07:00
connector	connector: fix unsafe usage of ->real_parent	2019-03-08 15:06:38 -08:00
cpufreq	cpufreq: intel_pstate: Fix up iowait_boost computation	2019-03-12 09:47:30 +01:00
cpuidle	cpuidle: governor: Add new governors to cpuidle_governors again	2019-03-12 23:46:55 +01:00
crypto	Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6	2019-03-13 09:51:17 -07:00
dax	device-dax for 5.1	2019-03-16 13:05:32 -07:00
dca	…
devfreq	…
dio	…
dma	dmaengine updates for v5.1-rc1	2019-03-14 09:11:54 -07:00
dma-buf	…
edac	Merge branch 'ras-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2019-03-08 09:11:39 -08:00
eisa	…
extcon	…
firewire	…
firmware	memblock: drop memblock_alloc_*_nopanic() variants	2019-03-12 10:04:02 -07:00
fmc	…
fpga	…
fsi	…
gnss	…
gpio	pci-v5.1-changes	2019-03-09 14:57:08 -08:00
gpu	drm i915, amdgpu, qxl and etnaviv fixes	2019-03-15 13:58:35 -07:00
hid	Merge branch 'for-5.1/wacom' into for-linus	2019-03-05 15:43:05 +01:00
hsi	…
hv	Char/Misc driver patches for 5.1-rc1	2019-03-06 14:18:59 -08:00
hwmon	hwmon: (ad7418) Add device tree probing	2019-02-25 09:06:00 -08:00
hwspinlock	…
hwtracing	ARM updates for 5.1-rc1	2019-03-15 14:37:46 -07:00
i2c	i2c: i2c-designware-platdrv: Always use a dynamic adapter number	2019-03-13 18:07:10 +01:00
i3c	- Add a /* fall-through */ comment in the dw-i3c-master driver	2019-03-04 19:05:02 -08:00
ide	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/ide	2019-03-11 09:34:00 -07:00
idle	…
iio	- New Drivers	2019-03-08 10:02:58 -08:00
infiniband	XArray updates for 5.1-rc1	2019-03-11 20:06:18 -07:00
input	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2019-03-11 10:57:11 -07:00
interconnect	…
iommu	IOMMU Fix for Linux v5.1-rc1	2019-03-15 14:41:30 -07:00
ipack	…
irqchip	arm64 updates for 5.1:	2019-03-10 10:17:23 -07:00
isdn	isdn: hfcpci: fix potential NULL pointer dereference	2019-03-12 14:36:02 -07:00
leds	platform-drivers-x86 for v5.1-1	2019-03-10 13:16:37 -07:00
lightnvm	pblk: fix max_io calculation	2019-03-07 08:59:26 -07:00
macintosh	treewide: add checks for the return value of memblock_alloc*()	2019-03-12 10:04:02 -07:00
mailbox	mailbox: imx: keep MU irq working during suspend/resume	2019-03-11 02:51:43 -05:00
mcb	…
md	for-5.1/block-post-20190315	2019-03-16 12:36:39 -07:00
media	DMA mapping updates for 5.1	2019-03-10 11:54:48 -07:00
memory	…
memstick	…
message	scsi: mptscsih: Mark expected switch fall-throughs	2019-04-03 23:45:59 -04:00
mfd	DMA mapping updates for 5.1	2019-03-10 11:54:48 -07:00
misc	5.1 Merge Window Pull Request	2019-03-09 15:53:03 -08:00
mmc	for-5.1/block-20190302	2019-03-08 14:12:17 -08:00
mtd	This pull request contains updates for both UBI and UBIFS:	2019-03-13 09:34:35 -07:00
mux	…
net	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-03-14 09:28:12 -07:00
nfc	…
ntb	Fixes for switchtec debugability and mapping table entries, NTB	2019-03-15 14:32:59 -07:00
nubus	…
nvdimm	device-dax for 5.1	2019-03-16 13:05:32 -07:00
nvme	scsi: scsi_transport_fc: nvme: display FC-NVMe port roles	2019-04-12 20:09:34 -04:00
nvmem	Char/Misc driver patches for 5.1-rc1	2019-03-06 14:18:59 -08:00
of	of: fix kmemleak crash caused by imbalance in early memory reservation	2019-03-12 10:04:02 -07:00
opp	PM / OPP: Update performance state when freq == old_freq	2019-03-12 09:45:56 +01:00
oprofile	…
parisc	DMA mapping updates for 5.1	2019-03-10 11:54:48 -07:00
parport	…
pci	IOMMU Updates for Linux v5.1	2019-03-10 12:29:52 -07:00
pcmcia	…
perf	arm64 updates for 5.1:	2019-03-10 10:17:23 -07:00
phy	scsi: phy: mediatek: Add UFS M-PHY driver	2019-03-19 16:56:21 -04:00
pinctrl	This is the bulk of pin control changes for the v5.1 kernel cycle.	2019-03-11 11:12:50 -07:00
platform	chrome platform changes for v5.1	2019-03-12 09:46:32 -07:00
pnp	ACPI/ACPICA: Trivial: fix spelling mistakes and fix whitespace formatting	2019-02-24 21:12:01 +01:00
power	…
powercap	…
pps	…
ps3	…
ptp	Merge branch 'timers-2038-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2019-03-05 14:08:26 -08:00
pwm	pwm: atmel: Remove useless symbolic definitions	2019-03-04 12:52:49 +01:00
rapidio	rapidio/mport_cdev: mark expected switch fall-through	2019-03-07 18:32:02 -08:00
ras	…
regulator	regulator: mc13xxx: Constify regulator_ops variables	2019-03-04 00:01:08 +00:00
remoteproc	remoteproc updates for v5.1	2019-03-14 09:00:06 -07:00
reset	…
rpmsg	…
rtc	chrome platform changes for v5.1	2019-03-12 09:46:32 -07:00
s390	scsi: zfcp: reduce flood of fcrscn1 trace records on multi-element RSCN	2019-03-27 21:26:12 -04:00
sbus	…
scsi	scsi: core: map PQ=1, PDT=other values to SCSI_SCAN_TARGET_PRESENT	2019-04-15 22:25:00 -04:00
sfi	…
sh	…
siox	…
slimbus	…
sn	…
soc	ARM: SoC driver updates for 5.1	2019-03-06 09:41:12 -08:00
soundwire	…
spi	pci-v5.1-changes	2019-03-09 14:57:08 -08:00
spmi	…
ssb	…
staging	media updates for v5.1-rc1	2019-03-09 14:45:54 -08:00
target	scsi: target/iscsi: Make sure PDU processing continues if parsing a command fails	2019-04-12 20:20:06 -04:00
tc	…
tee	ARM: SoC driver updates for 5.1	2019-03-06 09:41:12 -08:00
thermal	Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal	2019-03-08 09:52:41 -08:00
thunderbolt	…
tty	dmaengine updates for v5.1-rc1	2019-03-14 09:11:54 -07:00
uio	…
usb	memblock: drop memblock_alloc_*_nopanic() variants	2019-03-12 10:04:02 -07:00
uwb	…
vfio	powerpc updates for 5.1	2019-03-07 12:56:26 -08:00
vhost	virtio: fixes, cleanups	2019-03-10 12:47:57 -07:00
video	fbdev changes for v5.1:	2019-03-15 14:22:59 -07:00
virt	virt: vbox: Mark expected switch fall-through	2019-02-27 16:00:20 +01:00
virtio	virtio: hint if callbacks surprisingly might sleep	2019-03-06 11:19:57 -05:00
visorbus	…
vlynq	…
vme	…
w1	…
watchdog	linux-watchdog 5.1-rc1 tag	2019-03-11 11:22:15 -07:00
xen	xen/balloon: Fix mapping PG_offline pages to user space	2019-03-15 15:35:35 +01:00
zorro	…
Kconfig	…
Makefile	IOMMU Updates for Linux v5.1	2019-03-10 12:29:52 -07:00