Huang Ying 093b995e3b mm, swap: Remove WARN_ON_ONCE() in free_swap_slot() ... Before commit 452b94b8c8 ("mm/swap: don't BUG_ON() due to uninitialized swap slot cache"), the following bug is reported, ------------[ cut here ]------------ kernel BUG at mm/swap_slots.c:270! invalid opcode: 0000 [#1] SMP CPU: 5 PID: 1745 Comm: (sd-pam) Not tainted 4.11.0-rc1-00243-g24c534bb161b #1 Hardware name: System manufacturer System Product Name/Z170-K, BIOS 1803 05/06/2016 RIP: 0010:free_swap_slot+0xba/0xd0 Call Trace: swap_free+0x36/0x40 do_swap_page+0x360/0x6d0 __handle_mm_fault+0x880/0x1080 handle_mm_fault+0xd0/0x240 __do_page_fault+0x232/0x4d0 do_page_fault+0x20/0x70 page_fault+0x22/0x30 ---[ end trace aefc9ede53e0ab21 ]--- This is raised by the BUG_ON(!swap_slot_cache_initialized) in free_swap_slot(). This is incorrect, because even if the swap slots cache fails to be initialized, the swap should operate properly without the swap slots cache. And the use_swap_slot_cache check later in the function will protect the uninitialized swap slots cache case. In commit 452b94b8c8, the BUG_ON() is replaced by WARN_ON_ONCE(). In the patch, the WARN_ON_ONCE() is removed too. Reported-by: Linus Torvalds <torvalds@linux-foundation.org> Acked-by: Tim Chen <tim.c.chen@linux.intel.com> Cc: Michal Hocko <mhocko@suse.com> Signed-off-by: "Huang, Ying" <ying.huang@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2017-03-21 14:13:19 -07:00
..
kasan	Merge branch 'prep-for-5level'	2017-03-10 08:59:07 -08:00
Kconfig	…
Kconfig.debug	mm: add arch-independent testcases for RODATA	2017-02-27 18:43:48 -08:00
Makefile	mm: add arch-independent testcases for RODATA	2017-02-27 18:43:48 -08:00
backing-dev.c	bdi: Fix use-after-free in wb_congested_put()	2017-03-08 10:55:17 -07:00
balloon_compaction.c	…
bootmem.c	…
cleancache.c	…
cma.c	…
cma.h	…
cma_debug.c	…
compaction.c	sched/headers: Prepare to move signal wakeup & sigpending methods from <linux/sched.h> into <linux/sched/signal.h>	2017-03-02 08:42:32 +01:00
debug.c	…
debug_page_ref.c	…
dmapool.c	lib/vsprintf.c: remove %Z support	2017-02-27 18:43:47 -08:00
early_ioremap.c	…
fadvise.c	…
failslab.c	…
filemap.c	sched/headers: Prepare for new header dependencies before moving code to <linux/sched/signal.h>	2017-03-02 08:42:29 +01:00
frame_vector.c	…
frontswap.c	…
gup.c	mm, gup: fix typo in gup_p4d_range()	2017-03-13 08:58:09 -07:00
highmem.c	…
huge_memory.c	Merge branch 'prep-for-5level'	2017-03-10 08:59:07 -08:00
hugetlb.c	mm: convert generic code to 5-level paging	2017-03-09 11:48:47 -08:00
hugetlb_cgroup.c	…
hwpoison-inject.c	…
init-mm.c	…
internal.h	…
interval_tree.c	…
khugepaged.c	sched/headers: Prepare for new header dependencies before moving code to <linux/sched/coredump.h>	2017-03-02 08:42:28 +01:00
kmemcheck.c	…
kmemleak-test.c	…
kmemleak.c	sched/headers: Prepare for new header dependencies before moving code to <linux/sched/task_stack.h>	2017-03-02 08:42:36 +01:00
ksm.c	sched/headers: Prepare for new header dependencies before moving code to <linux/sched/coredump.h>	2017-03-02 08:42:28 +01:00
list_lru.c	…
maccess.c	…
madvise.c	userfaultfd: non-cooperative: userfaultfd_remove revalidate vma in MADV_DONTNEED	2017-03-09 17:01:10 -08:00
memblock.c	mm/memblock.c: fix memblock_next_valid_pfn()	2017-03-09 17:01:10 -08:00
memcontrol.c	mm: do not call mem_cgroup_free() from within mem_cgroup_alloc()	2017-03-09 17:01:10 -08:00
memory-failure.c	sched/headers: Prepare for new header dependencies before moving code to <linux/sched/task.h>	2017-03-02 08:42:35 +01:00
memory.c	mm: introduce __p4d_alloc()	2017-03-09 11:48:48 -08:00
memory_hotplug.c	mm: add private lock to serialize memory hotplug operations	2017-03-16 16:56:18 -07:00
mempolicy.c	sched/headers: Prepare to move the task_lock()/unlock() APIs to <linux/sched/task.h>	2017-03-02 08:42:38 +01:00
mempool.c	…
memtest.c	…
migrate.c	sched/headers: Prepare for new header dependencies before moving code to <linux/sched/mm.h>	2017-03-02 08:42:28 +01:00
mincore.c	…
mlock.c	Merge branch 'prep-for-5level'	2017-03-10 08:59:07 -08:00
mm_init.c	…
mmap.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-03-02 15:20:00 -08:00
mmu_context.c	sched/headers: Prepare to move the task_lock()/unlock() APIs to <linux/sched/task.h>	2017-03-02 08:42:38 +01:00
mmu_notifier.c	sched/headers: Prepare for new header dependencies before moving code to <linux/sched/mm.h>	2017-03-02 08:42:28 +01:00
mmzone.c	…
mprotect.c	mm: convert generic code to 5-level paging	2017-03-09 11:48:47 -08:00
mremap.c	mm: convert generic code to 5-level paging	2017-03-09 11:48:47 -08:00
msync.c	…
nobootmem.c	…
nommu.c	Merge branch 'WIP.sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-03-03 10:16:38 -08:00
oom_kill.c	sched/headers: Prepare for new header dependencies before moving code to <linux/sched/task.h>	2017-03-02 08:42:35 +01:00
page-writeback.c	sched/headers: Prepare for the reduction of <linux/sched.h>'s signal API dependency	2017-03-02 08:42:37 +01:00
page_alloc.c	mm, page_alloc: Add missing check for memory holes	2017-03-08 11:10:10 -08:00
page_counter.c	…
page_ext.c	…
page_idle.c	…
page_io.c	…
page_isolation.c	…
page_owner.c	…
page_poison.c	…
page_vma_mapped.c	mm: convert generic code to 5-level paging	2017-03-09 11:48:47 -08:00
pagewalk.c	mm: convert generic code to 5-level paging	2017-03-09 11:48:47 -08:00
percpu-km.c	…
percpu-vm.c	percpu: remove unused chunk_alloc parameter from pcpu_get_pages()	2017-03-06 15:56:55 -05:00
percpu.c	percpu: acquire pcpu_lock when updating pcpu_nr_empty_pop_pages	2017-03-06 15:55:39 -05:00
pgtable-generic.c	mm: convert generic code to 5-level paging	2017-03-09 11:48:47 -08:00
process_vm_access.c	sched/headers: Prepare for new header dependencies before moving code to <linux/sched/mm.h>	2017-03-02 08:42:28 +01:00
quicklist.c	…
readahead.c	…
rmap.c	Merge branch 'prep-for-5level'	2017-03-10 08:59:07 -08:00
rodata_test.c	mm: add arch-independent testcases for RODATA	2017-02-27 18:43:48 -08:00
shmem.c	Merge branch 'rebased-statx' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-03-03 11:38:56 -08:00
slab.c	sched/headers: Prepare to move kstack_end() from <linux/sched.h> to <linux/sched/task_stack.h>	2017-03-02 08:42:39 +01:00
slab.h	…
slab_common.c	kasan: drain quarantine of memcg slab objects	2017-02-24 17:46:56 -08:00
slob.c	…
slub.c	…
sparse-vmemmap.c	mm: convert generic code to 5-level paging	2017-03-09 11:48:47 -08:00
sparse.c	…
swap.c	…
swap_cgroup.c	…
swap_slots.c	mm, swap: Remove WARN_ON_ONCE() in free_swap_slot()	2017-03-21 14:13:19 -07:00
swap_state.c	…
swapfile.c	mm: convert generic code to 5-level paging	2017-03-09 11:48:47 -08:00
truncate.c	fs: add i_blocksize()	2017-02-27 18:43:46 -08:00
usercopy.c	sched/headers: Prepare for new header dependencies before moving code to <linux/sched/task.h>	2017-03-02 08:42:35 +01:00
userfaultfd.c	mm: convert generic code to 5-level paging	2017-03-09 11:48:47 -08:00
util.c	sched/headers: Prepare for new header dependencies before moving code to <linux/sched/task_stack.h>	2017-03-02 08:42:36 +01:00
vmacache.c	sched/headers: Prepare to move 'init_task' and 'init_thread_union' from <linux/sched.h> to <linux/sched/task.h>	2017-03-02 08:42:38 +01:00
vmalloc.c	mm: don't warn when vmalloc() fails due to a fatal signal	2017-03-16 16:56:18 -07:00
vmpressure.c	…
vmscan.c	sched/headers: Prepare to move the memalloc_noio_*() APIs to <linux/sched/mm.h>	2017-03-02 08:42:33 +01:00
vmstat.c	mm/vmstats: add thp_split_pud event for clarity	2017-03-09 17:01:10 -08:00
workingset.c	Merge branch 'idr-4.11' of git://git.infradead.org/users/willy/linux-dax	2017-02-28 20:29:41 -08:00
z3fold.c	z3fold: fix spinlock unlocking in page reclaim	2017-03-16 16:56:18 -07:00
zbud.c	…
zpool.c	…
zsmalloc.c	sched/headers: Prepare to remove the <linux/magic.h> include from <linux/sched/task_stack.h>	2017-03-02 08:42:40 +01:00
zswap.c	zswap: don't param_set_charp while holding spinlock	2017-02-27 18:43:45 -08:00