Qu Wenruo 00c6bb4cea btrfs: verify the tranisd of the to-be-written dirty extent buffer ... commit 3777369ff1 upstream. [BUG] There is a bug report that a bitflip in the transid part of an extent buffer makes btrfs to reject certain tree blocks: BTRFS error (device dm-0): parent transid verify failed on 1382301696 wanted 262166 found 22 [CAUSE] Note the failed transid check, hex(262166) = 0x40016, while hex(22) = 0x16. It's an obvious bitflip. Furthermore, the reporter also confirmed the bitflip is from the hardware, so it's a real hardware caused bitflip, and such problem can not be detected by the existing tree-checker framework. As tree-checker can only verify the content inside one tree block, while generation of a tree block can only be verified against its parent. So such problem remain undetected. [FIX] Although tree-checker can not verify it at write-time, we still have a quick (but not the most accurate) way to catch such obvious corruption. Function csum_one_extent_buffer() is called before we submit metadata write. Thus it means, all the extent buffer passed in should be dirty tree blocks, and should be newer than last committed transaction. Using that we can catch the above bitflip. Although it's not a perfect solution, as if the corrupted generation is higher than the correct value, we have no way to catch it at all. Reported-by: Christoph Anton Mitterer <calestyo@scientia.org> Link: https://lore.kernel.org/linux-btrfs/2dfcbc130c55cc6fd067b93752e90bd2b079baca.camel@scientia.org/ CC: stable@vger.kernel.org # 5.15+ Signed-off-by: Qu Wenruo <wqu@sus,ree.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-04-08 14:23:02 +02:00
..
tests	btrfs: remove ignore_offset argument from btrfs_find_all_roots()	2021-08-23 13:19:01 +02:00
Kconfig	btrfs: disable build on platforms having page size 256K	2021-06-22 14:11:57 +02:00
Makefile	btrfs: initial fsverity support	2021-08-23 13:19:09 +02:00
acl.c	overlayfs update for 5.15	2021-09-02 09:21:27 -07:00
async-thread.c	btrfs: fix memory ordering between normal and ordered work functions	2021-11-25 09:48:46 +01:00
async-thread.h	Btrfs: fix crash during unmount due to race with delayed inode workers	2020-03-23 17:01:51 +01:00
backref.c	btrfs: remove BUG_ON(!eie) in find_parent_nodes	2022-01-27 11:04:52 +01:00
backref.h	btrfs: remove ignore_offset argument from btrfs_find_all_roots()	2021-08-23 13:19:01 +02:00
block-group.c	btrfs: zoned: mark relocation as writing	2022-04-08 14:23:02 +02:00
block-group.h	btrfs: rework chunk allocation to avoid exhaustion of the system chunk array	2021-07-07 17:42:41 +02:00
block-rsv.c	btrfs: introduce mount option rescue=ignorebadroots	2020-12-08 15:53:41 +01:00
block-rsv.h	btrfs: Remove __ prefix from btrfs_block_rsv_release	2020-03-23 17:01:55 +01:00
btrfs_inode.h	btrfs: initial fsverity support	2021-08-23 13:19:09 +02:00
check-integrity.c	btrfs: check-integrity: drop kmap/kunmap for block pages	2021-08-23 13:19:00 +02:00
check-integrity.h	btrfs: remove btrfsic_submit_bh()	2020-03-23 17:01:39 +01:00
compression.c	Revert "btrfs: compression: drop kmap/kunmap from generic helpers"	2021-10-27 10:39:03 +02:00
compression.h	btrfs: rework btrfs_decompress_buf2page()	2021-08-23 13:19:04 +02:00
ctree.c	btrfs: make send work with concurrent block group relocation	2022-03-16 14:23:46 +01:00
ctree.h	btrfs: skip reserved bytes warning on unmount after log cleanup failure	2022-03-23 09:16:43 +01:00
delalloc-space.c	btrfs: free exchange changeset on failures	2021-12-14 10:57:13 +01:00
delalloc-space.h	btrfs: make btrfs_delalloc_reserve_space take btrfs_inode	2020-07-27 12:55:36 +02:00
delayed-inode.c	btrfs: add ro compat flags to inodes	2021-08-23 13:19:09 +02:00
delayed-inode.h	btrfs: make btrfs_delayed_update_inode take btrfs_inode	2020-12-08 15:54:10 +01:00
delayed-ref.c	btrfs: fix lock inversion problem when doing qgroup extent tracing	2021-07-22 15:50:07 +02:00
delayed-ref.h	btrfs: only let one thread pre-flush delayed refs in commit	2021-02-08 22:58:56 +01:00
dev-replace.c	btrfs: zoned: cache reported zone during mount	2022-02-23 12:03:02 +01:00
dev-replace.h	btrfs: zoned: mark block groups to copy for device-replace	2021-02-09 02:46:07 +01:00
dir-item.c	btrfs: unify lookup return value when dir entry is missing	2021-10-07 22:06:32 +02:00
discard.c	btrfs: fix typos in comments	2021-06-22 14:11:57 +02:00
discard.h	btrfs: cleanup btrfs_discard_update_discardable usage	2020-12-08 15:54:02 +01:00
disk-io.c	btrfs: verify the tranisd of the to-be-written dirty extent buffer	2022-04-08 14:23:02 +02:00
disk-io.h	btrfs: split alloc_log_tree()	2021-02-09 02:46:07 +01:00
export.c	btrfs: locking: rip out path->leave_spinning	2020-12-08 15:54:02 +01:00
export.h	btrfs: export helpers for subvolume name/id resolution	2020-03-23 17:01:42 +01:00
extent-io-tree.h	btrfs: use fixed width int type for extent_state::state	2020-12-08 15:54:13 +01:00
extent-tree.c	btrfs: do not start relocation until in progress drops are done	2022-03-08 19:12:54 +01:00
extent_io.c	btrfs: do not WARN_ON() if we have PageError set	2022-03-08 19:12:54 +01:00
extent_io.h	btrfs: fix argument type of btrfs_bio_clone_partial()	2021-08-23 13:19:08 +02:00
extent_map.c	btrfs: fix parameter description of btrfs_add_extent_mapping	2021-02-08 22:58:53 +01:00
extent_map.h	…
file-item.c	btrfs: replace BUG_ON() in btrfs_csum_one_bio() with proper error handling	2021-09-17 19:29:38 +02:00
file.c	btrfs: fix abort logic in btrfs_replace_file_extents	2021-10-07 22:08:06 +02:00
free-space-cache.c	btrfs: zoned: fix block group alloc_offset calculation	2021-08-23 13:19:11 +02:00
free-space-cache.h	btrfs: zoned: track unusable bytes for zones	2021-02-09 02:46:03 +01:00
free-space-tree.c	btrfs: fix possible free space tree corruption with online conversion	2021-01-25 18:44:37 +01:00
free-space-tree.h	…
inode-item.c	btrfs: locking: rip out path->leave_spinning	2020-12-08 15:54:02 +01:00
inode.c	btrfs: fix ENOSPC failure when attempting direct IO write into NOCOW range	2022-03-08 19:12:46 +01:00
ioctl.c	btrfs: fix use-after-free after failure to create a snapshot	2022-02-08 18:34:04 +01:00
locking.c	btrfs: fix typos in comments	2021-06-22 14:11:57 +02:00
locking.h	btrfs: remove the recurse parameter from __btrfs_tree_read_lock	2020-12-08 15:54:09 +01:00
lzo.c	btrfs: prevent copying too big compressed lzo segment	2022-03-02 11:48:07 +01:00
misc.h	btrfs: use correct header for div_u64 in misc.h	2021-09-07 14:29:50 +02:00
ordered-data.c	btrfs: zoned: fix double counting of split ordered extent	2021-09-07 14:30:41 +02:00
ordered-data.h	btrfs: remove uptodate parameter from btrfs_dec_test_first_ordered_pending	2021-08-23 13:19:02 +02:00
orphan.c	…
print-tree.c	btrfs: print the actual offset in btrfs_root_name	2021-01-07 17:25:05 +01:00
print-tree.h	btrfs: print the actual offset in btrfs_root_name	2021-01-07 17:25:05 +01:00
props.c	btrfs: props: change how empty value is interpreted	2021-06-22 14:11:58 +02:00
props.h	…
qgroup.c	btrfs: qgroup: fix deadlock between rescan worker and remove qgroup	2022-03-08 19:12:54 +01:00
qgroup.h	btrfs: fix lock inversion problem when doing qgroup extent tracing	2021-07-22 15:50:07 +02:00
raid56.c	btrfs: constify and cleanup variables in comparators	2021-08-23 13:19:03 +02:00
raid56.h	…
rcu-string.h	btrfs: rcu-string: Replace zero-length array with flexible-array member	2020-03-23 17:01:53 +01:00
reada.c	btrfs: subpage: make readahead work properly	2021-03-16 11:06:21 +01:00
ref-verify.c	btrfs: stop doing GFP_KERNEL memory allocations in the ref verify tool	2021-08-23 13:19:00 +02:00
ref-verify.h	…
reflink.c	btrfs: reflink: initialize return value to 0 in btrfs_extent_same()	2021-11-18 19:16:20 +01:00
reflink.h	Btrfs: move all reflink implementation code into its own file	2020-03-23 17:01:54 +01:00
relocation.c	btrfs: make send work with concurrent block group relocation	2022-03-16 14:23:46 +01:00
root-tree.c	btrfs: do not start relocation until in progress drops are done	2022-03-08 19:12:54 +01:00
scrub.c	btrfs: make 1-bit bit-fields of scrub_page unsigned int	2021-11-25 09:48:37 +01:00
send.c	btrfs: make send work with concurrent block group relocation	2022-03-16 14:23:46 +01:00
send.h	btrfs: send: avoid copying file data	2020-10-07 12:13:17 +02:00
space-info.c	btrfs: extend locking to all space_info members accesses	2022-04-08 14:23:02 +02:00
space-info.h	btrfs: rip out btrfs_space_info::total_bytes_pinned	2021-06-22 14:55:25 +02:00
struct-funcs.c	btrfs: add special case to setget helpers for 64k pages	2021-08-23 13:18:58 +02:00
subpage.c	btrfs: subpage: fix a potential use-after-free in writeback helper	2021-08-23 13:19:05 +02:00
subpage.h	btrfs: subpage: fix writeback which does not have ordered extent	2021-08-23 13:19:04 +02:00
super.c	btrfs: use latest_dev in btrfs_show_devname	2021-12-22 09:32:37 +01:00
sysfs.c	btrfs: sysfs: document structures and their associated files	2021-08-23 13:19:12 +02:00
sysfs.h	btrfs: split and refactor btrfs_sysfs_remove_devices_dir	2020-10-07 12:12:21 +02:00
transaction.c	btrfs: make send work with concurrent block group relocation	2022-03-16 14:23:46 +01:00
transaction.h	btrfs: do not start relocation until in progress drops are done	2022-03-08 19:12:54 +01:00
tree-checker.c	btrfs: tree-checker: check item_size for dev_item	2022-03-02 11:47:48 +01:00
tree-checker.h	…
tree-defrag.c	btrfs: locking: remove all the blocking helpers	2020-12-08 15:54:01 +01:00
tree-log.c	btrfs: skip reserved bytes warning on unmount after log cleanup failure	2022-03-23 09:16:43 +01:00
tree-log.h	btrfs: make fast fsyncs wait only for writeback	2020-10-07 12:06:56 +02:00
tree-mod-log.c	btrfs: fix race when picking most recent mod log operation for an old root	2021-04-20 19:27:17 +02:00
tree-mod-log.h	btrfs: add and use helper to get lowest sequence number for the tree mod log	2021-04-19 17:25:17 +02:00
ulist.c	…
ulist.h	…
uuid-tree.c	btrfs: remove unnecessary casts in printk	2020-12-08 15:53:52 +01:00
verity.c	btrfs: fix transaction handle leak after verity rollback failure	2021-09-17 19:29:41 +02:00
volumes.c	btrfs: zoned: mark relocation as writing	2022-04-08 14:23:02 +02:00
volumes.h	btrfs: convert latest_bdev type to btrfs_device and rename	2021-12-22 09:32:37 +01:00
xattr.c	for-5.12-rc1-tag	2021-03-05 12:21:14 -08:00
xattr.h	…
zlib.c	Revert "btrfs: compression: drop kmap/kunmap from zlib"	2021-10-29 13:03:05 +02:00
zoned.c	btrfs: zoned: cache reported zone during mount	2022-02-23 12:03:02 +01:00
zoned.h	btrfs: zoned: cache reported zone during mount	2022-02-23 12:03:02 +01:00
zstd.c	Revert "btrfs: compression: drop kmap/kunmap from zstd"	2021-10-29 13:02:50 +02:00