Yuchung Cheng 0eb96bf754 tcp: fix tcp_fastretrans_alert warning ... This patch fixes the cause of an WARNING indicatng TCP has pending retransmission in Open state in tcp_fastretrans_alert(). The root cause is a bad interaction between path mtu probing, if enabled, and the RACK loss detection. Upong receiving a SACK above the sequence of the MTU probing packet, RACK could mark the probe packet lost in tcp_fastretrans_alert(), prior to calling tcp_simple_retransmit(). tcp_simple_retransmit() only enters Loss state if it newly marks the probe packet lost. If the probe packet is already identified as lost by RACK, the sender remains in Open state with some packets marked lost and retransmitted. Then the next SACK would trigger the warning. The likely scenario is that the probe packet was lost due to its size or network congestion. The actual impact of this warning is small by potentially entering fast recovery an ACK later. The simple fix is always entering recovery (Loss) state if some packet is marked lost during path MTU probing. Fixes: a0370b3f3f ("tcp: enable RACK loss detection to trigger recovery") Reported-by: Oleksandr Natalenko <oleksandr@natalenko.name> Reported-by: Alexei Starovoitov <alexei.starovoitov@gmail.com> Reported-by: Roman Gushchin <guro@fb.com> Signed-off-by: Yuchung Cheng <ycheng@google.com> Reviewed-by: Eric Dumazet <edumazet@google.com> Acked-by: Neal Cardwell <ncardwell@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2017-11-10 18:09:19 +09:00
..
netfilter	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-11-03 09:09:21 -07:00
Kconfig	ip: update policy routing config help	2017-10-12 22:57:11 -07:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
af_inet.c	net: Add comment that early_demux can change via sysctl	2017-08-28 15:17:29 -07:00
ah4.c	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next	2017-06-23 14:17:31 -04:00
arp.c	neigh: increase queue_len_bytes to match wmem_default	2017-08-29 16:10:50 -07:00
cipso_ipv4.c	tcp/dccp: fix ireq->opt races	2017-10-21 01:33:19 +01:00
datagram.c	net: Set sk_txhash from a random number	2015-07-29 22:44:04 -07:00
devinet.c	rtnetlink: make rtnl_register accept a flags parameter	2017-08-09 16:57:38 -07:00
esp4.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-09-01 17:42:05 -07:00
esp4_offload.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-09-01 17:42:05 -07:00
fib_frontend.c	rtnetlink: make rtnl_register accept a flags parameter	2017-08-09 16:57:38 -07:00
fib_lookup.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
fib_notifier.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
fib_rules.c	net: fib_rules: Implement notification logic in core	2017-08-03 15:35:59 -07:00
fib_semantics.c	fib: fib_dump_info can no longer use __in_dev_get_rtnl	2017-11-03 14:27:46 +09:00
fib_trie.c	ipv4: do metrics match when looking up and deleting a route	2017-08-23 20:37:10 -07:00
fou.c	gue: fix remcsum when GRO on and CHECKSUM_PARTIAL boundary is outer UDP	2017-08-01 16:09:14 -07:00
gre_demux.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2016-06-30 05:03:36 -04:00
gre_offload.c	gso: fix payload length when gso_size is zero	2017-10-08 10:12:15 -07:00
icmp.c	ip/options: explicitly provide net ns to __ip_options_echo()	2017-08-06 20:51:12 -07:00
igmp.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-08-21 17:06:42 -07:00
inet_connection_sock.c	tcp/dccp: fix other lockdep splats accessing ireq_opt	2017-10-26 17:41:32 +09:00
inet_diag.c	inet_diag: allow protocols to provide additional data	2017-09-01 18:38:09 -07:00
inet_fragment.c	Revert "net: use lib/percpu_counter API for fragmentation mem accounting"	2017-09-03 11:01:05 -07:00
inet_hashtables.c	soreuseport: fix initialization race	2017-10-22 02:03:51 +01:00
inet_timewait_sock.c	net: convert sock.sk_refcnt from atomic_t to refcount_t	2017-07-01 07:39:08 -07:00
inetpeer.c	inetpeer: fix RCU lookup() again	2017-09-28 09:39:34 -07:00
ip_forward.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ip_fragment.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ip_gre.c	ip_gre: erspan device should keep dst	2017-10-01 22:30:32 -07:00
ip_input.c	IPv4: early demux can return an error code	2017-10-01 03:55:47 +01:00
ip_options.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ip_output.c	udp: remove unreachable ufo branches	2017-08-22 14:27:18 -07:00
ip_sockglue.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ip_tunnel.c	ip_tunnel: fix ip tunnel lookup in collect_md mode	2017-09-12 20:45:31 -07:00
ip_tunnel_core.c	net: store port/representator id in metadata_dst	2017-06-25 11:42:01 -04:00
ip_vti.c	vti: fix use after free in vti_tunnel_xmit/vti6_tnl_xmit	2017-09-26 09:58:21 -07:00
ipcomp.c	ipv4: coding style: comparison for equality with NULL	2015-04-03 12:11:15 -04:00
ipconfig.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ipip.c	ipip: only increase err_count for some certain type icmp in ipip_err	2017-10-27 23:43:31 +09:00
ipmr.c	rtnetlink: make rtnl_register accept a flags parameter	2017-08-09 16:57:38 -07:00
netfilter.c	netfilter: use skb_to_full_sk in ip_route_me_harder	2017-02-28 12:49:36 +01:00
ping.c	net: convert sock.sk_refcnt from atomic_t to refcount_t	2017-07-01 07:39:08 -07:00
proc.c	tcp: Revert "tcp: remove header prediction"	2017-08-30 11:20:09 -07:00
protocol.c	net: Add sysctl to toggle early demux for tcp and udp	2017-03-24 13:17:07 -07:00
raw.c	net: ipv4: add second dif to multicast source filter	2017-08-07 11:39:22 -07:00
raw_diag.c	net: ipv6: add second dif to raw socket lookups	2017-08-07 11:39:22 -07:00
route.c	ipv4: Fix traffic triggered IPsec connections.	2017-10-09 09:39:50 -07:00
syncookies.c	tcp/dccp: fix ireq->opt races	2017-10-21 01:33:19 +01:00
sysctl_net_ipv4.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
tcp.c	net: prepare (struct ubuf_info)->refcnt conversion	2017-09-01 20:22:03 -07:00
tcp_bbr.c	tcp_bbr: init pacing rate on first RTT sample	2017-07-15 14:43:29 -07:00
tcp_bic.c	tcp: consolidate congestion control undo functions	2017-08-06 21:25:10 -07:00
tcp_cdg.c	tcp: consolidate congestion control undo functions	2017-08-06 21:25:10 -07:00
tcp_cong.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-09-01 17:42:05 -07:00
tcp_cubic.c	tcp: consolidate congestion control undo functions	2017-08-06 21:25:10 -07:00
tcp_dctcp.c	Revert "dctcp: update cwnd on congestion event"	2016-12-06 11:34:24 -05:00
tcp_diag.c	tcp_diag: report TCP MD5 signing keys and addresses	2017-09-01 18:38:09 -07:00
tcp_fastopen.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
tcp_highspeed.c	tcp: consolidate congestion control undo functions	2017-08-06 21:25:10 -07:00
tcp_htcp.c	tcp: fix cwnd undo in Reno and HTCP congestion controls	2017-08-06 21:25:10 -07:00
tcp_hybla.c	tcp: make undo_cwnd mandatory for congestion modules	2016-11-21 13:20:17 -05:00
tcp_illinois.c	tcp: consolidate congestion control undo functions	2017-08-06 21:25:10 -07:00
tcp_input.c	tcp: fix tcp_fastretrans_alert warning	2017-11-10 18:09:19 +09:00
tcp_ipv4.c	tcp/dccp: fix other lockdep splats accessing ireq_opt	2017-10-26 17:41:32 +09:00
tcp_lp.c	tcp: switch TCP TS option (RFC 7323) to 1ms clock	2017-05-17 16:06:01 -04:00
tcp_metrics.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
tcp_minisocks.c	tcp: Revert "tcp: remove header prediction"	2017-08-30 11:20:09 -07:00
tcp_nv.c	tcp_nv: fix division by zero in tcpnv_acked()	2017-11-02 16:16:27 +09:00
tcp_offload.c	tcp: gso: avoid refcount_t warning from tcp_gso_segment()	2017-11-10 18:07:15 +09:00
tcp_output.c	tcp: do not mangle skb->cb[] in tcp_make_synack()	2017-11-03 14:29:01 +09:00
tcp_probe.c	tcp: remove redundant argument from tcp_rcv_established()	2017-07-24 17:28:12 -07:00
tcp_rate.c	tcp: export do_tcp_sendpages and tcp_rate_check_app_limited functions	2017-06-15 12:12:40 -04:00
tcp_recovery.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
tcp_scalable.c	tcp: consolidate congestion control undo functions	2017-08-06 21:25:10 -07:00
tcp_timer.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-08-09 16:28:45 -07:00
tcp_ulp.c	tcp: ulp: avoid module refcnt leak in tcp_set_ulp	2017-08-14 22:17:05 -07:00
tcp_vegas.c	tcp: make undo_cwnd mandatory for congestion modules	2016-11-21 13:20:17 -05:00
tcp_vegas.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
tcp_veno.c	tcp: consolidate congestion control undo functions	2017-08-06 21:25:10 -07:00
tcp_westwood.c	tcp: Revert "tcp: remove CA_ACK_SLOWPATH"	2017-08-30 11:20:08 -07:00
tcp_yeah.c	tcp: consolidate congestion control undo functions	2017-08-06 21:25:10 -07:00
tunnel4.c	tunnels: correct conditional build of MPLS and IPv6	2016-07-11 13:27:06 -07:00
udp.c	soreuseport: fix initialization race	2017-10-22 02:03:51 +01:00
udp_diag.c	net: ipv6: add second dif to udp socket lookups	2017-08-07 11:39:22 -07:00
udp_impl.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
udp_offload.c	gso: fix payload length when gso_size is zero	2017-10-08 10:12:15 -07:00
udp_tunnel.c	net: add infrastructure to un-offload UDP tunnel port	2017-07-24 13:52:59 -07:00
udplite.c	udplite: call proper backlog handlers	2016-11-24 15:32:14 -05:00
xfrm4_input.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xfrm4_mode_beet.c	networking: make skb_pull & friends return void pointers	2017-06-16 11:48:39 -04:00
xfrm4_mode_transport.c	xfrm: Add encapsulation header offsets while SKB is not encrypted	2017-04-14 10:07:39 +02:00
xfrm4_mode_tunnel.c	xfrm: Add encapsulation header offsets while SKB is not encrypted	2017-04-14 10:07:39 +02:00
xfrm4_output.c	xfrm: Add an IPsec hardware offloading API	2017-04-14 10:06:10 +02:00
xfrm4_policy.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xfrm4_protocol.c	xfrm: input: constify xfrm_input_afinfo	2017-02-09 10:22:17 +01:00
xfrm4_state.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xfrm4_tunnel.c	…