Dave Chinner 4a33821236 xfs: prevent bogus assert when trying to remove non-existent attribute ... If the attribute fork on an inode is in btree format and has multiple levels (i.e node format rather than leaf format), then a lookup failure will trigger an assert failure in xfs_da_path_shift if the flag XFS_DA_OP_OKNOENT is not set. This flag is used to indicate to the directory btree code that not finding an entry is not a fatal error. In the case of doing a lookup for a directory name removal, this is valid as a user cannot insert an arbitrary name to remove from the directory btree. However, in the case of the attribute tree, a user has direct control over the attribute name and can ask for any random name to be removed without any validation. In this case, fsstress is asking for a non-existent user.selinux attribute to be removed, and that is causing xfs_da_path_shift() to fall off the bottom of the tree where it asserts that a lookup failure is allowed. Because the flag is not set, we die a horrible death on a debug enable kernel. Prevent this assert from firing on attribute removes by adding the op_flag XFS_DA_OP_OKNOENT to atribute removal operations. Discovered when testing on a SELinux enabled system by fsstress in test 070 by trying to remove a non-existent user.selinux attribute. Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Alex Elder <aelder@sgi.com>		2011-06-23 22:13:51 -05:00
..
linux-2.6	xfs: make log devices with write back caches work	2011-06-16 10:52:39 -05:00
quota	vmscan: change shrinker API by passing shrink_control struct	2011-05-25 08:39:26 -07:00
support	xfs: kill support/debug.[ch]	2011-03-07 10:09:35 +11:00
Kconfig	…
Makefile	Merge branch 'for-linus' of git://oss.sgi.com/xfs/xfs	2011-03-21 14:24:56 -07:00
xfs.h	…
xfs_acl.h	fs: provide rcu-walk aware permission i_ops	2011-01-07 17:50:29 +11:00
xfs_ag.h	xfs: do not discard alloc btree blocks	2011-05-24 11:17:22 -05:00
xfs_alloc.c	xfs: do not discard alloc btree blocks	2011-05-24 11:17:22 -05:00
xfs_alloc.h	xfs: do not discard alloc btree blocks	2011-05-24 11:17:22 -05:00
xfs_alloc_btree.c	xfs: do not discard alloc btree blocks	2011-05-24 11:17:22 -05:00
xfs_alloc_btree.h	…
xfs_arch.h	…
xfs_attr.c	xfs: prevent bogus assert when trying to remove non-existent attribute	2011-06-23 22:13:51 -05:00
xfs_attr.h	…
xfs_attr_leaf.c	xfs: use KM_NOFS for allocations during attribute list operations	2010-12-23 11:57:37 +11:00
xfs_attr_leaf.h	…
xfs_attr_sf.h	…
xfs_bit.c	…
xfs_bit.h	…
xfs_bmap.c	xfs: correctly decrement the extent buffer index in xfs_bmap_del_extent	2011-05-25 10:48:38 -05:00
xfs_bmap.h	xfs: remove the unused XFS_BMAPI_RSVBLOCKS flag	2011-05-25 10:48:36 -05:00
xfs_bmap_btree.c	…
xfs_bmap_btree.h	…
xfs_btree.c	xfs: connect up buffer reclaim priority hooks	2010-12-02 16:31:13 +11:00
xfs_btree.h	…
xfs_btree_trace.c	…
xfs_btree_trace.h	…
xfs_buf_item.c	Fix common misspellings	2011-03-31 11:26:23 -03:00
xfs_buf_item.h	xfs: use struct list_head for the buf cancel table	2010-12-16 16:05:22 -06:00
xfs_da_btree.c	xfs: Convert remaining cmn_err() callers to new API	2011-03-07 10:08:35 +11:00
xfs_da_btree.h	…
xfs_dfrag.c	xfs: cleanup duplicate initializations	2011-04-28 13:25:29 -05:00
xfs_dfrag.h	…
xfs_dinode.h	…
xfs_dir2.c	xfs: convert xfs_fs_cmn_err to new error logging API	2011-03-07 10:05:35 +11:00
xfs_dir2.h	…
xfs_dir2_block.c	…
xfs_dir2_block.h	…
xfs_dir2_data.c	…
xfs_dir2_data.h	…
xfs_dir2_leaf.c	…
xfs_dir2_leaf.h	…
xfs_dir2_node.c	xfs: Convert remaining cmn_err() callers to new API	2011-03-07 10:08:35 +11:00
xfs_dir2_node.h	…
xfs_dir2_sf.c	…
xfs_dir2_sf.h	…
xfs_error.c	xfs: Convert remaining cmn_err() callers to new API	2011-03-07 10:08:35 +11:00
xfs_error.h	xfs: kill support/debug.[ch]	2011-03-07 10:09:35 +11:00
xfs_extfree_item.c	xfs: fix efi item leak on forced shutdown	2011-01-28 09:01:33 -06:00
xfs_extfree_item.h	xfs: Pull EFI/EFD handling out from under the AIL lock	2010-12-20 11:59:49 +11:00
xfs_filestream.c	…
xfs_filestream.h	…
xfs_fs.h	…
xfs_fsops.c	xfs: convert xfs_fs_cmn_err to new error logging API	2011-03-07 10:05:35 +11:00
xfs_fsops.h	xfs: ensure log covering transactions are synchronous	2011-01-11 20:28:17 -06:00
xfs_ialloc.c	xfs: Convert remaining cmn_err() callers to new API	2011-03-07 10:08:35 +11:00
xfs_ialloc.h	…
xfs_ialloc_btree.c	…
xfs_ialloc_btree.h	…
xfs_iget.c	xfs: reset inode per-lifetime state when recycling it	2011-06-23 22:13:31 -05:00
xfs_inode.c	Merge branch 'for-linus' of git://oss.sgi.com/xfs/xfs	2011-05-26 10:49:11 -07:00
xfs_inode.h	xfs: reset inode per-lifetime state when recycling it	2011-06-23 22:13:31 -05:00
xfs_inode_item.c	xfs: cleanup duplicate initializations	2011-04-28 13:25:29 -05:00
xfs_inode_item.h	…
xfs_inum.h	…
xfs_iomap.c	xfs: rename xfs_cmn_err_fsblock_zero()	2011-03-07 10:06:35 +11:00
xfs_iomap.h	xfs: kill xfs_iomap	2010-12-16 16:05:51 -06:00
xfs_itable.c	xfs: fix variable set but not used warnings	2011-04-08 08:09:12 -05:00
xfs_itable.h	…
xfs_log.c	xfs: make log devices with write back caches work	2011-06-16 10:52:39 -05:00
xfs_log.h	xfs: exact busy extent tracking	2011-04-28 13:18:04 -05:00
xfs_log_cil.c	xfs: add online discard support	2011-05-24 11:17:13 -05:00
xfs_log_priv.h	xfs: exact busy extent tracking	2011-04-28 13:18:04 -05:00
xfs_log_recover.c	xfs: reset buffer pointers before freeing them	2011-05-19 12:03:45 -05:00
xfs_log_recover.h	…
xfs_mount.c	xfs: cleanup duplicate initializations	2011-04-28 13:25:29 -05:00
xfs_mount.h	xfs: add online discard support	2011-05-24 11:17:13 -05:00
xfs_mru_cache.c	xfs: convert to alloc_workqueue()	2011-02-01 11:42:43 +01:00
xfs_mru_cache.h	…
xfs_quota.h	xfs: Convert xlog_warn to new logging interface	2011-03-07 10:01:35 +11:00
xfs_rename.c	xfs: log timestamp changes to the source inode in rename	2010-12-09 17:07:02 -06:00
xfs_rtalloc.c	xfs: Convert remaining cmn_err() callers to new API	2011-03-07 10:08:35 +11:00
xfs_rtalloc.h	xfs: Convert remaining cmn_err() callers to new API	2011-03-07 10:08:35 +11:00
xfs_rw.c	xfs: Convert remaining cmn_err() callers to new API	2011-03-07 10:08:35 +11:00
xfs_rw.h	…
xfs_sb.h	…
xfs_trans.c	xfs: add online discard support	2011-05-24 11:17:13 -05:00
xfs_trans.h	xfs: more sensible inode refcounting for ialloc	2011-02-22 20:32:28 -06:00
xfs_trans_ail.c	xfs: fix race condition in AIL push trigger	2011-05-09 18:35:04 -05:00
xfs_trans_buf.c	xfs: xfs_trans_read_buf() should return an error on failure	2011-03-26 09:14:44 +11:00
xfs_trans_extfree.c	xfs: Pull EFI/EFD handling out from under the AIL lock	2010-12-20 11:59:49 +11:00
xfs_trans_inode.c	Fix common misspellings	2011-03-31 11:26:23 -03:00
xfs_trans_priv.h	xfs: push the AIL from memory reclaim and periodic sync	2011-04-08 12:45:07 +10:00
xfs_trans_space.h	…
xfs_types.h	xfs: exact busy extent tracking	2011-04-28 13:18:04 -05:00
xfs_utils.c	…
xfs_utils.h	…
xfs_vnodeops.c	xfs: clear XFS_IDIRTY_RELEASE on truncate down	2011-06-23 22:13:46 -05:00
xfs_vnodeops.h	xfs: preallocation transactions do not need to be synchronous	2011-03-26 09:13:08 +11:00