WSL2-Linux-Kernel/tools
Artem Savkov 5ce4164fff objtool: Fix segfault in .cold detection with -ffunction-sections
[ Upstream commit 22566c1603 ]

Because find_symbol_by_name() traverses the same lists as
read_symbols(), changing sym->name in place without copying it affects
the result of find_symbol_by_name().  In the case where a ".cold"
function precedes its parent in sec->symbol_list, it can result in a
function being considered a parent of itself. This leads to function
length being set to 0 and other consequent side-effects including a
segfault in add_switch_table().  The effects of this bug are only
visible when building with -ffunction-sections in KCFLAGS.

Fix by copying the search string instead of modifying it in place.

Signed-off-by: Artem Savkov <asavkov@redhat.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: 13810435b9 ("objtool: Support GCC 8's cold subfunctions")
Link: http://lkml.kernel.org/r/910abd6b5a4945130fd44f787c24e07b9e07c8da.1542736240.git.jpoimboe@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2018-12-17 09:28:50 +01:00
..
accounting
arch tools headers: Synchronise x86 cpufeatures.h for L1TF additions 2018-08-15 18:13:01 +02:00
build tools: build: Use HOSTLDFLAGS with fixdep 2018-08-24 13:09:17 +02:00
cgroup
firewire
gpio
hv tools: hv: fcopy: set 'error' in case an unknown operation was requested 2018-10-10 08:54:28 +02:00
iio
include tools: sync up .h files with the repective arch and uapi .h files 2018-05-30 12:19:59 +02:00
kvm/kvm_stat tools/kvm_stat: fix handling of invalid paths in debugfs provider 2018-10-10 08:54:20 +02:00
laptop
leds
lib
net bpf: fix uninitialized variable in bpf tools 2018-06-21 04:02:49 +09:00
nfsd
objtool objtool: Fix segfault in .cold detection with -ffunction-sections 2018-12-17 09:28:50 +01:00
pci
pcmcia
perf perf tools: Restore proper cwd on return from mnt namespace 2018-12-17 09:28:49 +01:00
power tools/power/cpupower: fix compilation with STATIC=true 2018-12-01 09:42:50 +01:00
scripts Kbuild: fix # escaping in .cmd files for future Make 2018-07-11 16:29:21 +02:00
spi
testing selftests: add script to stress-test nft packet path vs. control plane 2018-12-17 09:28:48 +01:00
thermal/tmon tools/thermal: tmon: fix for segfault 2018-05-30 07:52:28 +02:00
time
usb tools: usb: ffs-test: Fix build on big endian systems 2018-09-05 09:26:26 +02:00
virtio
vm tools/vm/page-types.c: fix "defined but not used" warning 2018-10-10 08:54:22 +02:00
Makefile