Charles Keepax 1d0d561ad1 net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag ... A new flag MACB_CAPS_CLK_HW_CHG was added and all callers of macb_set_tx_clk were gated on the presence of this flag. - if (!clk) + if (!bp->tx_clk || !(bp->caps & MACB_CAPS_CLK_HW_CHG)) However the flag was not added to anything other than the new sama7g5_gem, turning that function call into a no op for all other systems. This breaks the networking on Zynq. The commit message adding this states: a new capability so that macb_set_tx_clock() to not be called for IPs having this capability This strongly implies that present of the flag was intended to skip the function not absence of the flag. Update the if statement to this effect, which repairs the existing users. Fixes: daafa1d33c ("net: macb: add capability to not set the clock rate") Suggested-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Link: https://lore.kernel.org/r/20210104103802.13091-1-ckeepax@opensource.cirrus.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2021-01-04 13:28:09 -08:00
..
Kconfig	ethernet: select CONFIG_CRC32 as needed	2020-12-04 14:42:21 -08:00
Makefile	…
macb.h	Revert "macb: support the two tx descriptors on at91rm9200"	2020-12-10 13:32:33 -08:00
macb_main.c	net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag	2021-01-04 13:28:09 -08:00
macb_pci.c	net: macb: move pdata to private header	2020-09-30 14:18:19 -07:00
macb_ptp.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00