J. Bruce Fields 4425ca3677 nfsd: fix crash on COPY_NOTIFY with special stateid ... [ Upstream commit 074b07d94e ] RTM says "If the special ONE stateid is passed to nfs4_preprocess_stateid_op(), it returns status=0 but does not set *cstid. nfsd4_copy_notify() depends on stid being set if status=0, and thus can crash if the client sends the right COPY_NOTIFY RPC." RFC 7862 says "The cna_src_stateid MUST refer to either open or locking states provided earlier by the server. If it is invalid, then the operation MUST fail." The RFC doesn't specify an error, and the choice doesn't matter much as this is clearly illegal client behavior, but bad_stateid seems reasonable. Simplest is just to guarantee that nfs4_preprocess_stateid_op, called with non-NULL cstid, errors out if it can't return a stateid. Reported-by: rtm@csail.mit.edu Fixes: 624322f1ad ("NFSD add COPY_NOTIFY operation") Signed-off-by: J. Bruce Fields <bfields@redhat.com> Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Reviewed-by: Olga Kornievskaia <kolga@netapp.com> Tested-by: Olga Kornievskaia <kolga@netapp.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-03-08 19:12:36 +01:00
..
Kconfig	scsi: core: Rename CONFIG_BLK_SCSI_REQUEST to CONFIG_SCSI_COMMON	2021-07-28 22:24:27 -04:00
Makefile	nfsd: remove fault injection code	2020-09-25 18:01:26 -04:00
acl.h	nfsd: eliminate an unnecessary acl size limit	2019-08-28 21:13:45 -04:00
auth.c	nfsd: auth: Fix gid sorting when rootsquash enabled	2018-01-22 20:13:07 -08:00
auth.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
blocklayout.c	block: remove REQ_OP_SCSI_{IN,OUT}	2021-06-30 15:34:19 -06:00
blocklayoutxdr.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
blocklayoutxdr.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
cache.h	nfsd4: make drc_slab global, not per-net	2020-06-01 17:44:45 -04:00
current_stateid.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
export.c	idmapped-mounts-v5.12	2021-02-23 13:39:45 -08:00
export.h	nfsd: report per-export stats	2021-01-25 09:36:28 -05:00
fault_inject.c	nfsd: no need to check return value of debugfs_create functions	2019-07-03 16:57:17 +02:00
filecache.c	nfsd: Fix a warning for nfsd_file_close_inode	2021-10-01 11:17:40 -04:00
filecache.h	nfsd: convert file cache to use over/underflow safe refcount	2020-02-06 11:22:55 -05:00
flexfilelayout.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
flexfilelayoutxdr.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
flexfilelayoutxdr.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
idmap.h	nfsd: Remove duplicate define of IDMAP_NAMESZ/IDMAP_TYPE_xx	2015-07-20 14:58:46 -04:00
lockd.c	Keep read and write fds with each nlm_file	2021-08-23 18:05:31 -04:00
netns.h	NFSD: delay unmount source's export after inter-server copy completed.	2021-05-25 17:06:51 -04:00
nfs2acl.c	NFSD: Update the NFSv2 ACL ACCESS result encoder to use struct xdr_stream	2021-03-22 10:19:01 -04:00
nfs3acl.c	nfsd: fix NULL dereference in nfs3svc_encode_getaclres	2021-07-06 20:14:44 -04:00
nfs3proc.c	NFSD: Fix zero-length NFSv3 WRITEs	2022-03-08 19:12:33 +01:00
nfs3xdr.c	Revert "nfsd: skip some unnecessary stats in the v4 case"	2022-03-08 19:12:36 +01:00
nfs4acl.c	acl: handle idmapped mounts	2021-01-24 14:27:17 +01:00
nfs4callback.c	nfsd: rpc_peeraddr2str needs rcu lock	2021-07-06 20:14:42 -04:00
nfs4idmap.c	nfsd: Use seq_putc() in two functions	2020-07-13 17:28:46 -04:00
nfs4layouts.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
nfs4proc.c	NFSD: Have legacy NFSD WRITE decoders use xdr_stream_subsegment()	2022-03-08 19:12:33 +01:00
nfs4recover.c	nfsd: Fix nsfd startup race (again)	2021-12-14 10:57:14 +01:00
nfs4state.c	nfsd: fix crash on COPY_NOTIFY with special stateid	2022-03-08 19:12:36 +01:00
nfs4xdr.c	NFSD: Fix the behavior of READ near OFFSET_MAX	2022-02-16 12:56:06 +01:00
nfscache.c	nfsd: protect concurrent access to nfsd stats counters	2021-01-25 09:36:27 -05:00
nfsctl.c	fsnotify: fix fsnotify hooks in pseudo filesystems	2022-02-01 17:27:01 +01:00
nfsd.h	NFSD: delay unmount source's export after inter-server copy completed.	2021-05-25 17:06:51 -04:00
nfsfh.c	NFSD: Update the GETATTR3res encoder to use struct xdr_stream	2021-03-22 10:18:51 -04:00
nfsfh.h	NFSD: Constify @fh argument of knfsd_fh_hash()	2021-05-18 13:44:03 -04:00
nfsproc.c	NFSD: Fix zero-length NFSv3 WRITEs	2022-03-08 19:12:33 +01:00
nfssvc.c	NFSD: delay unmount source's export after inter-server copy completed.	2021-05-25 17:06:51 -04:00
nfsxdr.c	NFSD: Have legacy NFSD WRITE decoders use xdr_stream_subsegment()	2022-03-08 19:12:33 +01:00
pnfs.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
state.h	nfsd: track filehandle aliasing in nfs4_files	2021-04-19 16:41:36 -04:00
stats.c	nfsd: protect concurrent access to nfsd stats counters	2021-01-25 09:36:27 -05:00
stats.h	nfsd: report per-export stats	2021-01-25 09:36:28 -05:00
trace.c	NFSD: Add SPDX header for fs/nfsd/trace.c	2020-11-30 13:00:24 -05:00
trace.h	NFSD: Fix offset type in I/O trace points	2022-02-16 12:56:06 +01:00
vfs.c	NFSD: Fix verifier returned in stable WRITEs	2022-03-08 19:12:36 +01:00
vfs.h	NFSD: Update the NFSv3 ACCESS3res encoder to use struct xdr_stream	2021-03-22 10:18:52 -04:00
xdr.h	NFSD: Have legacy NFSD WRITE decoders use xdr_stream_subsegment()	2022-03-08 19:12:33 +01:00
xdr3.h	NFSD: Have legacy NFSD WRITE decoders use xdr_stream_subsegment()	2022-03-08 19:12:33 +01:00
xdr4.h	NFSD add vfs_fsync after async copy is done	2021-05-25 17:06:51 -04:00
xdr4cb.h	NFSD CB_OFFLOAD xdr	2018-09-25 20:34:54 -04:00