Kuniyuki Iwashima e0833d1fed dccp/tcp: Fixup bhash2 bucket when connect() fails. ... If a socket bound to a wildcard address fails to connect(), we only reset saddr and keep the port. Then, we have to fix up the bhash2 bucket; otherwise, the bucket has an inconsistent address in the list. Also, listen() for such a socket will fire the WARN_ON() in inet_csk_get_port(). [0] Note that when a system runs out of memory, we give up fixing the bucket and unlink sk from bhash and bhash2 by inet_put_port(). [0]: WARNING: CPU: 0 PID: 207 at net/ipv4/inet_connection_sock.c:548 inet_csk_get_port (net/ipv4/inet_connection_sock.c:548 (discriminator 1)) Modules linked in: CPU: 0 PID: 207 Comm: bhash2_prev_rep Not tainted 6.1.0-rc3-00799-gc8421681c845 #63 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.0-1.amzn2022.0.1 04/01/2014 RIP: 0010:inet_csk_get_port (net/ipv4/inet_connection_sock.c:548 (discriminator 1)) Code: 74 a7 eb 93 48 8b 54 24 18 0f b7 cb 4c 89 e6 4c 89 ff e8 48 b2 ff ff 49 8b 87 18 04 00 00 e9 32 ff ff ff 0f 0b e9 34 ff ff ff <0f> 0b e9 42 ff ff ff 41 8b 7f 50 41 8b 4f 54 89 fe 81 f6 00 00 ff RSP: 0018:ffffc900003d7e50 EFLAGS: 00010202 RAX: ffff8881047fb500 RBX: 0000000000004e20 RCX: 0000000000000000 RDX: 000000000000000a RSI: 00000000fffffe00 RDI: 00000000ffffffff RBP: ffffffff8324dc00 R08: 0000000000000001 R09: 0000000000000001 R10: 0000000000000001 R11: 0000000000000001 R12: 0000000000000000 R13: 0000000000000001 R14: 0000000000004e20 R15: ffff8881054e1280 FS: 00007f8ac04dc740(0000) GS:ffff88842fc00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000020001540 CR3: 00000001055fa003 CR4: 0000000000770ef0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 PKRU: 55555554 Call Trace: <TASK> inet_csk_listen_start (net/ipv4/inet_connection_sock.c:1205) inet_listen (net/ipv4/af_inet.c:228) __sys_listen (net/socket.c:1810) __x64_sys_listen (net/socket.c:1819 net/socket.c:1817 net/socket.c:1817) do_syscall_64 (arch/x86/entry/common.c:50 arch/x86/entry/common.c:80) entry_SYSCALL_64_after_hwframe (arch/x86/entry/entry_64.S:120) RIP: 0033:0x7f8ac051de5d Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 93 af 1b 00 f7 d8 64 89 01 48 RSP: 002b:00007ffc1c177248 EFLAGS: 00000206 ORIG_RAX: 0000000000000032 RAX: ffffffffffffffda RBX: 0000000020001550 RCX: 00007f8ac051de5d RDX: ffffffffffffff80 RSI: 0000000000000000 RDI: 0000000000000004 RBP: 00007ffc1c177270 R08: 0000000000000018 R09: 0000000000000007 R10: 0000000020001540 R11: 0000000000000206 R12: 00007ffc1c177388 R13: 0000000000401169 R14: 0000000000403e18 R15: 00007f8ac0723000 </TASK> Fixes: 28044fc1d4 ("net: Add a bhash2 table hashed by port and address") Reported-by: syzbot <syzkaller@googlegroups.com> Reported-by: Mat Martineau <mathew.j.martineau@linux.intel.com> Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com> Acked-by: Joanne Koong <joannelkoong@gmail.com> Reviewed-by: Eric Dumazet <edumazet@google.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2022-11-22 20:15:37 -08:00
..
ila	…
netfilter	netfilter: rpfilter/fib: Set ->flowic_uid correctly for user namespaces.	2022-10-19 08:46:48 +02:00
Kconfig	…
Makefile	…
addrconf.c	Networking fixes for 6.1-rc2, including fixes from netfilter	2022-10-20 17:24:59 -07:00
addrconf_core.c	…
addrlabel.c	ipv6: addrlabel: fix infoleak when sending struct ifaddrlblmsg to network	2022-11-07 12:26:15 +00:00
af_inet6.c	tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().	2022-10-12 17:50:37 -07:00
ah6.c	…
anycast.c	…
calipso.c	…
datagram.c	udp: Update reuse->has_conns under reuseport_lock.	2022-10-18 10:17:18 +02:00
esp6.c	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next	2022-10-03 07:52:13 +01:00
esp6_offload.c	…
exthdrs.c	…
exthdrs_core.c	…
exthdrs_offload.c	…
fib6_notifier.c	…
fib6_rules.c	…
fou6.c	…
icmp.c	…
inet6_connection_sock.c	…
inet6_hashtables.c	…
ioam6.c	…
ioam6_iptunnel.c	…
ip6_checksum.c	…
ip6_fib.c	…
ip6_flowlabel.c	treewide: use get_random_u32() when possible	2022-10-11 17:42:58 -06:00
ip6_gre.c	ipv6: ensure sane device mtu in tunnels	2022-10-25 16:04:22 -07:00
ip6_icmp.c	…
ip6_input.c	…
ip6_offload.c	…
ip6_offload.h	…
ip6_output.c	…
ip6_tunnel.c	ipv6: ensure sane device mtu in tunnels	2022-10-25 16:04:22 -07:00
ip6_udp_tunnel.c	…
ip6_vti.c	…
ip6mr.c	…
ipcomp6.c	…
ipv6_sockglue.c	tcp: Fix data races around icsk->icsk_af_ops.	2022-10-12 17:50:37 -07:00
mcast.c	treewide: use prandom_u32_max() when possible, part 1	2022-10-11 17:42:55 -06:00
mcast_snoop.c	…
mip6.c	…
ndisc.c	…
netfilter.c	…
output_core.c	treewide: use get_random_u32() when possible	2022-10-11 17:42:58 -06:00
ping.c	inet: ping: fix recent breakage	2022-10-12 09:10:02 +01:00
proc.c	…
protocol.c	…
raw.c	…
reassembly.c	…
route.c	ipv6: fix WARNING in ip6_route_net_exit_late()	2022-11-02 20:47:14 -07:00
rpl.c	…
rpl_iptunnel.c	…
seg6.c	…
seg6_hmac.c	…
seg6_iptunnel.c	…
seg6_local.c	…
sit.c	ipv6: ensure sane device mtu in tunnels	2022-10-25 16:04:22 -07:00
syncookies.c	…
sysctl_net_ipv6.c	…
tcp_ipv6.c	dccp/tcp: Fixup bhash2 bucket when connect() fails.	2022-11-22 20:15:37 -08:00
tcpv6_offload.c	…
tunnel6.c	…
udp.c	udp: advertise ipv6 udp support for msghdr::ubuf_info	2022-10-28 20:21:25 -07:00
udp_impl.h	tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().	2022-10-12 17:50:37 -07:00
udp_offload.c	…
udplite.c	tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().	2022-10-12 17:50:37 -07:00
xfrm6_input.c	…
xfrm6_output.c	…
xfrm6_policy.c	…
xfrm6_protocol.c	…
xfrm6_state.c	…
xfrm6_tunnel.c	…