847fb8aca3
The function has an unsigned return type, but returns a negative constant to indicate an error condition. The result of calling the function is only tested by comparison to 0, and thus unsigned is not needed and can be dropped from the return type. A sematic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @exists@ identifier f; constant C; @@ unsigned f(...) { <+... * return -C; ...+> } // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Cc: Petr Vandrovec <vandrove@vc.cvut.cz> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
||
|---|---|---|
| .. | ||
| Makefile | ||
| g450_pll.c | ||
| g450_pll.h | ||
| i2c-matroxfb.c | ||
| matroxfb_DAC1064.c | ||
| matroxfb_DAC1064.h | ||
| matroxfb_Ti3026.c | ||
| matroxfb_Ti3026.h | ||
| matroxfb_accel.c | ||
| matroxfb_accel.h | ||
| matroxfb_base.c | ||
| matroxfb_base.h | ||
| matroxfb_crtc2.c | ||
| matroxfb_crtc2.h | ||
| matroxfb_g450.c | ||
| matroxfb_g450.h | ||
| matroxfb_maven.c | ||
| matroxfb_maven.h | ||
| matroxfb_misc.c | ||
| matroxfb_misc.h | ||