Larry Chen 69eb7765b9 ocfs2: fix crash in ocfs2_duplicate_clusters_by_page() ... ocfs2_duplicate_clusters_by_page() may crash if one of the extent's pages is dirty. When a page has not been written back, it is still in dirty state. If ocfs2_duplicate_clusters_by_page() is called against the dirty page, the crash happens. To fix this bug, we can just unlock the page and wait until the page until its not dirty. The following is the backtrace: kernel BUG at /root/code/ocfs2/refcounttree.c:2961! [exception RIP: ocfs2_duplicate_clusters_by_page+822] __ocfs2_move_extent+0x80/0x450 [ocfs2] ? __ocfs2_claim_clusters+0x130/0x250 [ocfs2] ocfs2_defrag_extent+0x5b8/0x5e0 [ocfs2] __ocfs2_move_extents_range+0x2a4/0x470 [ocfs2] ocfs2_move_extents+0x180/0x3b0 [ocfs2] ? ocfs2_wait_for_recovery+0x13/0x70 [ocfs2] ocfs2_ioctl_move_extents+0x133/0x2d0 [ocfs2] ocfs2_ioctl+0x253/0x640 [ocfs2] do_vfs_ioctl+0x90/0x5f0 SyS_ioctl+0x74/0x80 do_syscall_64+0x74/0x140 entry_SYSCALL_64_after_hwframe+0x3d/0xa2 Once we find the page is dirty, we do not wait until it's clean, rather we use write_one_page() to write it back Link: http://lkml.kernel.org/r/20180829074740.9438-1-lchen@suse.com [lchen@suse.com: update comments] Link: http://lkml.kernel.org/r/20180830075041.14879-1-lchen@suse.com [akpm@linux-foundation.org: coding-style fixes] Signed-off-by: Larry Chen <lchen@suse.com> Acked-by: Changwei Ge <ge.changwei@h3c.com> Cc: Mark Fasheh <mark@fasheh.com> Cc: Joel Becker <jlbec@evilplan.org> Cc: Junxiao Bi <junxiao.bi@oracle.com> Cc: Joseph Qi <jiangqi903@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-10-05 16:32:04 -07:00
..
cluster	ocfs2: make several functions and variables static (and some const)	2018-08-17 16:20:28 -07:00
dlm	treewide: kmalloc() -> kmalloc_array()	2018-06-12 16:19:22 -07:00
dlmfs	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
Kconfig	ocfs2: Make OCFS2_FS depend on CONFIGFS_FS	2011-01-16 21:22:40 +00:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
acl.c	ocfs2/acl: use 'ip_xattr_sem' to protect getting extended attribute	2018-01-31 17:18:35 -08:00
acl.h	ocfs2: make ocfs2_set_acl() static	2017-09-06 17:27:24 -07:00
alloc.c	ocfs2: clean up some unnecessary code	2018-08-17 16:20:27 -07:00
alloc.h	ocfs2: try to reuse extent block in dealloc without meta_alloc	2018-01-31 17:18:35 -08:00
aops.c	ocfs2: use 'oi' instead of 'OCFS2_I()'	2018-04-05 21:36:21 -07:00
aops.h	ocfs2: keep the trace point consistent with the function name	2018-04-05 21:36:21 -07:00
blockcheck.c	ocfs2: kill endianness abuses in blockcheck.c	2012-05-29 23:28:35 -04:00
blockcheck.h	…
buffer_head_io.c	ocfs2: fix ocfs2 read block panic	2018-09-20 22:01:12 +02:00
buffer_head_io.h	ocfs2: clean up some unused function declarations	2017-11-15 18:21:01 -08:00
dcache.c	VFS: normal filesystems (and lustre): d_inode() annotations	2015-04-15 15:06:57 -04:00
dcache.h	ocfs2: revert iput deferring code in ocfs2_drop_dentry_lock	2014-04-03 16:20:55 -07:00
dir.c	ocfs2: use 'osb' instead of 'OCFS2_SB()'	2018-04-05 21:36:21 -07:00
dir.h	VFS: normal filesystems (and lustre): d_inode() annotations	2015-04-15 15:06:57 -04:00
dlmglue.c	ocfs2: make several functions and variables static (and some const)	2018-08-17 16:20:28 -07:00
dlmglue.h	ocfs2: ocfs2_inode_lock_tracker does not distinguish lock level	2018-06-07 17:34:33 -07:00
export.c	ocfs2: Use ERR_CAST() to avoid cross-structure cast	2017-05-28 10:11:49 -07:00
export.h	…
extent_map.c	ocfs2: add ocfs2_overwrite_io()	2018-01-31 17:18:35 -08:00
extent_map.h	ocfs2: add ocfs2_overwrite_io()	2018-01-31 17:18:35 -08:00
file.c	vfs: dedupe: rationalize args	2018-07-06 23:57:03 +02:00
file.h	ocfs2: clean up redundant function declarations	2018-06-07 17:34:33 -07:00
filecheck.c	ocfs2: add duplicated ino number check	2018-04-05 21:36:22 -07:00
filecheck.h	ocfs2: add kobject for online file check	2018-04-05 21:36:22 -07:00
heartbeat.c	ocfs2: Remove mlog(0) from fs/ocfs2/heartbeat.c	2011-02-23 21:17:39 +08:00
heartbeat.h	…
inode.c	ocfs2: clean up some unnecessary code	2018-08-17 16:20:27 -07:00
inode.h	ocfs2: convert inode refcount test to a helper	2016-12-10 12:39:45 -08:00
ioctl.c	ocfs2: eliminate a misreported warning	2018-06-07 17:34:33 -07:00
ioctl.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
journal.c	treewide: kzalloc() -> kcalloc()	2018-06-12 16:19:22 -07:00
journal.h	jbd2: add support for avoiding data writes during transaction commits	2016-04-24 00:56:07 -04:00
localalloc.c	ocfs2: return -EROFS when filesystem becomes read-only	2018-08-17 16:20:27 -07:00
localalloc.h	ocfs2: free allocated clusters if error occurs after ocfs2_claim_clusters	2014-02-06 13:48:51 -08:00
locks.c	ocfs2: fix flock panic issue	2015-12-29 17:45:49 -08:00
locks.h	…
mmap.c	fs: ocfs2: use new return type vm_fault_t	2018-06-07 17:34:34 -07:00
mmap.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
move_extents.c	ocfs2: clean up some dead code	2017-09-06 17:27:24 -07:00
move_extents.h	Ocfs2/move_extents: move/defrag extents within a certain range.	2011-05-25 15:17:12 +08:00
namei.c	ocfs2: drop a VLA in ocfs2_orphan_del()	2018-06-07 17:34:34 -07:00
namei.h	ocfs2: do not include dio entry in case of orphan scan	2015-11-05 19:34:48 -08:00
ocfs1_fs_compat.h	…
ocfs2.h	ocfs2: add kobject for online file check	2018-04-05 21:36:22 -07:00
ocfs2_fs.h	ocfs2: correct the comments position of struct ocfs2_dir_block_trailer	2018-06-07 17:34:34 -07:00
ocfs2_ioctl.h	Ocfs2/move_extents: Adding new ioctl code 'OCFS2_IOC_MOVE_EXT' to ocfs2.	2011-05-25 15:17:08 +08:00
ocfs2_lockid.h	ocfs2: add trimfs dlm lock resource	2018-01-31 17:18:35 -08:00
ocfs2_lockingver.h	…
ocfs2_trace.h	ocfs2: keep the trace point consistent with the function name	2018-04-05 21:36:21 -07:00
quota.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
quota_global.c	ocfs2: convert to new i_version API	2018-01-29 06:42:21 -05:00
quota_local.c	ocfs2: return -EROFS when filesystem becomes read-only	2018-08-17 16:20:27 -07:00
refcounttree.c	ocfs2: fix crash in ocfs2_duplicate_clusters_by_page()	2018-10-05 16:32:04 -07:00
refcounttree.h	ocfs2: implement the VFS clone_range, copy_range, and dedupe_range features	2016-12-10 12:39:45 -08:00
reservations.c	ocfs2: make resv_lock spinlock static	2015-02-10 14:30:29 -08:00
reservations.h	Fix common misspellings	2011-03-31 11:26:23 -03:00
resize.c	ocfs2: solve a problem of crossing the boundary in updating backups	2016-03-25 16:37:42 -07:00
resize.h	…
slot_map.c	ocfs2: clean up an unneeded goto in ocfs2_put_slot()	2016-05-19 19:12:14 -07:00
slot_map.h	…
stack_o2cb.c	ocfs2: avoid a pointless delay in o2cb_cluster_check()	2015-04-14 16:48:57 -07:00
stack_user.c	treewide: Align function definition open/close braces	2018-03-26 11:13:09 +02:00
stackglue.c	ocfs2: constify attribute_group structures	2017-07-06 16:24:30 -07:00
stackglue.h	ocfs2: fix crash caused by stale lvb with fsdlm plugin	2017-01-10 18:31:54 -08:00
suballoc.c	ocfs2: remove two unused functions from suballoc.c	2018-04-05 21:36:22 -07:00
suballoc.h	ocfs2: rollback alloc_dinode counts when ocfs2_block_group_set_bits() failed	2014-04-03 16:20:56 -07:00
super.c	ocfs2: add kobject for online file check	2018-04-05 21:36:22 -07:00
super.h	ocfs2: remove unused declaration ocfs2_publish_get_mount_state()	2017-11-15 18:21:01 -08:00
symlink.c	vfs: remove ".readlink = generic_readlink" assignments	2016-12-09 16:45:04 +01:00
symlink.h	ocfs: simplify symlink handling	2012-05-29 23:28:40 -04:00
sysfile.c	treewide: kzalloc() -> kcalloc()	2018-06-12 16:19:22 -07:00
sysfile.h	…
uptodate.c	ocfs2: remove unnecessary null pointer check before kmem_cache_destroy()	2018-04-05 21:36:22 -07:00
uptodate.h	…
xattr.c	ocfs2: use 'osb' instead of 'OCFS2_SB()'	2018-04-05 21:36:21 -07:00
xattr.h	ocfs2: fix posix_acl_create deadlock	2016-05-12 15:52:50 -07:00