Luis Henriques 1a545cb025 ceph: fix buffer free while holding i_ceph_lock in fill_inode() ... [ Upstream commit af8a85a417 ] Calling ceph_buffer_put() in fill_inode() may result in freeing the i_xattrs.blob buffer while holding the i_ceph_lock. This can be fixed by postponing the call until later, when the lock is released. The following backtrace was triggered by fstests generic/070. BUG: sleeping function called from invalid context at mm/vmalloc.c:2283 in_atomic(): 1, irqs_disabled(): 0, pid: 3852, name: kworker/0:4 6 locks held by kworker/0:4/3852: #0: 000000004270f6bb ((wq_completion)ceph-msgr){+.+.}, at: process_one_work+0x1b8/0x5f0 #1: 00000000eb420803 ((work_completion)(&(&con->work)->work)){+.+.}, at: process_one_work+0x1b8/0x5f0 #2: 00000000be1c53a4 (&s->s_mutex){+.+.}, at: dispatch+0x288/0x1476 #3: 00000000559cb958 (&mdsc->snap_rwsem){++++}, at: dispatch+0x2eb/0x1476 #4: 000000000d5ebbae (&req->r_fill_mutex){+.+.}, at: dispatch+0x2fc/0x1476 #5: 00000000a83d0514 (&(&ci->i_ceph_lock)->rlock){+.+.}, at: fill_inode.isra.0+0xf8/0xf70 CPU: 0 PID: 3852 Comm: kworker/0:4 Not tainted 5.2.0+ #441 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.12.1-0-ga5cab58-prebuilt.qemu.org 04/01/2014 Workqueue: ceph-msgr ceph_con_workfn Call Trace: dump_stack+0x67/0x90 ___might_sleep.cold+0x9f/0xb1 vfree+0x4b/0x60 ceph_buffer_release+0x1b/0x60 fill_inode.isra.0+0xa9b/0xf70 ceph_fill_trace+0x13b/0xc70 ? dispatch+0x2eb/0x1476 dispatch+0x320/0x1476 ? __mutex_unlock_slowpath+0x4d/0x2a0 ceph_con_workfn+0xc97/0x2ec0 ? process_one_work+0x1b8/0x5f0 process_one_work+0x244/0x5f0 worker_thread+0x4d/0x3e0 kthread+0x105/0x140 ? process_one_work+0x5f0/0x5f0 ? kthread_park+0x90/0x90 ret_from_fork+0x3a/0x50 Signed-off-by: Luis Henriques <lhenriques@suse.com> Reviewed-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Ilya Dryomov <idryomov@gmail.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2019-09-10 10:32:18 +01:00
..
Kconfig	ceph: add acl for cephfs	2013-12-31 20:32:01 +02:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
acl.c	ceph: unify inode i_ctime update	2017-06-14 19:37:23 +02:00
addr.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
cache.c	The highlights include:	2017-09-12 20:03:53 -07:00
cache.h	ceph: improve fscache revalidation	2016-06-01 10:31:50 +02:00
caps.c	ceph: fix buffer free while holding i_ceph_lock in __ceph_build_xattrs_blob()	2019-09-10 10:32:18 +01:00
ceph_frag.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
debugfs.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
dir.c	ceph: ensure d_name stability in ceph_dentry_hash()	2019-05-02 09:40:29 +02:00
export.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
file.c	ceph: fix rsize/wsize capping in ceph_direct_read_write()	2018-05-16 10:10:27 +02:00
inode.c	ceph: fix buffer free while holding i_ceph_lock in fill_inode()	2019-09-10 10:32:18 +01:00
ioctl.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ioctl.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
locks.c	ceph: don't try fill file_lock on unsuccessful GETFILELOCK reply	2019-08-29 08:26:42 +02:00
mds_client.c	ceph: fix ci->i_head_snapc leak	2019-05-02 09:40:29 +02:00
mds_client.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
mdsmap.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
snap.c	ceph: fix buffer free while holding i_ceph_lock in __ceph_build_xattrs_blob()	2019-09-10 10:32:18 +01:00
strings.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
super.c	ceph: flush dirty inodes before proceeding with remount	2019-05-25 18:25:22 +02:00
super.h	ceph: fix buffer free while holding i_ceph_lock in __ceph_build_xattrs_blob()	2019-09-10 10:32:18 +01:00
xattr.c	ceph: fix buffer free while holding i_ceph_lock in __ceph_build_xattrs_blob()	2019-09-10 10:32:18 +01:00