Eric Dumazet f2c31e32b3 net: fix NULL dereferences in check_peer_redir() ... Gergely Kalman reported crashes in check_peer_redir(). It appears commit f39925dbde (ipv4: Cache learned redirect information in inetpeer.) added a race, leading to possible NULL ptr dereference. Since we can now change dst neighbour, we should make sure a reader can safely use a neighbour. Add RCU protection to dst neighbour, and make sure check_peer_redir() can be called safely by different cpus in parallel. As neighbours are already freed after one RCU grace period, this patch should not add typical RCU penalty (cache cold effects) Many thanks to Gergely for providing a pretty report pointing to the bug. Reported-by: Gergely Kalman <synapse@hippy.csoma.elte.hu> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2011-08-03 03:34:12 -07:00
..
netfilter	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6	2011-07-05 23:23:37 -07:00
Kconfig	ipv4: Remove fib_hash.	2011-02-01 15:35:25 -08:00
Makefile	net: ipv4: add IPPROTO_ICMP socket kind	2011-05-13 16:08:13 -04:00
af_inet.c	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6	2011-07-05 23:23:37 -07:00
ah4.c	inet: constify ip headers and in6_addr	2011-04-22 11:04:14 -07:00
arp.c	neigh: Pass neighbour entry to output ops.	2011-07-17 23:11:17 -07:00
cipso_ipv4.c	atomic: use <linux/atomic.h>	2011-07-26 16:49:47 -07:00
datagram.c	ipv4: Lock socket and use cork flow in ip4_datagram_connect().	2011-05-08 13:48:57 -07:00
devinet.c	IPv4: Send gratuitous ARP for secondary IP addresses also	2011-07-25 16:16:00 -07:00
esp4.c	inet: constify ip headers and in6_addr	2011-04-22 11:04:14 -07:00
fib_frontend.c	rtnetlink: Compute and store minimum ifinfo dump size	2011-06-09 20:38:07 -07:00
fib_lookup.h	ipv4: Fix nexthop caching wrt. scoping.	2011-03-24 18:06:47 -07:00
fib_rules.c	ipv4: Use flowi4 in FIB layer.	2011-03-12 15:08:49 -08:00
fib_semantics.c	net,rcu: convert call_rcu(fc_rport_free_rcu) to kfree_rcu()	2011-05-07 22:50:55 -07:00
fib_trie.c	ipv4: save cpu cycles from check_leaf()	2011-07-18 10:41:18 -07:00
gre.c	gre: fix improper error handling	2011-07-23 20:06:00 -07:00
icmp.c	icmp: Fix regression in nexthop resolution during replies.	2011-07-22 06:22:10 -07:00
igmp.c	net: adjust array index	2011-08-01 02:27:21 -07:00
inet_connection_sock.c	seqlock: Get rid of SEQLOCK_UNLOCKED	2011-05-24 15:22:17 +02:00
inet_diag.c	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6	2011-06-20 22:29:08 -07:00
inet_fragment.c	…
inet_hashtables.c	…
inet_lro.c	lro: do vlan cleanup	2011-07-21 13:47:54 -07:00
inet_timewait_sock.c	tcp: fix inet_twsk_deschedule()	2011-02-19 18:59:04 -08:00
inetpeer.c	ipv6: make fragment identifications less predictable	2011-07-21 21:25:58 -07:00
ip_forward.c	ipv4: Fix 'iph' use before set.	2011-05-12 23:03:46 -04:00
ip_fragment.c	ipv4: Add ip_defrag() agent IP_DEFRAG_AF_PACKET.	2011-07-05 22:34:52 -07:00
ip_gre.c	net: Abstract dst->neighbour accesses behind helpers.	2011-07-17 23:11:35 -07:00
ip_input.c	ip: introduce ip_is_fragment helper inline function	2011-06-21 20:33:34 -07:00
ip_options.c	ip_options_compile: properly handle unaligned pointer	2011-05-31 15:11:02 -07:00
ip_output.c	net: fix NULL dereferences in check_peer_redir()	2011-08-03 03:34:12 -07:00
ip_sockglue.c	inet: add RCU protection to inet->opt	2011-04-28 13:16:35 -07:00
ipcomp.c	inet: constify ip headers and in6_addr	2011-04-22 11:04:14 -07:00
ipconfig.c	ipconfig: Reduce switch/case indent	2011-07-01 16:11:15 -07:00
ipip.c	net: call dev_alloc_name from register_netdevice	2011-05-05 10:57:45 -07:00
ipmr.c	ipv4: use RT_TOS after some rt_tos conversions	2011-07-23 20:05:31 -07:00
netfilter.c	netfilter: Fix ip_route_me_harder triggering ip_rt_bug	2011-06-29 05:47:32 -07:00
ping.c	ipv4, ping: Remove duplicate icmp.h include	2011-06-20 13:04:38 -07:00
proc.c	…
protocol.c	…
raw.c	atomic: use <linux/atomic.h>	2011-07-26 16:49:47 -07:00
route.c	net: fix NULL dereferences in check_peer_redir()	2011-08-03 03:34:12 -07:00
syncookies.c	tcp: RFC2988bis + taking RTT sample from 3WHS for the passive open side	2011-06-08 17:05:30 -07:00
sysctl_net_ipv4.c	inetpeer: remove unused list	2011-06-08 17:05:30 -07:00
tcp.c	net: refine {udp|tcp|sctp}_mem limits	2011-07-07 00:27:05 -07:00
tcp_bic.c	tcp: mark tcp_congestion_ops read_mostly	2011-03-10 00:40:17 -08:00
tcp_cong.c	…
tcp_cubic.c	tcp_cubic: limit delayed_ack ratio to prevent divide error	2011-05-08 15:51:57 -07:00
tcp_diag.c	…
tcp_highspeed.c	tcp: mark tcp_congestion_ops read_mostly	2011-03-10 00:40:17 -08:00
tcp_htcp.c	tcp: mark tcp_congestion_ops read_mostly	2011-03-10 00:40:17 -08:00
tcp_hybla.c	tcp: mark tcp_congestion_ops read_mostly	2011-03-10 00:40:17 -08:00
tcp_illinois.c	tcp: mark tcp_congestion_ops read_mostly	2011-03-10 00:40:17 -08:00
tcp_input.c	tcp: RFC2988bis + taking RTT sample from 3WHS for the passive open side	2011-06-08 17:05:30 -07:00
tcp_ipv4.c	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6	2011-06-20 22:29:08 -07:00
tcp_lp.c	Fix common misspellings	2011-03-31 11:26:23 -03:00
tcp_minisocks.c	tcp: RFC2988bis + taking RTT sample from 3WHS for the passive open side	2011-06-08 17:05:30 -07:00
tcp_output.c	inet: Pass flowi to ->queue_xmit().	2011-05-08 15:28:28 -07:00
tcp_probe.c	…
tcp_scalable.c	tcp: mark tcp_congestion_ops read_mostly	2011-03-10 00:40:17 -08:00
tcp_timer.c	tcp: Remove debug macro of TCP_CHECK_TIMER	2011-02-20 11:10:14 -08:00
tcp_vegas.c	tcp: mark tcp_congestion_ops read_mostly	2011-03-10 00:40:17 -08:00
tcp_vegas.h	…
tcp_veno.c	tcp: mark tcp_congestion_ops read_mostly	2011-03-10 00:40:17 -08:00
tcp_westwood.c	tcp: mark tcp_congestion_ops read_mostly	2011-03-10 00:40:17 -08:00
tcp_yeah.c	Fix common misspellings	2011-03-31 11:26:23 -03:00
tunnel4.c	…
udp.c	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6	2011-07-14 07:56:40 -07:00
udp_impl.h	…
udplite.c	…
xfrm4_input.c	…
xfrm4_mode_beet.c	…
xfrm4_mode_transport.c	…
xfrm4_mode_tunnel.c	…
xfrm4_output.c	xfrm4: Don't call icmp_send on local error	2011-07-01 17:33:19 -07:00
xfrm4_policy.c	ip: introduce ip_is_fragment helper inline function	2011-06-21 20:33:34 -07:00
xfrm4_state.c	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-3.6	2011-05-11 14:26:58 -04:00
xfrm4_tunnel.c	…