Peter Hurley bd972688eb firewire: ohci: Fix 'failed to read phy reg' on FW643 rev8 ... With the LSI FW643 rev 8 [1], the first commanded bus reset at the conclusion of ohci_enable() has been observed to fail with the following messages: [ 4.884015] firewire_ohci 0000:01:00.0: failed to read phy reg .... [ 5.684012] firewire_ohci 0000:01:00.0: failed to read phy reg With drivers/firewire/ohci.c instrumented, the error condition [2] indicates the PHY arbitration state machine has timed out prior to enabling PHY LCtrl. Furthermore, instrumenting ohci_enable() shows that LPS has been enabled within 1 ms. Test LPS latching every 1 ms rather than every 50ms. [1] lspci -v 01:00.0 FireWire (IEEE 1394): LSI Corporation FW643 [TrueFire] PCIe 1394b Controller (rev 08) (prog-if 10 [OHCI]) Subsystem: LSI Corporation FW643 [TrueFire] PCIe 1394b Controller Flags: bus master, fast devsel, latency 0, IRQ 92 Memory at fbeff000 (64-bit, non-prefetchable) [size=4K] Capabilities: [44] Power Management version 3 Capabilities: [4c] MSI: Enable+ Count=1/1 Maskable- 64bit+ Capabilities: [60] Express Endpoint, MSI 00 Capabilities: [100] Advanced Error Reporting Capabilities: [140] Virtual Channel Capabilities: [170] Device Serial Number 08-14-43-82-00-00-41-fc Kernel driver in use: firewire_ohci Kernel modules: firewire-ohci [2] instrumented WARNING in read_phy_reg() [ 4.576010] ------------[ cut here ]------------ [ 4.576035] WARNING: at ./drivers/firewire/ohci.c:570 read_phy_reg+0x93/0xe0 [firewire_ohci]() [ 4.576050] Hardware name: Precision WorkStation T5400 [ 4.576058] failed to read phy reg:1 (phy(5) @ config enhance:19) [ 4.576068] Modules linked in: hid_logitech_dj hid_generic(+) usbhid <...snip...> [ 4.576140] Pid: 61, comm: kworker/2:1 Not tainted 3.8.0-2+fwtest-xeon #2+fwtest [ 4.576149] Call Trace: [ 4.576160] [<ffffffff8105468f>] warn_slowpath_common+0x7f/0xc0 [ 4.576168] [<ffffffff81054786>] warn_slowpath_fmt+0x46/0x50 [ 4.576178] [<ffffffffa00caca3>] read_phy_reg+0x93/0xe0 [firewire_ohci] [ 4.576188] [<ffffffffa00cae19>] ohci_read_phy_reg+0x39/0x60 [firewire_ohci] [ 4.576203] [<ffffffffa00731ff>] fw_send_phy_config+0xbf/0xe0 [firewire_core] [ 4.576214] [<ffffffffa006b2d6>] br_work+0x46/0xb0 [firewire_core] [ 4.576225] [<ffffffff81071e0c>] process_one_work+0x13c/0x500 [ 4.576238] [<ffffffffa006b290>] ? fw_card_initialize+0x180/0x180 [firewire_core] [ 4.576248] [<ffffffff810737ed>] worker_thread+0x16d/0x470 [ 4.576257] [<ffffffff81073680>] ? busy_worker_rebind_fn+0x100/0x100 [ 4.576266] [<ffffffff8107d160>] kthread+0xc0/0xd0 [ 4.576275] [<ffffffff816a0000>] ? pcpu_dump_alloc_info+0x1cb/0x2c4 [ 4.576284] [<ffffffff8107d0a0>] ? kthread_create_on_node+0x130/0x130 [ 4.576297] [<ffffffff816b2f6c>] ret_from_fork+0x7c/0xb0 [ 4.576305] [<ffffffff8107d0a0>] ? kthread_create_on_node+0x130/0x130 [ 4.576313] ---[ end trace cbc940994b300302 ]--- [Stefan R: Peter also reports a change of behavior with LSI FW323. Before the patch, there would often occur a lock transaction failure during firewire-core startup: [ 6.056022] firewire_core 0000:07:06.0: BM lock failed (timeout), making local node (ffc0) root This failure no longer happens after the patch, without an obvious reason for the failure or the fix.] [Stefan R: Added quirk flag, quirk table entry, and comment.] Reported-by: Tim Jordan <tim@insipid.org.uk> Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>		2013-04-30 20:30:15 +02:00
..
accessibility	…
acpi	PCI updates for v3.9:	2013-04-05 19:29:36 -07:00
amba	ARM: 7675/1: amba: tegra-ahb: Fix build error w/ PM_SLEEP w/o PM_RUNTIME	2013-03-15 17:20:02 +00:00
ata	[libata] Fix HDIO_DRIVE_* ioctl() Linux 3.9 regression	2013-04-03 19:48:49 -04:00
atm	…
auxdisplay	…
base	regmap: Back out work buffer fix	2013-04-09 18:03:25 +01:00
bcma	…
block	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client	2013-04-17 12:52:02 -07:00
bluetooth	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth	2013-03-18 15:17:11 -04:00
bus	…
cdrom	…
char	vm: convert HPET mmap to vm_iomap_memory() helper	2013-04-19 09:46:39 -07:00
clk	clk: tegra: Allow PLLE training to succeed	2013-04-01 11:44:38 -07:00
clocksource	…
connector	…
cpufreq	cpufreq / intel_pstate: Set timer timeout correctly	2013-04-08 22:09:23 +02:00
cpuidle	…
crypto	crypto: ux500 - add missing comma	2013-04-05 21:02:17 +08:00
dca	…
devfreq	…
dio	…
dma	dmaengine: at_hdmac: fix race condition in atc_advance_work()	2013-04-18 08:54:22 -07:00
edac	EDAC: Merge mci.mem_is_per_rank with mci.csbased	2013-03-16 06:32:30 +01:00
eisa	EISA/PCI: Init EISA early, before PNP	2013-04-01 12:02:05 -06:00
extcon	extcon: max77693: Initialize register of MUIC device to bring up it without platform data	2013-03-13 17:38:57 +09:00
firewire	firewire: ohci: Fix 'failed to read phy reg' on FW643 rev8	2013-04-30 20:30:15 +02:00
firmware	Move utf16 functions to kernel core and rename	2013-04-15 21:23:03 +01:00
gpio	gpio: pca953x: fix irq_domain_add_simple usage	2013-04-11 19:01:19 +02:00
gpu	drm/fb-helper: Fix locking in drm_fb_helper_hotplug_event	2013-04-12 14:21:12 +10:00
hid	HID: magicmouse: fix race between input_register() and probe()	2013-04-04 09:49:56 +02:00
hsi	…
hv	…
hwmon	hwmon: (lm75.h) Update header inclusion	2013-03-18 21:19:49 +01:00
hwspinlock	hwspinlock: fix __hwspin_lock_request error path	2013-04-05 17:45:11 +03:00
i2c	ACPI / I2C: Use parent's ACPI_HANDLE() in acpi_i2c_register_devices()	2013-04-02 15:30:41 +02:00
ide	…
idle	intel_idle: additional Haswell CPU-id	2013-03-15 10:55:31 -04:00
iio	First round of iio fixes post the 3.9 merge window.	2013-03-06 05:48:24 +08:00
infiniband	firmware,IB/qib: revert firmware file move	2013-04-05 12:19:39 -07:00
input	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2013-04-19 09:15:13 -07:00
iommu	IOMMU fixes for Linux v3.9-rc4	2013-03-27 09:25:11 -07:00
ipack	…
irqchip	irqchip: gic: fix irq_trigger return	2013-03-26 20:52:25 +01:00
isdn	isdn: hisax: netjet requires VIRT_TO_BUS	2013-03-17 12:01:10 -04:00
leds	…
lguest	…
macintosh	…
mailbox	mailbox, pl320-ipc: remove __init from probe function	2013-03-04 14:23:11 +01:00
md	Revert "block: add missing block_bio_complete() tracepoint"	2013-04-18 09:00:26 -07:00
media	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid	2013-04-04 08:40:45 -07:00
memory	…
memstick	…
message	…
mfd	mfd: twl4030-madc: Remove __exit_p annotation	2013-03-15 07:42:22 +01:00
misc	misc/vmw_vmci: Add dependency on CONFIG_NET	2013-04-03 11:53:39 -07:00
mmc	…
mtd	mtdchar: remove no-longer-used vma helpers	2013-04-19 10:05:39 -07:00
net	net: ax88796: avoid 64 bit arithmetic	2013-04-19 17:57:48 -04:00
nfc	NFC: microread: Fix build failure due to a new MEI bus API	2013-04-01 00:52:42 +02:00
ntb	…
nubus	…
of	…
oprofile	fs: Limit sys_mount to only request filesystem modules.	2013-03-03 19:36:31 -08:00
parisc	…
parport	…
pci	PCI/PM: Disable runtime PM of PCIe ports	2013-04-03 15:54:59 -06:00
pcmcia	…
pinctrl	Here are a few pinctrl fixes for the v3.9 rc series:	2013-03-24 10:11:29 -07:00
platform	Merge branch 'for_linus' of git://cavan.codon.org.uk/platform-drivers-x86	2013-04-18 15:14:34 -07:00
pnp	ACPI / glue: Add .match() callback to struct acpi_bus_type	2013-03-04 14:23:40 +01:00
power	…
pps	…
ps3	…
ptp	…
pwm	…
rapidio	…
regulator	Merge remote-tracking branch 'regulator/fix/twl' into tmp	2013-03-05 10:12:43 +08:00
remoteproc	remoteproc: fix FW_CONFIG typo	2013-04-07 15:11:27 +03:00
rpmsg	…
rtc	Revert "drivers/rtc/rtc-at91rm9200.c: use a variable for storing IMR"	2013-04-05 09:36:53 -07:00
s390	qeth: fix qeth_wait_for_threads() deadlock for OSN devices	2013-04-08 17:16:57 -04:00
sbus	bbc_i2c: fix section mismatch warning	2013-03-31 19:29:12 -04:00
scsi	[SCSI] lpfc: fix potential NULL pointer dereference in lpfc_sli4_rq_put()	2013-04-11 14:17:15 -07:00
sfi	…
sh	…
sn	…
spi	spi: Fixes for v3.9	2013-04-05 10:04:41 -07:00
ssb	ssb: implement spurious tone avoidance	2013-04-10 10:31:26 -04:00
staging	staging: comedi: s626: fix continuous acquisition	2013-03-25 11:35:38 -07:00
target	target: Fix incorrect fallthrough of ALUA Standby/Offline/Transition CDBs	2013-04-11 01:48:49 -07:00
tc	…
thermal	thermal: exynos_thermal: return a proper error code while thermal_zone_device_register fail.	2013-03-11 23:09:29 +08:00
tty	tty: mxser: fix cycle termination condition in mxser_probe() and mxser_module_init()	2013-04-08 11:30:04 -07:00
uio	…
usb	USB / PM: Don't try to hide PM QoS flags from usb_port_device_release()	2013-04-02 01:25:09 +02:00
uwb	…
vfio	vfio-pci: Fix possible integer overflow	2013-03-26 11:33:16 -06:00
vhost	Merge git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending	2013-04-12 15:26:42 -07:00
video	vm: convert fb_mmap to vm_iomap_memory() helper	2013-04-19 09:57:35 -07:00
virt	…
virtio	…
vlynq	…
vme	…
w1	w1: fix oops when w1_search is called from netlink connector	2013-03-12 16:20:46 -07:00
watchdog	watchdog: Revert the AT91RM9200_WATCHDOG dependency	2013-04-14 09:09:10 +02:00
xen	Bug-fixes:	2013-04-10 15:57:33 -07:00
zorro	…
Kconfig	…
Makefile	…