Eric Dumazet 2aab4b9690 af_unix: fix struct pid leaks in OOB support ... syzbot reported struct pid leak [1]. Issue is that queue_oob() calls maybe_add_creds() which potentially holds a reference on a pid. But skb->destructor is not set (either directly or by calling unix_scm_to_skb()) This means that subsequent kfree_skb() or consume_skb() would leak this reference. In this fix, I chose to fully support scm even for the OOB message. [1] BUG: memory leak unreferenced object 0xffff8881053e7f80 (size 128): comm "syz-executor242", pid 5066, jiffies 4294946079 (age 13.220s) hex dump (first 32 bytes): 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [<ffffffff812ae26a>] alloc_pid+0x6a/0x560 kernel/pid.c:180 [<ffffffff812718df>] copy_process+0x169f/0x26c0 kernel/fork.c:2285 [<ffffffff81272b37>] kernel_clone+0xf7/0x610 kernel/fork.c:2684 [<ffffffff812730cc>] __do_sys_clone+0x7c/0xb0 kernel/fork.c:2825 [<ffffffff849ad699>] do_syscall_x64 arch/x86/entry/common.c:50 [inline] [<ffffffff849ad699>] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 [<ffffffff84a0008b>] entry_SYSCALL_64_after_hwframe+0x63/0xcd Fixes: 314001f0bf ("af_unix: Add OOB support") Reported-by: syzbot+7699d9e5635c10253a27@syzkaller.appspotmail.com Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Rao Shoaib <rao.shoaib@oracle.com> Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com> Link: https://lore.kernel.org/r/20230307164530.771896-1-edumazet@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2023-03-08 23:26:03 -08:00
..
Kconfig	af_unix: Add OOB support	2021-08-04 09:55:52 +01:00
Makefile	af_unix: Implement ->psock_update_sk_prot()	2021-07-15 18:17:50 -07:00
af_unix.c	af_unix: fix struct pid leaks in OOB support	2023-03-08 23:26:03 -08:00
diag.c	af_unix: Get user_ns from in_skb in unix_diag_get_exact().	2022-12-01 10:32:20 +01:00
garbage.c	io_uring/af_unix: defer registered files gc to io_uring release	2022-10-12 16:30:34 -06:00
scm.c	af_unix: annote lockless accesses to unix_tot_inflight & gc_in_progress	2022-01-14 18:31:37 -08:00
scm.h	…
sysctl_net_unix.c	af_unix: fix unix_sysctl_register() error path	2022-07-09 12:27:33 +01:00
unix_bpf.c	bpf, sockmap: Fix an infinite loop error when len is 0 in tcp_bpf_recvmsg_parser()	2023-03-03 17:25:15 +01:00