Linus Torvalds 8b07022de2 ida: don't use BUG_ON() for debugging ... commit fc82bbf4de upstream. This is another old BUG_ON() that just shouldn't exist (see also commit a382f8fee42c: "signal handling: don't use BUG_ON() for debugging"). In fact, as Matthew Wilcox points out, this condition shouldn't really even result in a warning, since a negative id allocation result is just a normal allocation failure: "I wonder if we should even warn here -- sure, the caller is trying to free something that wasn't allocated, but we don't warn for kfree(NULL)" and goes on to point out how that current error check is only causing people to unnecessarily do their own index range checking before freeing it. This was noted by Itay Iellin, because the bluetooth HCI socket cookie code does *not* do that range checking, and ends up just freeing the error case too, triggering the BUG_ON(). The HCI code requires CAP_NET_RAW, and seems to just result in an ugly splat, but there really is no reason to BUG_ON() here, and we have generally striven for allocation models where it's always ok to just do free(alloc()); even if the allocation were to fail for some random reason (usually obviously that "random" reason being some resource limit). Fixes: 88eca0207c ("ida: simplified functions for id allocation") Reported-by: Itay Iellin <ieitayie@gmail.com> Suggested-by: Matthew Wilcox <willy@infradead.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-07-12 16:35:18 +02:00
..
842	…
crypto	crypto: memneq - move into lib/	2022-06-22 14:22:03 +02:00
dim	dim: initialize all struct fields	2022-05-18 10:26:49 +02:00
fonts	…
kunit	kunit: fix debugfs code to use enum kunit_status, not bool	2022-06-09 10:22:53 +02:00
livepatch	…
lz4	lz4: fix LZ4_decompress_safe_partial read out of bound	2022-04-13 20:59:21 +02:00
lzo	…
math	…
mpi	lib/mpi: Add the return value check of kcalloc()	2022-01-27 11:03:58 +01:00
pldmfw	…
raid6	lib/raid6/test/Makefile: Use $(pound) instead of \# for Make 4.3	2022-04-08 14:23:56 +02:00
reed_solomon	…
vdso	…
xz	lib/xz: Validate the value before assigning it to an enum variable	2021-11-18 19:16:17 +01:00
zlib_deflate	…
zlib_dfltcc	…
zlib_inflate	lib/zlib_inflate/inffast: check config in C to avoid unused function warning	2021-09-24 16:13:35 -07:00
zstd	…
.gitignore	…
Kconfig	crypto: memneq - move into lib/	2022-06-22 14:22:03 +02:00
Kconfig.debug	random: remove ratelimiting for in-kernel unseeded randomness	2022-05-30 09:29:16 +02:00
Kconfig.kasan	kasan: fix Kconfig check of CC_HAS_WORKING_NOSANITIZE_ADDRESS	2021-09-24 16:13:34 -07:00
Kconfig.kcsan	…
Kconfig.kfence	kfence: default to dynamic branch instead of static keys mode	2021-11-12 15:05:49 +01:00
Kconfig.kgdb	…
Kconfig.ubsan	ubsan: remove CONFIG_UBSAN_OBJECT_SIZE	2022-04-13 20:59:27 +02:00
Makefile	crypto: memneq - move into lib/	2022-06-22 14:22:03 +02:00
argv_split.c	…
ashldi3.c	…
ashrdi3.c	…
asn1_decoder.c	…
asn1_encoder.c	…
assoc_array.c	assoc_array: Fix BUG_ON during garbage collect	2022-06-06 08:43:37 +02:00
atomic64.c	…
atomic64_test.c	…
audit.c	…
bcd.c	…
bch.c	…
bitfield_kunit.c	…
bitmap.c	…
bitrev.c	…
bootconfig.c	…
bsearch.c	…
btree.c	…
bucket_locks.c	…
bug.c	…
build_OID_registry	…
buildid.c	…
bust_spinlocks.c	…
check_signature.c	…
checksum.c	…
clz_ctz.c	…
clz_tab.c	…
cmdline.c	…
cmdline_kunit.c	…
cmpdi2.c	…
compat_audit.c	…
cpu_rmap.c	…
cpumask.c	…
crc-ccitt.c	…
crc-itu-t.c	…
crc-t10dif.c	…
crc4.c	…
crc7.c	…
crc8.c	…
crc16.c	…
crc32.c	…
crc32defs.h	…
crc32test.c	…
crc64.c	…
ctype.c	…
debug_info.c	…
debug_locks.c	…
debugobjects.c	…
dec_and_lock.c	…
decompress.c	…
decompress_bunzip2.c	…
decompress_inflate.c	…
decompress_unlz4.c	…
decompress_unlzma.c	…
decompress_unlzo.c	…
decompress_unxz.c	lib/xz: Avoid overlapping memcpy() with invalid input with in-place decompression	2021-11-18 19:16:17 +01:00
decompress_unzstd.c	…
devmem_is_allowed.c	…
devres.c	…
digsig.c	…
dump_stack.c	…
dynamic_debug.c	dyndbg: make dyndbg a known cli param	2021-11-18 19:16:52 +01:00
dynamic_queue_limits.c	…
earlycpio.c	…
errname.c	…
error-inject.c	…
errseq.c	…
extable.c	…
fault-inject-usercopy.c	…
fault-inject.c	…
fdt.c	…
fdt_addresses.c	…
fdt_empty_tree.c	…
fdt_ro.c	…
fdt_rw.c	…
fdt_strerror.c	…
fdt_sw.c	…
fdt_wip.c	…
find_bit.c	…
find_bit_benchmark.c	…
flex_proportions.c	…
gen_crc32table.c	…
gen_crc64table.c	…
genalloc.c	…
generic-radix-tree.c	…
glob.c	…
globtest.c	…
hexdump.c	hex2bin: fix access beyond string end	2022-05-09 09:14:30 +02:00
hweight.c	…
idr.c	ida: don't use BUG_ON() for debugging	2022-07-12 16:35:18 +02:00
inflate.c	…
interval_tree.c	…
interval_tree_test.c	…
iomap.c	…
iomap_copy.c	…
iommu-helper.c	…
iov_iter.c	iov_iter: fix build issue due to possible type mis-match	2022-06-14 18:36:28 +02:00
irq_poll.c	…
irq_regs.c	…
is_single_threaded.c	…
kasprintf.c	…
kfifo.c	…
klist.c	…
kobject.c	…
kobject_uevent.c	…
kstrtox.c	…
kstrtox.h	…
libcrc32c.c	…
linear_ranges.c	…
list-test.c	list: test: Add a test for list_is_head()	2022-06-09 10:23:31 +02:00
list_debug.c	…
list_sort.c	…
llist.c	…
locking-selftest-hardirq.h	…
locking-selftest-mutex.h	…
locking-selftest-rlock-hardirq.h	…
locking-selftest-rlock-softirq.h	…
locking-selftest-rlock.h	…
locking-selftest-rsem.h	…
locking-selftest-rtmutex.h	…
locking-selftest-softirq.h	…
locking-selftest-spin-hardirq.h	…
locking-selftest-spin-softirq.h	…
locking-selftest-spin.h	…
locking-selftest-wlock-hardirq.h	…
locking-selftest-wlock-softirq.h	…
locking-selftest-wlock.h	…
locking-selftest-wsem.h	…
locking-selftest.c	…
lockref.c	…
logic_iomem.c	lib/logic_iomem: correct fallback config references	2022-04-13 20:58:59 +02:00
logic_pio.c	…
lru_cache.c	…
lshrdi3.c	…
memcat_p.c	…
memneq.c	crypto: memneq - move into lib/	2022-06-22 14:22:03 +02:00
memory-notifier-error-inject.c	…
memregion.c	…
memweight.c	…
muldi3.c	…
net_utils.c	…
netdev-notifier-error-inject.c	…
nlattr.c	…
nmi_backtrace.c	printk: restore flushing of NMI buffers on remote CPUs after NMI backtraces	2021-11-25 09:48:45 +01:00
nodemask.c	nodemask: Fix return values to be unsigned	2022-06-14 18:36:24 +02:00
notifier-error-inject.c	…
notifier-error-inject.h	…
objagg.c	…
of-reconfig-notifier-error-inject.c	…
oid_registry.c	…
once.c	…
packing.c	…
parman.c	…
parser.c	…
pci_iomap.c	…
percpu-refcount.c	percpu_ref_init(): clean ->percpu_count_ref on failure	2022-06-06 08:43:36 +02:00
percpu_counter.c	…
percpu_test.c	…
plist.c	…
pm-notifier-error-inject.c	…
radix-tree.c	…
random32.c	random: replace custom notifier chain with standard one	2022-05-30 09:29:10 +02:00
ratelimit.c	…
rbtree.c	…
rbtree_test.c	…
refcount.c	…
rhashtable.c	…
sbitmap.c	…
scatterlist.c	…
seq_buf.c	…
sg_pool.c	…
sg_split.c	…
sha1.c	lib/crypto: sha1: re-roll loops to reduce code size	2022-05-30 09:28:59 +02:00
show_mem.c	…
siphash.c	siphash: use one source of truth for siphash permutations	2022-05-30 09:29:15 +02:00
slub_kunit.c	…
smp_processor_id.c	…
sort.c	…
stackdepot.c	stacktrace: move filter_irq_stacks() to kernel/stacktrace.c	2022-04-13 20:59:28 +02:00
stmp_device.c	…
string.c	…
string_helpers.c	string: uninline memcpy_and_pad	2021-11-21 13:44:12 +01:00
strncpy_from_user.c	…
strnlen_user.c	…
syscall.c	…
test-kstrtox.c	…
test-string_helpers.c	…
test_bitmap.c	…
test_bitops.c	…
test_bits.c	…
test_blackhole_dev.c	…
test_bpf.c	bpf/tests: Fix error in tail call limit tests	2021-11-18 19:16:26 +01:00
test_debug_virtual.c	…
test_firmware.c	…
test_fpu.c	…
test_free_pages.c	…
test_hash.c	…
test_hexdump.c	…
test_hmm.c	mm/hmm.c: allow VM_MIXEDMAP to work with hmm_range_fault	2022-01-27 11:05:43 +01:00
test_hmm_uapi.h	…
test_ida.c	…
test_kasan.c	…
test_kasan_module.c	…
test_kmod.c	lib/test: use after free in register_test_dev_kmod()	2022-04-08 14:23:54 +02:00
test_linear_ranges.c	…
test_list_sort.c	…
test_lockup.c	lib/test_lockup: fix kernel pointer check for separate address spaces	2022-04-08 14:24:01 +02:00
test_memcat_p.c	…
test_meminit.c	lib/test_meminit: destroy cache in kmem_cache_alloc_bulk() test	2022-01-27 11:05:44 +01:00
test_min_heap.c	…
test_module.c	…
test_objagg.c	…
test_overflow.c	…
test_parman.c	…
test_printf.c	…
test_rhashtable.c	…
test_scanf.c	…
test_siphash.c	…
test_sort.c	…
test_stackinit.c	…
test_static_key_base.c	…
test_static_keys.c	…
test_string.c	…
test_strscpy.c	…
test_sysctl.c	…
test_ubsan.c	ubsan: remove CONFIG_UBSAN_OBJECT_SIZE	2022-04-13 20:59:27 +02:00
test_user_copy.c	…
test_uuid.c	…
test_vmalloc.c	…
test_xarray.c	XArray: Fix xas_create_range() when multi-order entry present	2022-04-08 14:24:09 +02:00
textsearch.c	…
timerqueue.c	…
ts_bm.c	…
ts_fsm.c	…
ts_kmp.c	…
ubsan.c	…
ubsan.h	…
ucmpdi2.c	…
ucs2_string.c	…
usercopy.c	…
uuid.c	…
vsprintf.c	random: replace custom notifier chain with standard one	2022-05-30 09:29:10 +02:00
win_minmax.c	…
xarray.c	XArray: Update the LRU list in xas_split()	2022-04-08 14:24:09 +02:00
xxhash.c	…