Jiri Olsa a7b98aa10f bpf: Fix re-attachment branch in bpf_tracing_prog_attach ... commit 715d82ba636cb3629a6e18a33bb9dbe53f9936ee upstream. The following case can cause a crash due to missing attach_btf: 1) load rawtp program 2) load fentry program with rawtp as target_fd 3) create tracing link for fentry program with target_fd = 0 4) repeat 3 In the end we have: - prog->aux->dst_trampoline == NULL - tgt_prog == NULL (because we did not provide target_fd to link_create) - prog->aux->attach_btf == NULL (the program was loaded with attach_prog_fd=X) - the program was loaded for tgt_prog but we have no way to find out which one BUG: kernel NULL pointer dereference, address: 0000000000000058 Call Trace: <TASK> ? __die+0x20/0x70 ? page_fault_oops+0x15b/0x430 ? fixup_exception+0x22/0x330 ? exc_page_fault+0x6f/0x170 ? asm_exc_page_fault+0x22/0x30 ? bpf_tracing_prog_attach+0x279/0x560 ? btf_obj_id+0x5/0x10 bpf_tracing_prog_attach+0x439/0x560 __sys_bpf+0x1cf4/0x2de0 __x64_sys_bpf+0x1c/0x30 do_syscall_64+0x41/0xf0 entry_SYSCALL_64_after_hwframe+0x6e/0x76 Return -EINVAL in this situation. Fixes: f3a9507554 ("bpf: Allow trampoline re-attach for tracing and lsm programs") Cc: stable@vger.kernel.org Signed-off-by: Jiri Olsa <olsajiri@gmail.com> Acked-by: Jiri Olsa <olsajiri@gmail.com> Acked-by: Song Liu <song@kernel.org> Signed-off-by: Dmitrii Dolgov <9erthalion6@gmail.com> Link: https://lore.kernel.org/r/20240103190559.14750-4-9erthalion6@gmail.com Signed-off-by: Alexei Starovoitov <ast@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-01-25 14:52:48 -08:00
..
bpf	bpf: Fix re-attachment branch in bpf_tracing_prog_attach	2024-01-25 14:52:48 -08:00
cgroup	cgroup: Remove duplicates in cgroup v1 tasks file	2023-10-19 23:05:37 +02:00
configs	…
debug	kgdb: Flush console before entering kgdb on panic	2023-11-28 16:56:20 +00:00
dma	dma-mapping: clear dev->dma_mem to NULL after freeing it	2024-01-25 14:52:38 -08:00
entry	entry/rcu: Check TIF_RESCHED _after_ delayed RCU wake-up	2023-03-30 12:47:51 +02:00
events	perf: Fix perf_event_validate_size() lockdep splat	2023-12-20 15:17:41 +01:00
futex	futex: Don't include process MM in futex key on no-MMU	2023-11-20 11:08:13 +01:00
gcov	gcov: add support for checksum field	2022-12-31 13:14:47 +01:00
irq	genirq/generic_chip: Make irq_remove_generic_chip() irqdomain aware	2023-11-28 16:56:30 +00:00
kcsan	kcsan: Don't expect 64 bits atomic builtins from 32 bits architectures	2023-07-23 13:47:12 +02:00
livepatch	livepatch: Fix missing newline character in klp_resolve_symbols()	2023-11-20 11:08:25 +01:00
locking	lockdep: Fix block chain corruption	2023-12-03 07:31:23 +01:00
power	PM: hibernate: Clean up sync_read handling in snapshot_write_next()	2023-11-28 16:56:29 +00:00
printk	printk: Consolidate console deferred printing	2023-09-23 11:09:59 +02:00
rcu	rcu: Avoid tracing a few functions executed in stop machine	2023-12-08 08:48:02 +01:00
sched	sched: Fix stop_one_cpu_nowait() vs hotplug	2023-11-20 11:08:13 +01:00
time	tick-sched: Fix idle and iowait sleeptime accounting vs CPU hotplug	2024-01-25 14:52:46 -08:00
trace	ring-buffer: Do not record in NMI if the arch does not support cmpxchg in NMI	2024-01-25 14:52:30 -08:00
.gitignore	…
Kconfig.freezer	…
Kconfig.hz	…
Kconfig.locks	…
Kconfig.preempt	…
Makefile	futex: Move to kernel/futex/	2022-12-31 13:14:04 +01:00
acct.c	acct: fix potential integer overflow in encode_comp_t()	2022-12-31 13:14:40 +01:00
async.c	Revert "module, async: async_synchronize_full() on module init iff async is used"	2022-02-23 12:03:07 +01:00
audit.c	audit: improve audit queue handling when "audit=1" on cmdline	2022-02-08 18:34:03 +01:00
audit.h	audit: log AUDIT_TIME_* records only from rules	2022-04-08 14:23:06 +02:00
audit_fsnotify.c	audit: fix potential double free on error path from fsnotify_add_inode_mark	2022-08-31 17:16:33 +02:00
audit_tree.c	…
audit_watch.c	audit: don't WARN_ON_ONCE(!current->mm) in audit_exe_compare()	2023-11-28 16:56:27 +00:00
auditfilter.c	…
auditsc.c	audit: fix possible soft lockup in __audit_inode_child()	2023-09-19 12:22:39 +02:00
backtracetest.c	…
bounds.c	…
capability.c	…
cfi.c	cfi: Fix __cfi_slowpath_diag RCU usage with cpuidle	2022-06-22 14:22:04 +02:00
compat.c	sched_getaffinity: don't assume 'cpumask_size()' is fully initialized	2023-04-05 11:24:53 +02:00
configs.c	…
context_tracking.c	…
cpu.c	hrtimers: Push pending hrtimers away from outgoing CPU earlier	2023-12-13 18:36:31 +01:00
cpu_pm.c	…
crash_core.c	kernel/crash_core: suppress unknown crashkernel parameter warning	2021-12-29 12:28:49 +01:00
crash_dump.c	…
cred.c	cred: switch to using atomic_long_t	2023-12-20 15:17:37 +01:00
delayacct.c	…
dma.c	…
exec_domain.c	…
exit.c	exit: Use READ_ONCE() for all oops/warn limit reads	2023-02-01 08:27:22 +01:00
extable.c	…
fail_function.c	kernel/fail_function: fix memory leak with using debugfs_lookup()	2023-03-11 13:57:38 +01:00
fork.c	kernel/fork: beware of __put_task_struct() calling context	2023-09-23 11:09:55 +02:00
freezer.c	…
gen_kheaders.sh	…
groups.c	…
hung_task.c	…
iomem.c	…
irq_work.c	…
jump_label.c	…
kallsyms.c	kallsyms: Make kallsyms_on_each_symbol generally available	2023-12-13 18:36:45 +01:00
kcmp.c	…
kcov.c	…
kexec.c	kernel: kexec: copy user-array safely	2023-11-28 16:56:16 +00:00
kexec_core.c	kexec: fix a memory leak in crash_shrink_memory()	2023-07-23 13:46:52 +02:00
kexec_elf.c	…
kexec_file.c	kexec: support purgatories with .text.hot sections	2023-06-21 15:59:14 +02:00
kexec_internal.h	panic, kexec: make __crash_kexec() NMI safe	2023-04-20 12:13:57 +02:00
kheaders.c	kheaders: Use array declaration instead of char	2023-05-11 23:00:17 +09:00
kmod.c	…
kprobes.c	kprobes: Fix to handle forcibly unoptimized kprobes on freeing_list	2024-01-25 14:52:31 -08:00
ksysfs.c	kexec: turn all kexec_mutex acquisitions into trylocks	2023-04-20 12:13:57 +02:00
kthread.c	kthread: add the helper function kthread_run_on_cpu()	2023-03-30 12:47:42 +02:00
latencytop.c	…
module-internal.h	…
module.c	kallsyms: Make module_kallsyms_on_each_symbol generally available	2024-01-15 18:51:26 +01:00
module_signature.c	…
module_signing.c	…
notifier.c	…
nsproxy.c	…
padata.c	crypto: pcrypt - Fix hungtask for PADATA_RESET	2023-11-28 16:56:18 +00:00
panic.c	exit: Use READ_ONCE() for all oops/warn limit reads	2023-02-01 08:27:22 +01:00
params.c	…
pid.c	…
pid_namespace.c	rcu-tasks: Fix synchronize_rcu_tasks() VS zap_pid_ns_processes()	2023-03-10 09:39:09 +01:00
profile.c	profiling: fix shift too large makes kernel panic	2022-08-17 14:24:04 +02:00
ptrace.c	ptrace: Reimplement PTRACE_KILL by always sending SIGKILL	2022-06-09 10:22:29 +02:00
range.c	…
reboot.c	kernel/reboot: emergency_restart: Set correct system_state	2023-11-28 16:56:31 +00:00
regset.c	…
relay.c	relayfs: fix out-of-bounds access in relay_file_read	2023-05-11 23:00:18 +09:00
resource.c	dax/kmem: Fix leak of memory-hotplug resources	2023-03-10 09:40:08 +01:00
resource_kunit.c	…
rseq.c	rseq: Remove broken uapi field layout on 32-bit little endian	2022-04-08 14:23:10 +02:00
scftorture.c	scftorture: Forgive memory-allocation failure if KASAN	2023-09-23 11:09:55 +02:00
scs.c	scs: Release kasan vmalloc poison in scs_free process	2021-11-18 19:16:29 +01:00
seccomp.c	seccomp: Invalidate seccomp mode to catch death failures	2022-02-16 12:56:38 +01:00
signal.c	signal handling: don't use BUG_ON() for debugging	2022-07-21 21:24:42 +02:00
smp.c	locking/csd_lock: Change csdlock_debug from early_param to __setup	2022-08-17 14:24:24 +02:00
smpboot.c	…
smpboot.h	…
softirq.c	timers/nohz: Last resort update jiffies on nohz_full IRQ entry	2023-08-16 18:22:04 +02:00
stackleak.c	gcc-plugins/stackleak: Use noinstr in favor of notrace	2022-02-23 12:03:07 +01:00
stacktrace.c	stacktrace: move filter_irq_stacks() to kernel/stacktrace.c	2022-04-13 20:59:28 +02:00
static_call.c	static_call: Don't make __static_call_return0 static	2022-04-13 20:59:28 +02:00
static_call_inline.c	static_call: Don't make __static_call_return0 static	2022-04-13 20:59:28 +02:00
stop_machine.c	…
sys.c	kernel/sys.c: fix and improve control flow in __sys_setres[ug]id()	2023-04-26 13:51:52 +02:00
sys_ni.c	kernel/sys_ni: add compat entry for fadvise64_64	2022-08-31 17:16:33 +02:00
sysctl-test.c	…
sysctl.c	kernel/panic: move panic sysctls to its own file	2023-02-01 08:27:20 +01:00
task_work.c	…
taskstats.c	…
test_kprobes.c	…
torture.c	torture: Fix hang during kthread shutdown phase	2023-08-30 16:18:19 +02:00
tracepoint.c	…
tsacct.c	taskstats: Cleanup the use of task->exit_code	2022-01-27 11:05:35 +01:00
ucount.c	ucounts: Handle wrapping in is_ucounts_overlimit	2022-02-23 12:03:20 +01:00
uid16.c	…
uid16.h	…
umh.c	…
up.c	…
user-return-notifier.c	…
user.c	…
user_namespace.c	ucounts: Fix systemd LimitNPROC with private users regression	2022-03-08 19:12:42 +01:00
usermode_driver.c	…
utsname.c	…
utsname_sysctl.c	…
watch_queue.c	kernel: watch_queue: copy user-array safely	2023-11-28 16:56:16 +00:00
watchdog.c	watchdog: move softlockup_panic back to early_param	2023-11-28 16:56:28 +00:00
watchdog_hld.c	watchdog/perf: more properly prevent false positives with turbo modes	2023-07-23 13:46:52 +02:00
workqueue.c	Revert "workqueue: remove unused cancel_work()"	2023-12-08 08:48:03 +01:00
workqueue_internal.h	…