WSL2-Linux-Kernel/net/9p
Fedor Pchelkin 4431cf7c33 net: 9p: avoid freeing uninit memory in p9pdu_vreadf
commit ff49bf1867578f23a5ffdd38f927f6e1e16796c4 upstream.

If some of p9pdu_readf() calls inside case 'T' in p9pdu_vreadf() fails,
the error path is not handled properly. *wnames or members of *wnames
array may be left uninitialized and invalidly freed.

Initialize *wnames to NULL in beginning of case 'T'. Initialize the first
*wnames array element to NULL and nullify the failing *wnames element so
that the error path freeing loop stops on the first NULL element and
doesn't proceed further.

Found by Linux Verification Center (linuxtesting.org).

Fixes: ace51c4dd2 ("9p: add new protocol support code")
Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Message-ID: <20231206200913.16135-1-pchelkin@ispras.ru>
Cc: stable@vger.kernel.org
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Christian Schoenebeck <linux_oss@crudebyte.com>
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-01-05 15:13:34 +01:00
..
Kconfig net: remove redundant 'depends on NET' 2021-01-27 17:04:12 -08:00
Makefile 9p: Remove p9_idpool 2018-08-29 13:39:57 +09:00
client.c 9p: v9fs_listxattr: fix %s null argument warning 2023-11-28 16:56:19 +00:00
error.c 9p: fix a bunch of checkpatch warnings 2022-08-17 14:24:07 +02:00
mod.c 9p: fix a bunch of checkpatch warnings 2022-08-17 14:24:07 +02:00
protocol.c net: 9p: avoid freeing uninit memory in p9pdu_vreadf 2024-01-05 15:13:34 +01:00
protocol.h 9p: fix a bunch of checkpatch warnings 2022-08-17 14:24:07 +02:00
trans_common.c net: 9p: Fix kerneldoc warnings of missing parameters etc 2020-11-02 12:25:52 -08:00
trans_common.h 9p: fix a bunch of checkpatch warnings 2022-08-17 14:24:07 +02:00
trans_fd.c 9p/trans_fd: Annotate data-racy writes to file::f_flags 2023-11-28 16:56:19 +00:00
trans_rdma.c 9p/rdma: unmap receive dma buffer in rdma_request()/post_recv() 2023-03-11 13:57:29 +01:00
trans_virtio.c 9p: virtio: make sure 'offs' is initialized in zc_request 2023-09-19 12:22:27 +02:00
trans_xen.c 9p/xen : Fix use after free bug in xen_9pfs_front_remove due to race condition 2023-04-20 12:13:53 +02:00