WSL2-Linux-Kernel/drivers/virtio
Murilo Opsfelder Araujo 870179c053 virtio-pci: Remove wrong address verification in vp_del_vqs()
commit 7e415282b4 upstream.

GCC 12 enhanced -Waddress when comparing array address to null [0],
which warns:

    drivers/virtio/virtio_pci_common.c: In function ‘vp_del_vqs’:
    drivers/virtio/virtio_pci_common.c:257:29: warning: the comparison will always evaluate as ‘true’ for the pointer operand in ‘vp_dev->msix_affinity_masks + (sizetype)((long unsigned int)i * 256)’ must not be NULL [-Waddress]
      257 |                         if (vp_dev->msix_affinity_masks[i])
          |                             ^~~~~~

In fact, the verification is comparing the result of a pointer
arithmetic, the address "msix_affinity_masks + i", which will always
evaluate to true.

Under the hood, free_cpumask_var() calls kfree(), which is safe to pass
NULL, not requiring non-null verification.  So remove the verification
to make compiler happy (happy compiler, happy life).

[0] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102103

Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
Message-Id: <20220415023002.49805-1-muriloo@linux.ibm.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Christophe de Dinechin <dinechin@redhat.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-06-22 14:22:05 +02:00
..
Kconfig virtio-pci: introduce modern device module 2021-02-23 07:52:58 -05:00
Makefile virtio-pci: introduce modern device module 2021-02-23 07:52:58 -05:00
virtio.c virtio: acknowledge all features before access 2022-03-16 14:23:43 +01:00
virtio_balloon.c virtio-balloon: Use virtio_find_vqs() helper 2021-09-06 07:20:56 -04:00
virtio_dma_buf.c virtio: fix build for configs without dma-bufs 2020-08-19 06:43:28 +02:00
virtio_input.c virtio-input: add multi-touch support 2021-02-23 07:52:59 -05:00
virtio_mem.c virtio/virtio_mem: handle a possible NULL as a memcpy parameter 2022-01-27 11:02:59 +01:00
virtio_mmio.c virtio-mmio: fix missing put_device() when vm_cmdline_parent registration failed 2022-06-22 14:21:58 +02:00
virtio_pci_common.c virtio-pci: Remove wrong address verification in vp_del_vqs() 2022-06-22 14:22:05 +02:00
virtio_pci_common.h virtio-pci: introduce modern device module 2021-02-23 07:52:58 -05:00
virtio_pci_legacy.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 78 2019-05-24 17:37:51 +02:00
virtio_pci_modern.c virtio_pci_modern: __force cast the notify mapping 2021-05-04 04:19:58 -04:00
virtio_pci_modern_dev.c virtio: pci: Fix an error handling path in vp_modern_probe() 2022-06-14 18:36:12 +02:00
virtio_ring.c virtio_ring: mark ring unused on error 2022-01-27 11:05:35 +01:00
virtio_vdpa.c virtio_vdpa: reject invalid vq indices 2021-08-11 06:44:23 -04:00