Kees Cook 5a9d05a4f1 Bluetooth: hci_sock: Correctly bounds check and pad HCI_MON_NEW_INDEX name ... commit cb3871b1cd upstream. The code pattern of memcpy(dst, src, strlen(src)) is almost always wrong. In this case it is wrong because it leaves memory uninitialized if it is less than sizeof(ni->name), and overflows ni->name when longer. Normally strtomem_pad() could be used here, but since ni->name is a trailing array in struct hci_mon_new_index, compilers that don't support -fstrict-flex-arrays=3 can't tell how large this array is via __builtin_object_size(). Instead, open-code the helper and use sizeof() since it will work correctly. Additionally mark ni->name as __nonstring since it appears to not be a %NUL terminated C string. Cc: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Cc: Edward AD <twuufnxlz@gmail.com> Cc: Marcel Holtmann <marcel@holtmann.org> Cc: Johan Hedberg <johan.hedberg@gmail.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Eric Dumazet <edumazet@google.com> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Paolo Abeni <pabeni@redhat.com> Cc: linux-bluetooth@vger.kernel.org Cc: netdev@vger.kernel.org Fixes: 18f547f3fc ("Bluetooth: hci_sock: fix slab oob read in create_monitor_event") Link: https://lore.kernel.org/lkml/202310110908.F2639D3276@keescook/ Signed-off-by: Kees Cook <keescook@chromium.org> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-10-25 11:59:04 +02:00
..
bluetooth.h	Bluetooth: Fix bt_skb_sendmmsg not allocating partial chunks	2022-07-29 17:25:30 +02:00
hci.h	Bluetooth: add quirk disabling LE Read Transmit Power	2022-01-16 09:12:44 +01:00
hci_core.h	Bluetooth: hci_core: Fix build warnings	2023-10-25 11:59:00 +02:00
hci_mon.h	Bluetooth: hci_sock: Correctly bounds check and pad HCI_MON_NEW_INDEX name	2023-10-25 11:59:04 +02:00
hci_sock.h	Bluetooth: Use only 8 bits for the HCI CMSG state flags	2020-06-12 15:10:46 +02:00
l2cap.h	Bluetooth: L2CAP: Fix use-after-free caused by l2cap_chan_put	2022-08-03 12:03:40 +02:00
mgmt.h	Bluetooth: use inclusive language in SMP	2021-06-26 07:12:37 +02:00
rfcomm.h	Bluetooth: Replace zero-length array with flexible-array member	2020-02-28 08:30:02 +01:00
sco.h	Bluetooth: Add support for BT_PKT_STATUS CMSG data for SCO connections	2020-06-12 15:08:49 +02:00