Herbert Xu 4906f9985e bridge: Fix LRO crash with tun ... > Kernel BUG at drivers/net/tun.c:444 > invalid opcode: 0000 [1] SMP > last sysfs file: /class/net/lo/ifindex > CPU 0 > Modules linked in: tun ipt_MASQUERADE iptable_nat ip_nat xt_state ip_conntrack > nfnetlink ipt_REJECT xt_tcpudp iptable_filter d > Pid: 6912, comm: qemu-kvm Tainted: G 2.6.18-128.el5 #1 > RIP: 0010:[<ffffffff886f57b0>] [<ffffffff886f57b0>] > :tun:tun_chr_readv+0x2b1/0x3a6 > RSP: 0018:ffff8102202c5e48 EFLAGS: 00010246 > RAX: 0000000000000000 RBX: ffff8102202c5e98 RCX: 0000000004010000 > RDX: ffff810227063680 RSI: ffff8102202c5e9e RDI: ffff8102202c5e92 > RBP: 0000000000010ff6 R08: 0000000000000000 R09: 0000000000000001 > R10: ffff8102202c5e94 R11: 0000000000000202 R12: ffff8102275357c0 > R13: ffff81022755e500 R14: 0000000000000000 R15: ffff8102202c5ef8 > FS: 00002ae4398db980(0000) GS:ffffffff803ac000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b > CR2: 00002ae4ab514000 CR3: 0000000221344000 CR4: 00000000000026e0 > Process qemu-kvm (pid: 6912, threadinfo ffff8102202c4000, task > ffff81022e58d820) > Stack: 00000000498735cb ffff810229d1a3c0 0000000000000000 ffff81022e58d820 > ffffffff8008a461 ffff81022755e528 ffff81022755e528 ffffffff8009f925 > 000005ea05ea0000 ffff8102209d0000 00001051143e1600 ffffffff8003c00e > Call Trace: > [<ffffffff8008a461>] default_wake_function+0x0/0xe > [<ffffffff8009f925>] enqueue_hrtimer+0x55/0x70 > [<ffffffff8003c00e>] hrtimer_start+0xbc/0xce > [<ffffffff886f58bf>] :tun:tun_chr_read+0x1a/0x1f > [<ffffffff8000b3f3>] vfs_read+0xcb/0x171 > [<ffffffff800117d4>] sys_read+0x45/0x6e > [<ffffffff8005d116>] system_call+0x7e/0x83 > > > Code: 0f 0b 68 40 62 6f 88 c2 bc 01 f6 42 0a 08 74 0c 80 4c 24 41 > RIP [<ffffffff886f57b0>] :tun:tun_chr_readv+0x2b1/0x3a6 > RSP <ffff8102202c5e48> > <0>Kernel panic - not syncing: Fatal exception This crashed when an LRO packet generated by bnx2x reached a tun device through the bridge. We're supposed to drop it at the bridge. However, because the check was placed in br_forward instead of __br_forward, it's only effective if we are sending the packet through a single port. This patch fixes it by moving the check into __br_forward. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: David S. Miller <davem@davemloft.net>		2009-02-09 15:07:18 -08:00
..
netfilter	netfilter 05/09: ebtables: fix inversion in match code	2009-01-12 21:18:35 -08:00
Kconfig	bridge: Use STP demux	2008-07-05 21:25:56 -07:00
Makefile	[BRIDGE]: netlink interface for link management	2006-06-17 21:26:14 -07:00
br.c	netns bridge: cleanup bridges during netns stop	2008-09-08 16:20:18 -07:00
br_device.c	netdev: add more functions to netdevice ops	2008-11-20 20:14:53 -08:00
br_fdb.c	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/torvalds/linux-2.6	2008-07-18 02:39:39 -07:00
br_forward.c	bridge: Fix LRO crash with tun	2009-02-09 15:07:18 -08:00
br_if.c	netdev: add more functions to netdevice ops	2008-11-20 20:14:53 -08:00
br_input.c	bridge: handle process all link-local frames	2008-06-17 16:09:45 -07:00
br_ioctl.c	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/torvalds/linux-2.6	2008-09-08 16:59:05 -07:00
br_netfilter.c	netfilter 03/09: bridge: Disable PPPOE/VLAN processing by default	2009-01-12 21:18:34 -08:00
br_netlink.c	netns bridge: allow bridges in netns!	2008-09-08 16:19:58 -07:00
br_notify.c	netns bridge: allow bridges in netns!	2008-09-08 16:19:58 -07:00
br_private.h	netns bridge: cleanup bridges during netns stop	2008-09-08 16:20:18 -07:00
br_private_stp.h	net: remove CVS keywords	2008-06-11 21:00:38 -07:00
br_stp.c	bridge: Eliminate unnecessary forward delay	2008-08-05 18:42:51 -07:00
br_stp_bpdu.c	netns bridge: allow bridges in netns!	2008-09-08 16:19:58 -07:00
br_stp_if.c	bridge: make bridge address settings sticky	2008-06-17 16:10:06 -07:00
br_stp_timer.c	net: remove CVS keywords	2008-06-11 21:00:38 -07:00
br_sysfs_br.c	netdevice: safe convert to netdev_priv() #part-4	2008-11-12 23:39:10 -08:00
br_sysfs_if.c	Kobject: change net/bridge to use kobject_create_and_add	2008-01-24 20:40:26 -08:00