Lukas Wunner ddf75be47c spi: Prevent adding devices below an unregistering controller ... CONFIG_OF_DYNAMIC and CONFIG_ACPI allow adding SPI devices at runtime using a DeviceTree overlay or DSDT patch. CONFIG_SPI_SLAVE allows the same via sysfs. But there are no precautions to prevent adding a device below a controller that's being removed. Such a device is unusable and may not even be able to unbind cleanly as it becomes inaccessible once the controller has been torn down. E.g. it is then impossible to quiesce the device's interrupt. of_spi_notify() and acpi_spi_notify() do hold a ref on the controller, but otherwise run lockless against spi_unregister_controller(). Fix by holding the spi_add_lock in spi_unregister_controller() and bailing out of spi_add_device() if the controller has been unregistered concurrently. Fixes: ce79d54ae4 ("spi/of: Add OF notifier handler") Signed-off-by: Lukas Wunner <lukas@wunner.de> Cc: stable@vger.kernel.org # v3.19+ Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Octavian Purdila <octavian.purdila@intel.com> Cc: Pantelis Antoniou <pantelis.antoniou@konsulko.com> Link: https://lore.kernel.org/r/a8c3205088a969dc8410eec1eba9aface60f36af.1596451035.git.lukas@wunner.de Signed-off-by: Mark Brown <broonie@kernel.org>		2020-08-03 16:50:43 +01:00
..
accessibility	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
acpi	libnvdimm for 5.8	2020-06-13 13:04:36 -07:00
amba	…
android	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
ata	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
atm	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
auxdisplay	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
base	…
bcma	…
block	Kbuild updates for v5.8 (2nd)	2020-06-13 13:29:16 -07:00
bluetooth	…
bus	…
cdrom	Merge branch 'work.sysctl' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2020-06-10 16:05:54 -07:00
char	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
clk	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
clocksource	…
connector	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
counter	…
cpufreq	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
cpuidle	- Add the hwmon support on the i.MX SC (Anson Huang)	2020-06-12 14:10:21 -07:00
crypto	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-06-13 16:27:13 -07:00
dax	…
dca	…
devfreq	…
dio	…
dma	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
dma-buf	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
edac	Kbuild updates for v5.8 (2nd)	2020-06-13 13:29:16 -07:00
eisa	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
extcon	…
firewire	…
firmware	Kbuild updates for v5.8 (2nd)	2020-06-13 13:29:16 -07:00
fpga	…
fsi	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
gnss	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
gpio	spi: ppc4xx: Convert to use GPIO descriptors	2020-07-22 01:55:52 +01:00
gpu	Kbuild updates for v5.8 (2nd)	2020-06-13 13:29:16 -07:00
greybus	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
hid	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
hsi	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
hv	…
hwmon	Merge branch 'x86/entry' into ras/core	2020-06-11 15:17:57 +02:00
hwspinlock	…
hwtracing	…
i2c	Kbuild updates for v5.8 (2nd)	2020-06-13 13:29:16 -07:00
i3c	…
ide	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
idle	…
iio	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
infiniband	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
input	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
interconnect	…
iommu	Kbuild updates for v5.8 (2nd)	2020-06-13 13:29:16 -07:00
ipack	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
irqchip	…
isdn	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
leds	…
lightnvm	…
macintosh	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
mailbox	mailbox: qcom: Add ipq6018 apcs compatible	2020-06-10 22:43:57 -05:00
mcb	…
md	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
media	Kbuild updates for v5.8 (2nd)	2020-06-13 13:29:16 -07:00
memory	memory: add Renesas RPC-IF driver	2020-07-01 22:45:14 +01:00
memstick	…
message	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
mfd	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
misc	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
mmc	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
most	…
mtd	spi: Move cadence-quadspi driver to drivers/spi/	2020-06-19 14:26:54 +01:00
mux	…
net	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-06-13 16:27:13 -07:00
nfc	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
ntb	…
nubus	…
nvdimm	libnvdimm for 5.8	2020-06-13 13:04:36 -07:00
nvme	Kbuild updates for v5.8 (2nd)	2020-06-13 13:29:16 -07:00
nvmem	…
of	…
opp	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
oprofile	…
parisc	…
parport	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
pci	Kbuild updates for v5.8 (2nd)	2020-06-13 13:29:16 -07:00
pcmcia	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
perf	arm64 merge window fixes for -rc1	2020-06-11 12:53:23 -07:00
phy	…
pinctrl	…
platform	Kbuild updates for v5.8 (2nd)	2020-06-13 13:29:16 -07:00
pnp	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
power	…
powercap	Kbuild updates for v5.8 (2nd)	2020-06-13 13:29:16 -07:00
pps	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
ps3	…
ptp	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
pwm	…
rapidio	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
ras	…
regulator	…
remoteproc	…
reset	…
rpmsg	…
rtc	…
s390	…
sbus	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
scsi	Kbuild updates for v5.8 (2nd)	2020-06-13 13:29:16 -07:00
sfi	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
sh	…
siox	…
slimbus	…
soc	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
soundwire	…
spi	spi: Prevent adding devices below an unregistering controller	2020-08-03 16:50:43 +01:00
spmi	…
ssb	…
staging	Kbuild updates for v5.8 (2nd)	2020-06-13 13:29:16 -07:00
target	Kbuild updates for v5.8 (2nd)	2020-06-13 13:29:16 -07:00
tc	…
tee	…
thermal	- Add the hwmon support on the i.MX SC (Anson Huang)	2020-06-12 14:10:21 -07:00
thunderbolt	…
tty	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
uio	…
usb	Kbuild updates for v5.8 (2nd)	2020-06-13 13:29:16 -07:00
vdpa	…
vfio	kernel: better document the use_mm/unuse_mm API contract	2020-06-10 19:14:18 -07:00
vhost	Kbuild updates for v5.8 (2nd)	2020-06-13 13:29:16 -07:00
video	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
virt	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
virtio	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
visorbus	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
vlynq	…
vme	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
w1	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
watchdog	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
xen	The X86 entry, exception and interrupt code rework	2020-06-13 10:05:47 -07:00
zorro	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
Kconfig	…
Makefile	…