Christophe Leroy 311eab8d59 tty: serial: cpm_uart: Fix behaviour for non existing GPIOs ... devm_gpiod_get_index() doesn't return NULL but -ENOENT when the requested GPIO doesn't exist, leading to the following messages: [ 2.742468] gpiod_direction_input: invalid GPIO (errorpointer) [ 2.748147] can't set direction for gpio #2: -2 [ 2.753081] gpiod_direction_input: invalid GPIO (errorpointer) [ 2.758724] can't set direction for gpio #3: -2 [ 2.763666] gpiod_direction_output: invalid GPIO (errorpointer) [ 2.769394] can't set direction for gpio #4: -2 [ 2.774341] gpiod_direction_input: invalid GPIO (errorpointer) [ 2.779981] can't set direction for gpio #5: -2 [ 2.784545] ff000a20.serial: ttyCPM1 at MMIO 0xfff00a20 (irq = 39, base_baud = 8250000) is a CPM UART Use devm_gpiod_get_index_optional() instead. At the same time, handle the error case and properly exit with an error. Fixes: 97cbaf2c82 ("tty: serial: cpm_uart: Convert to use GPIO descriptors") Cc: stable@vger.kernel.org Cc: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Link: https://lore.kernel.org/r/694a25fdce548c5ee8b060ef6a4b02746b8f25c0.1591986307.git.christophe.leroy@csgroup.eu Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2020-06-27 13:50:51 +02:00
..
Makefile	tty: add SPDX identifiers to Kconfig and Makefiles	2019-04-04 18:48:43 +02:00
cpm_uart.h	tty: serial: Use the correct style for SPDX License Identifier	2020-03-07 09:52:01 +01:00
cpm_uart_core.c	tty: serial: cpm_uart: Fix behaviour for non existing GPIOs	2020-06-27 13:50:51 +02:00
cpm_uart_cpm1.c	mm: remove include/linux/bootmem.h	2018-10-31 08:54:16 -07:00
cpm_uart_cpm1.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
cpm_uart_cpm2.c	mm: remove include/linux/bootmem.h	2018-10-31 08:54:16 -07:00
cpm_uart_cpm2.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00