Linus Torvalds fc82bbf4de ida: don't use BUG_ON() for debugging ... This is another old BUG_ON() that just shouldn't exist (see also commit a382f8fee42c: "signal handling: don't use BUG_ON() for debugging"). In fact, as Matthew Wilcox points out, this condition shouldn't really even result in a warning, since a negative id allocation result is just a normal allocation failure: "I wonder if we should even warn here -- sure, the caller is trying to free something that wasn't allocated, but we don't warn for kfree(NULL)" and goes on to point out how that current error check is only causing people to unnecessarily do their own index range checking before freeing it. This was noted by Itay Iellin, because the bluetooth HCI socket cookie code does *not* do that range checking, and ends up just freeing the error case too, triggering the BUG_ON(). The HCI code requires CAP_NET_RAW, and seems to just result in an ugly splat, but there really is no reason to BUG_ON() here, and we have generally striven for allocation models where it's always ok to just do free(alloc()); even if the allocation were to fail for some random reason (usually obviously that "random" reason being some resource limit). Fixes: 88eca0207c ("ida: simplified functions for id allocation") Reported-by: Itay Iellin <ieitayie@gmail.com> Suggested-by: Matthew Wilcox <willy@infradead.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2022-07-10 13:55:49 -07:00
..
842	…
crypto	crypto: memneq - move into lib/	2022-06-12 14:51:51 +08:00
dim	dim: initialize all struct fields	2022-05-09 17:20:37 -07:00
fonts	…
kunit	kunit: fix executor OOM error handling logic on non-UML	2022-05-17 10:01:40 -06:00
livepatch	…
lz4	lz4: fix LZ4_decompress_safe_partial read out of bound	2022-04-08 14:20:36 -10:00
lzo	…
math	…
mpi	…
pldmfw	…
raid6	…
reed_solomon	…
test_fortify	…
vdso	…
xz	…
zlib_deflate	…
zlib_dfltcc	…
zlib_inflate	…
zstd	…
.gitignore	bootconfig: Support embedding a bootconfig file in kernel	2022-04-26 17:58:51 -04:00
Kconfig	crypto: memneq - move into lib/	2022-06-12 14:51:51 +08:00
Kconfig.debug	cxl for 5.19	2022-05-27 21:24:19 -07:00
Kconfig.kasan	kasan: clean-up kconfig options descriptions	2022-05-13 07:20:19 -07:00
Kconfig.kcsan	objtool: Make noinstr hacks optional	2022-04-22 12:32:04 +02:00
Kconfig.kfence	kfence: allow use of a deferrable timer	2022-03-22 15:57:11 -07:00
Kconfig.kgdb	…
Kconfig.ubsan	objtool: Fix obsolete reference to CONFIG_X86_SMAP	2022-06-06 11:49:55 -07:00
Makefile	crypto: memneq - move into lib/	2022-06-12 14:51:51 +08:00
argv_split.c	…
ashldi3.c	…
ashrdi3.c	…
asn1_decoder.c	…
asn1_encoder.c	…
assoc_array.c	assoc_array: Fix BUG_ON during garbage collect	2022-06-01 18:29:06 -07:00
atomic64.c	…
atomic64_test.c	…
audit.c	…
bcd.c	…
bch.c	…
bitfield_kunit.c	…
bitmap.c	bitmap: Fix return values to be unsigned	2022-06-03 06:52:58 -07:00
bitrev.c	…
bootconfig-data.S	bootconfig: Support embedding a bootconfig file in kernel	2022-04-26 17:58:51 -04:00
bootconfig.c	bootconfig: Support embedding a bootconfig file in kernel	2022-04-26 17:58:51 -04:00
bsearch.c	…
btree.c	…
bucket_locks.c	…
bug.c	bug: Use normal relative pointers in 'struct bug_entry'	2022-05-19 23:46:10 +02:00
build_OID_registry	…
buildid.c	…
bust_spinlocks.c	…
check_signature.c	…
checksum.c	…
clz_ctz.c	…
clz_tab.c	…
cmdline.c	…
cmdline_kunit.c	…
cmpdi2.c	…
compat_audit.c	…
cpu_rmap.c	…
cpumask.c	…
crc-ccitt.c	…
crc-itu-t.c	crc-itu-t: fix typo in CRC ITU-T polynomial comment	2022-06-07 10:27:38 +02:00
crc-t10dif.c	…
crc4.c	…
crc7.c	…
crc8.c	…
crc16.c	…
crc32.c	…
crc32defs.h	…
crc32test.c	…
crc64-rocksoft.c	…
crc64.c	…
ctype.c	…
debug_info.c	…
debug_locks.c	…
debugobjects.c	debugobjects: Convert to SPDX license identifier	2022-05-13 12:35:17 +02:00
dec_and_lock.c	…
decompress.c	…
decompress_bunzip2.c	…
decompress_inflate.c	…
decompress_unlz4.c	…
decompress_unlzma.c	…
decompress_unlzo.c	…
decompress_unxz.c	…
decompress_unzstd.c	…
devmem_is_allowed.c	…
devres.c	…
digsig.c	…
dump_stack.c	printk: rename cpulock functions	2022-04-22 21:30:57 +02:00
dynamic_debug.c	…
dynamic_queue_limits.c	…
earlycpio.c	…
errname.c	…
error-inject.c	…
errseq.c	…
extable.c	…
fault-inject-usercopy.c	…
fault-inject.c	mm: fix missing handler for __GFP_NOWARN	2022-05-19 14:08:55 -07:00
fdt.c	…
fdt_addresses.c	…
fdt_empty_tree.c	…
fdt_ro.c	…
fdt_rw.c	…
fdt_strerror.c	…
fdt_sw.c	…
fdt_wip.c	…
find_bit.c	…
find_bit_benchmark.c	…
flex_proportions.c	…
gen_crc32table.c	…
gen_crc64table.c	…
genalloc.c	…
generic-radix-tree.c	…
glob.c	lib: remove back_str initialization	2022-04-29 14:38:01 -07:00
globtest.c	…
hexdump.c	hex2bin: fix access beyond string end	2022-04-27 10:57:33 -07:00
hweight.c	…
idr.c	ida: don't use BUG_ON() for debugging	2022-07-10 13:55:49 -07:00
inflate.c	…
interval_tree.c	…
interval_tree_test.c	…
iomap.c	…
iomap_copy.c	…
iommu-helper.c	…
iov_iter.c	iov_iter: fix build issue due to possible type mis-match	2022-06-11 10:30:20 -07:00
irq_poll.c	lib/irq_poll: Prevent softirq pending leak in irq_poll_cpu_dead()	2022-04-13 21:32:21 +02:00
irq_regs.c	…
is_single_threaded.c	…
kasprintf.c	…
kfifo.c	…
klist.c	…
kobject.c	kobject: kobj_type: remove default_attrs	2022-04-05 15:39:19 +02:00
kobject_uevent.c	…
kstrtox.c	lib/kstrtox.c: add "false"/"true" support to kstrtobool()	2022-05-13 07:20:13 -07:00
kstrtox.h	…
libcrc32c.c	…
linear_ranges.c	…
list-test.c	list: test: Test the hlist structure	2022-04-05 13:32:27 -06:00
list_debug.c	…
list_sort.c	…
llist.c	…
locking-selftest-hardirq.h	…
locking-selftest-mutex.h	…
locking-selftest-rlock-hardirq.h	…
locking-selftest-rlock-softirq.h	…
locking-selftest-rlock.h	…
locking-selftest-rsem.h	…
locking-selftest-rtmutex.h	…
locking-selftest-softirq.h	…
locking-selftest-spin-hardirq.h	…
locking-selftest-spin-softirq.h	…
locking-selftest-spin.h	…
locking-selftest-wlock-hardirq.h	…
locking-selftest-wlock-softirq.h	…
locking-selftest-wlock.h	…
locking-selftest-wsem.h	…
locking-selftest.c	…
lockref.c	lockref: remove unused 'lockref_get_or_lock()' function	2022-07-03 14:40:28 -07:00
logic_iomem.c	…
logic_pio.c	…
lru_cache.c	…
lshrdi3.c	…
memcat_p.c	…
memcpy_kunit.c	…
memneq.c	crypto: memneq - move into lib/	2022-06-12 14:51:51 +08:00
memory-notifier-error-inject.c	…
memregion.c	…
memweight.c	…
muldi3.c	…
net_utils.c	…
netdev-notifier-error-inject.c	…
nlattr.c	…
nmi_backtrace.c	printk: rename cpulock functions	2022-04-22 21:30:57 +02:00
nodemask.c	nodemask: Fix return values to be unsigned	2022-06-03 06:52:58 -07:00
notifier-error-inject.c	…
notifier-error-inject.h	…
objagg.c	…
of-reconfig-notifier-error-inject.c	…
oid_registry.c	…
once.c	…
overflow_kunit.c	…
packing.c	…
parman.c	…
parser.c	…
pci_iomap.c	…
percpu-refcount.c	percpu_ref_init(): clean ->percpu_count_ref on failure	2022-05-18 02:20:17 -04:00
percpu_counter.c	…
percpu_test.c	…
plist.c	…
pm-notifier-error-inject.c	…
polynomial.c	lib: add generic polynomial calculation	2022-05-22 11:32:30 -07:00
radix-tree.c	…
random32.c	random32: use real rng for non-deterministic randomness	2022-05-18 15:53:52 +02:00
ratelimit.c	…
rbtree.c	…
rbtree_test.c	…
ref_tracker.c	…
refcount.c	…
rhashtable.c	…
sbitmap.c	lib/sbitmap: Fix invalid loop in __sbitmap_queue_get_batch()	2022-06-25 10:58:55 -06:00
scatterlist.c	…
seq_buf.c	…
sg_pool.c	…
sg_split.c	…
sha1.c	…
show_mem.c	…
siphash.c	SPDX changes for 5.19-rc1	2022-06-03 10:34:34 -07:00
slub_kunit.c	mm/slub, kunit: Make slub_kunit unaffected by user specified flags	2022-04-06 10:11:48 +02:00
smp_processor_id.c	…
sort.c	…
stackdepot.c	lib/stackdepot: allow requesting early initialization dynamically	2022-04-06 10:55:50 +02:00
stackinit_kunit.c	…
stmp_device.c	…
string.c	lib/string.c: simplify str[c]spn	2022-04-29 14:38:01 -07:00
string_helpers.c	lib/string_helpers: fix not adding strarray to device's resource list	2022-05-12 20:38:36 -07:00
strncpy_from_user.c	lib/strn*,objtool: Enforce user_access_begin() rules	2022-04-19 21:58:47 +02:00
strnlen_user.c	lib/strn*,objtool: Enforce user_access_begin() rules	2022-04-19 21:58:47 +02:00
syscall.c	…
test-kstrtox.c	…
test-string_helpers.c	…
test_bitmap.c	lib/bitmap: add test for bitmap_{from,to}_arr64	2022-06-03 06:52:58 -07:00
test_bitops.c	…
test_bits.c	…
test_blackhole_dev.c	…
test_bpf.c	bpf, tests: Add load store test case for tail call	2022-04-01 00:27:52 +02:00
test_debug_virtual.c	…
test_firmware.c	test_firmware: fix end of loop test in upload_read_show()	2022-05-19 19:28:37 +02:00
test_fprobe.c	…
test_fpu.c	…
test_free_pages.c	…
test_hash.c	…
test_hexdump.c	…
test_hmm.c	…
test_hmm_uapi.h	…
test_ida.c	…
test_kasan.c	kasan: test: Use NULL macros	2022-04-04 14:29:20 -06:00
test_kasan_module.c	…
test_kmod.c	lib/test: use after free in register_test_dev_kmod()	2022-03-29 15:13:36 -07:00
test_kprobes.c	…
test_linear_ranges.c	…
test_list_sort.c	…
test_lockup.c	…
test_memcat_p.c	…
test_meminit.c	lib/test_meminit: optimize do_kmem_cache_rcu_persistent() test	2022-04-29 14:38:00 -07:00
test_min_heap.c	…
test_module.c	…
test_objagg.c	…
test_parman.c	…
test_printf.c	…
test_ref_tracker.c	…
test_rhashtable.c	…
test_scanf.c	…
test_siphash.c	siphash: add SPDX tags as sole licensing authority	2022-05-19 18:54:22 +02:00
test_sort.c	…
test_static_key_base.c	…
test_static_keys.c	…
test_string.c	lib/test_string.c: add strspn and strcspn tests	2022-04-29 14:38:00 -07:00
test_strscpy.c	…
test_sysctl.c	selftests/sysctl: add sysctl macro test	2022-05-03 10:15:07 +02:00
test_ubsan.c	…
test_user_copy.c	…
test_uuid.c	…
test_vmalloc.c	…
test_xarray.c	XArray: Fix xas_create_range() when multi-order entry present	2022-03-28 19:25:11 -04:00
textsearch.c	…
timerqueue.c	…
ts_bm.c	…
ts_fsm.c	…
ts_kmp.c	…
ubsan.c	ubsan: no need to unset panic_on_warn in ubsan_epilogue()	2022-03-23 19:00:35 -07:00
ubsan.h	…
ucmpdi2.c	…
ucs2_string.c	…
usercopy.c	…
uuid.c	…
vsprintf.c	random: remove rng_has_arch_random()	2022-06-10 11:29:48 +02:00
win_minmax.c	…
xarray.c	mm/huge_memory: Fix xarray node memory leak	2022-06-09 16:24:25 -04:00
xxhash.c	…