Zhang Yi 34fcb59437 jbd2: correct the end of the journal recovery scan range ... [ Upstream commit 2dfba3bb40 ] We got a filesystem inconsistency issue below while running generic/475 I/O failure pressure test with fast_commit feature enabled. Symlink /p3/d3/d1c/d6c/dd6/dce/l101 (inode #132605) is invalid. If fast_commit feature is enabled, a special fast_commit journal area is appended to the end of the normal journal area. The journal->j_last point to the first unused block behind the normal journal area instead of the whole log area, and the journal->j_fc_last point to the first unused block behind the fast_commit journal area. While doing journal recovery, do_one_pass(PASS_SCAN) should first scan the normal journal area and turn around to the first block once it meet journal->j_last, but the wrap() macro misuse the journal->j_fc_last, so the recovering could not read the next magic block (commit block perhaps) and would end early mistakenly and missing tN and every transaction after it in the following example. Finally, it could lead to filesystem inconsistency. | normal journal area | fast commit area | +-------------------------------------------------+------------------+ | tN(rere) | tN+1 |~| tN-x |...| tN-1 | tN(front) | .... | +-------------------------------------------------+------------------+ / / / start journal->j_last journal->j_fc_last This patch fix it by use the correct ending journal->j_last. Fixes: 5b849b5f96 ("jbd2: fast commit recovery path") Cc: stable@kernel.org Reported-by: Theodore Ts'o <tytso@mit.edu> Link: https://lore.kernel.org/linux-ext4/20230613043120.GB1584772@mit.edu/ Signed-off-by: Zhang Yi <yi.zhang@huawei.com> Reviewed-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20230626073322.3956567-1-yi.zhang@huaweicloud.com Signed-off-by: Theodore Ts'o <tytso@mit.edu> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-09-23 11:10:00 +02:00
..
Kconfig	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
Makefile	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
checkpoint.c	jbd2: rename jbd_debug() to jbd2_debug()	2023-09-23 11:10:00 +02:00
commit.c	jbd2: rename jbd_debug() to jbd2_debug()	2023-09-23 11:10:00 +02:00
journal.c	jbd2: rename jbd_debug() to jbd2_debug()	2023-09-23 11:10:00 +02:00
recovery.c	jbd2: correct the end of the journal recovery scan range	2023-09-23 11:10:00 +02:00
revoke.c	jbd2: rename jbd_debug() to jbd2_debug()	2023-09-23 11:10:00 +02:00
transaction.c	jbd2: rename jbd_debug() to jbd2_debug()	2023-09-23 11:10:00 +02:00