Stanislav Fomichev ac6158b5c4 bpf: Don't EFAULT for {g,s}setsockopt with wrong optlen ... [ Upstream commit 29ebbba7d4 ] With the way the hooks implemented right now, we have a special condition: optval larger than PAGE_SIZE will expose only first 4k into BPF; any modifications to the optval are ignored. If the BPF program doesn't handle this condition by resetting optlen to 0, the userspace will get EFAULT. The intention of the EFAULT was to make it apparent to the developers that the program is doing something wrong. However, this inadvertently might affect production workloads with the BPF programs that are not too careful (i.e., returning EFAULT for perfectly valid setsockopt/getsockopt calls). Let's try to minimize the chance of BPF program screwing up userspace by ignoring the output of those BPF programs (instead of returning EFAULT to the userspace). pr_info_once those cases to the dmesg to help with figuring out what's going wrong. Fixes: 0d01da6afc ("bpf: implement getsockopt and setsockopt hooks") Suggested-by: Martin KaFai Lau <martin.lau@kernel.org> Signed-off-by: Stanislav Fomichev <sdf@google.com> Link: https://lore.kernel.org/r/20230511170456.1759459-2-sdf@google.com Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-07-23 13:46:49 +02:00
..
preload	…
Kconfig	…
Makefile	…
arraymap.c	bpf: Acquire map uref in .init_seq_private for array map iterator	2022-08-25 11:40:03 +02:00
bpf_inode_storage.c	…
bpf_iter.c	…
bpf_local_storage.c	bpf: Annotate data races in bpf_local_storage	2023-05-24 17:36:44 +01:00
bpf_lru_list.c	…
bpf_lru_list.h	…
bpf_lsm.c	…
bpf_struct_ops.c	…
bpf_struct_ops_types.h	…
bpf_task_storage.c	bpf: Use this_cpu_{inc|dec|inc_return} for bpf_task_storage_busy	2022-10-26 12:34:41 +02:00
btf.c	bpf/btf: Accept function names that contain dots	2023-06-28 10:29:49 +02:00
cgroup.c	bpf: Don't EFAULT for {g,s}setsockopt with wrong optlen	2023-07-23 13:46:49 +02:00
core.c	bpf: Adjust insufficient default bpf_jit_limit	2023-03-30 12:47:47 +02:00
cpumap.c	…
devmap.c	…
disasm.c	…
disasm.h	…
dispatcher.c	…
hashtab.c	bpf: fix a memory leak in the LRU and LRU_PERCPU hash maps	2023-06-05 09:21:14 +02:00
helpers.c	bpf: Add MEM_RDONLY for helper args that are pointers to rdonly mem.	2022-05-01 17:22:26 +02:00
inode.c	…
local_storage.c	…
lpm_trie.c	…
map_in_map.c	…
map_in_map.h	…
map_iter.c	bpf: Introduce MEM_RDONLY flag	2022-05-01 17:22:24 +02:00
net_namespace.c	…
offload.c	bpf: restore the ebpf program ID for BPF_AUDIT_UNLOAD and PERF_BPF_EVENT_PROG_UNLOAD	2023-01-24 07:22:46 +01:00
percpu_freelist.c	bpf: Initialize same number of free nodes for each pcpu_freelist	2022-11-26 09:24:38 +01:00
percpu_freelist.h	…
prog_iter.c	…
queue_stack_maps.c	…
reuseport_array.c	…
ringbuf.c	bpf: Add MEM_RDONLY for helper args that are pointers to rdonly mem.	2022-05-01 17:22:26 +02:00
stackmap.c	bpf: Fix excessive memory allocation in stack_map_alloc()	2022-06-06 08:43:42 +02:00
syscall.c	bpf: restore the ebpf program ID for BPF_AUDIT_UNLOAD and PERF_BPF_EVENT_PROG_UNLOAD	2023-01-24 07:22:46 +01:00
sysfs_btf.c	…
task_iter.c	…
tnum.c	…
trampoline.c	bpf: Fix potential array overflow in bpf_trampoline_get_progs()	2022-06-06 08:43:42 +02:00
verifier.c	bpf: ensure main program has an extable	2023-07-05 18:25:05 +01:00