Gustavo A. R. Silva ee4064e56c xfs: Replace zero-length array with flexible-array ... The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on. Also, notice that, dynamic memory allocations won't be affected by this change: "Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1] sizeof(flexible-array-member) triggers a warning because flexible array members have incomplete type[1]. There are some instances of code in which the sizeof operator is being incorrectly/erroneously applied to zero-length arrays and the result is zero. Such instances may be hiding some bugs. So, this work (flexible-array member conversions) will also help to get completely rid of those sorts of issues. This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 7649773293 ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>		2020-05-13 15:32:45 -07:00
..
libxfs	xfs: Replace zero-length array with flexible-array	2020-05-13 15:32:45 -07:00
scrub	xfs: remove unused iget_flags param from xfs_imap_to_bp()	2020-05-07 08:27:49 -07:00
Kconfig	…
Makefile	xfs: refactor log recovery item sorting into a generic dispatch structure	2020-05-08 08:49:58 -07:00
kmem.c	xfs: Correct comment tyops -> typos	2019-11-10 10:21:57 -08:00
kmem.h	xfs: Remove kmem_zone_free() wrapper	2019-11-18 08:40:44 -08:00
mrlock.h	…
xfs.h	…
xfs_acl.c	xfs: only allocate the buffer size actually needed in __xfs_set_acl	2020-03-02 20:55:55 -08:00
xfs_acl.h	xfs: improve xfs_forget_acl	2020-03-02 20:55:55 -08:00
xfs_aops.c	xfs: ratelimit xfs_discard_page messages	2020-03-02 20:55:51 -08:00
xfs_aops.h	xfs: add a xfs_inode_buftarg helper	2019-10-28 08:37:54 -07:00
xfs_attr_inactive.c	xfs: add a function to deal with corrupt buffers post-verifiers	2020-03-12 07:58:12 -07:00
xfs_attr_list.c	xfs: add a function to deal with corrupt buffers post-verifiers	2020-03-12 07:58:12 -07:00
xfs_bio_io.c	…
xfs_bmap_item.c	xfs: hoist setting of XFS_LI_RECOVERED to caller	2020-05-08 08:50:01 -07:00
xfs_bmap_item.h	xfs: refactor intent item RECOVERED flag into the log item	2020-05-08 08:50:01 -07:00
xfs_bmap_util.c	xfs: clean up the error handling in xfs_swap_extents	2020-05-06 13:17:21 -07:00
xfs_bmap_util.h	xfs: simplify xfs_iomap_eof_align_last_fsb	2019-11-03 10:22:30 -08:00
xfs_buf.c	xfs: fix unused variable warning in buffer completion on !DEBUG	2020-05-08 08:50:52 -07:00
xfs_buf.h	xfs: refactor ratelimited buffer error messages into helper	2020-05-07 08:27:46 -07:00
xfs_buf_item.c	xfs: combine xfs_trans_ail_[remove|delete]()	2020-05-07 08:27:48 -07:00
xfs_buf_item.h	xfs: refactor failed buffer resubmission into xfsaild	2020-05-07 08:27:45 -07:00
xfs_buf_item_recover.c	xfs: move log recovery buffer cancellation code to xfs_buf_item_recover.c	2020-05-08 08:50:01 -07:00
xfs_dir2_readdir.c	xfs: fix regression in "cleanup xfs_dir2_block_getdents"	2020-03-13 10:37:13 -07:00
xfs_discard.c	xfs: remove XFS_BUF_TO_AGF	2020-03-11 09:11:39 -07:00
xfs_discard.h	…
xfs_dquot.c	xfs: combine xfs_trans_ail_[remove|delete]()	2020-05-07 08:27:48 -07:00
xfs_dquot.h	xfs: remove the xfs_dq_logitem_t typedef	2019-11-13 18:22:26 -08:00
xfs_dquot_item.c	xfs: combine xfs_trans_ail_[remove|delete]()	2020-05-07 08:27:48 -07:00
xfs_dquot_item.h	xfs: factor out quotaoff intent AIL removal and memory free	2020-03-18 08:12:23 -07:00
xfs_dquot_item_recover.c	xfs: remove log recovery quotaoff item dispatch for pass2 commit functions	2020-05-08 08:49:59 -07:00
xfs_error.c	xfs: random buffer write failure errortag	2020-05-07 08:27:48 -07:00
xfs_error.h	xfs: xfs_buf_corruption_error should take __this_address	2020-03-12 07:58:12 -07:00
xfs_export.c	xfs: factor out a new xfs_log_force_inode helper	2020-04-06 08:44:35 -07:00
xfs_export.h	…
xfs_extent_busy.c	xfs: cleanup use of the XFS_ALLOC_ flags	2019-11-03 10:22:31 -08:00
xfs_extent_busy.h	…
xfs_extfree_item.c	xfs: hoist setting of XFS_LI_RECOVERED to caller	2020-05-08 08:50:01 -07:00
xfs_extfree_item.h	xfs: refactor intent item RECOVERED flag into the log item	2020-05-08 08:50:01 -07:00
xfs_file.c	xfs: reflink should force the log out if mounted with wsync	2020-04-06 08:44:39 -07:00
xfs_filestream.c	xfs: make xfs_*read_agf return EAGAIN to ALLOC_FLAG_TRYLOCK callers	2020-01-26 14:32:26 -08:00
xfs_filestream.h	…
xfs_fsmap.c	xfs: prohibit fs freezing when using empty transactions	2020-03-26 08:19:24 -07:00
xfs_fsmap.h	…
xfs_fsops.c	xfs: remove unused shutdown types	2020-05-07 08:27:48 -07:00
xfs_fsops.h	…
xfs_globals.c	…
xfs_health.c	…
xfs_icache.c	xfs: remove unused iflush stale parameter	2020-05-07 08:27:48 -07:00
xfs_icache.h	…
xfs_icreate_item.c	xfs: refactor log recovery icreate item dispatch for pass2 commit functions	2020-05-08 08:49:59 -07:00
xfs_icreate_item.h	…
xfs_inode.c	xfs: remove unused iget_flags param from xfs_imap_to_bp()	2020-05-07 08:27:49 -07:00
xfs_inode.h	fs/xfs: Combine xfs_diflags_to_linux() and xfs_diflags_to_iflags()	2020-05-04 09:03:43 -07:00
xfs_inode_item.c	xfs: remove unused iflush stale parameter	2020-05-07 08:27:48 -07:00
xfs_inode_item.h	xfs: remove unused iflush stale parameter	2020-05-07 08:27:48 -07:00
xfs_inode_item_recover.c	xfs: refactor log recovery inode item dispatch for pass2 commit functions	2020-05-08 08:49:58 -07:00
xfs_ioctl.c	fs/xfs: Combine xfs_diflags_to_linux() and xfs_diflags_to_iflags()	2020-05-04 09:03:43 -07:00
xfs_ioctl.h	xfs: embedded the attrlist cursor into struct xfs_attr_list_context	2020-03-02 20:55:55 -08:00
xfs_ioctl32.c	xfs: lift cursor copy in/out into xfs_ioc_attr_list	2020-03-02 20:55:54 -08:00
xfs_ioctl32.h	xfs: rename compat_time_t to old_time32_t	2020-01-06 08:57:36 -08:00
xfs_iomap.c	xfs: change return value of xfs_inode_need_cow to int	2020-01-20 14:34:47 -08:00
xfs_iomap.h	xfs: simplify the xfs_iomap_write_direct calling	2019-11-03 10:22:30 -08:00
xfs_iops.c	fs/xfs: Combine xfs_diflags_to_linux() and xfs_diflags_to_iflags()	2020-05-04 09:03:43 -07:00
xfs_iops.h	…
xfs_itable.c	xfs: remove the di_version field from struct icdinode	2020-03-19 08:48:47 -07:00
xfs_itable.h	…
xfs_iwalk.c	xfs: kill the XFS_WANT_CORRUPT_* macros	2019-11-12 17:19:02 -08:00
xfs_iwalk.h	…
xfs_linux.h	xfs: clean up the attr flag confusion	2020-03-02 20:55:55 -08:00
xfs_log.c	xfs: don't write a corrupt unmount record to force summary counter recalc	2020-03-27 08:32:55 -07:00
xfs_log.h	xfs: refactor and split xfs_log_done()	2020-03-27 08:32:53 -07:00
xfs_log_cil.c	xfs: Throttle commits on delayed background CIL push	2020-03-27 08:32:54 -07:00
xfs_log_priv.h	xfs: Throttle commits on delayed background CIL push	2020-03-27 08:32:54 -07:00
xfs_log_recover.c	xfs: remove unnecessary includes from xfs_log_recover.c	2020-05-08 08:50:01 -07:00
xfs_message.c	xfs: refactor ratelimited buffer error messages into helper	2020-05-07 08:27:46 -07:00
xfs_message.h	xfs: refactor ratelimited buffer error messages into helper	2020-05-07 08:27:46 -07:00
xfs_mount.c	xfs: define printk_once variants for xfs messages	2020-05-04 09:03:15 -07:00
xfs_mount.h	xfs: remove unused shutdown types	2020-05-07 08:27:48 -07:00
xfs_mru_cache.c	…
xfs_mru_cache.h	…
xfs_ondisk.h	xfs: make struct xfs_buf_log_format have a consistent size	2020-01-16 08:07:23 -08:00
xfs_pnfs.c	xfs: define printk_once variants for xfs messages	2020-05-04 09:03:15 -07:00
xfs_pnfs.h	…
xfs_pwork.c	…
xfs_pwork.h	…
xfs_qm.c	xfs: remove unnecessary assertion from xfs_qm_vop_create_dqattach	2020-05-04 09:03:14 -07:00
xfs_qm.h	xfs: quota: move to time64_t interfaces	2020-01-06 08:57:37 -08:00
xfs_qm_bhv.c	xfs: remove the xfs_disk_dquot_t and xfs_dquot_t	2019-11-13 11:13:45 -08:00
xfs_qm_syscalls.c	xfs: simplify the flags setting in xfs_qm_scall_quotaon	2020-05-04 09:03:14 -07:00
xfs_quota.h	xfs: remove the icdinode di_uid/di_gid members	2020-03-02 20:55:50 -08:00
xfs_quotaops.c	xfs: quota: move to time64_t interfaces	2020-01-06 08:57:37 -08:00
xfs_refcount_item.c	xfs: hoist setting of XFS_LI_RECOVERED to caller	2020-05-08 08:50:01 -07:00
xfs_refcount_item.h	xfs: refactor intent item RECOVERED flag into the log item	2020-05-08 08:50:01 -07:00
xfs_reflink.c	xfs: fix partially uninitialized structure in xfs_reflink_remap_extent	2020-04-13 08:00:23 -07:00
xfs_reflink.h	xfs: change return value of xfs_inode_need_cow to int	2020-01-20 14:34:47 -08:00
xfs_rmap_item.c	xfs: hoist setting of XFS_LI_RECOVERED to caller	2020-05-08 08:50:01 -07:00
xfs_rmap_item.h	xfs: refactor intent item RECOVERED flag into the log item	2020-05-08 08:50:01 -07:00
xfs_rtalloc.c	xfs: make xfs_trans_get_buf return an error code	2020-01-26 14:32:26 -08:00
xfs_rtalloc.h	…
xfs_stats.c	xfs: Use scnprintf() for avoiding potential buffer overflow	2020-03-12 07:58:13 -07:00
xfs_stats.h	…
xfs_super.c	xfs: ensure f_bfree returned by statfs() is non-negative	2020-05-13 15:32:45 -07:00
xfs_super.h	…
xfs_symlink.c	xfs: remove unnecessary check of the variable resblks in xfs_symlink	2020-05-04 09:03:15 -07:00
xfs_symlink.h	xfs: Correct comment tyops -> typos	2019-11-10 10:21:57 -08:00
xfs_sysctl.c	…
xfs_sysctl.h	…
xfs_sysfs.c	…
xfs_sysfs.h	…
xfs_trace.c	xfs: support bulk loading of staged btrees	2020-03-18 08:12:23 -07:00
xfs_trace.h	xfs: Throttle commits on delayed background CIL push	2020-03-27 08:32:54 -07:00
xfs_trans.c	xfs: split xlog_ticket_done	2020-03-27 08:32:53 -07:00
xfs_trans.h	xfs: refactor intent item RECOVERED flag into the log item	2020-05-08 08:50:01 -07:00
xfs_trans_ail.c	xfs: refactor adding recovered intent items to the log	2020-05-08 08:50:00 -07:00
xfs_trans_buf.c	xfs: fix xfs_buf_ioerror_alert location reporting	2020-01-26 14:32:27 -08:00
xfs_trans_dquot.c	xfs: quota: move to time64_t interfaces	2020-01-06 08:57:37 -08:00
xfs_trans_priv.h	xfs: refactor adding recovered intent items to the log	2020-05-08 08:50:00 -07:00
xfs_xattr.c	xfs: remove duplicate headers	2020-05-08 08:51:34 -07:00