Eric Paris d7e7528bcd Audit: push audit success and retcode into arch ptrace.h ... The audit system previously expected arches calling to audit_syscall_exit to supply as arguments if the syscall was a success and what the return code was. Audit also provides a helper AUDITSC_RESULT which was supposed to simplify things by converting from negative retcodes to an audit internal magic value stating success or failure. This helper was wrong and could indicate that a valid pointer returned to userspace was a failed syscall. The fix is to fix the layering foolishness. We now pass audit_syscall_exit a struct pt_reg and it in turns calls back into arch code to collect the return value and to determine if the syscall was a success or failure. We also define a generic is_syscall_success() macro which determines success/failure based on if the value is < -MAX_ERRNO. This works for arches like x86 which do not use a separate mechanism to indicate syscall failure. We make both the is_syscall_success() and regs_return_value() static inlines instead of macros. The reason is because the audit function must take a void* for the regs. (uml calls theirs struct uml_pt_regs instead of just struct pt_regs so audit_syscall_exit can't take a struct pt_regs). Since the audit function takes a void* we need to use static inlines to cast it back to the arch correct structure to dereference it. The other major change is that on some arches, like ia64, MIPS and ppc, we change regs_return_value() to give us the negative value on syscall failure. THE only other user of this macro, kretprobe_example.c, won't notice and it makes the value signed consistently for the audit functions across all archs. In arch/sh/kernel/ptrace_64.c I see that we were using regs[9] in the old audit code as the return value. But the ptrace_64.h code defined the macro regs_return_value() as regs[3]. I have no idea which one is correct, but this patch now uses the regs_return_value() function, so it now uses regs[3]. For powerpc we previously used regs->result but now use the regs_return_value() function which uses regs->gprs[3]. regs->gprs[3] is always positive so the regs_return_value(), much like ia64 makes it negative before calling the audit code when appropriate. Signed-off-by: Eric Paris <eparis@redhat.com> Acked-by: H. Peter Anvin <hpa@zytor.com> [for x86 portion] Acked-by: Tony Luck <tony.luck@intel.com> [for ia64] Acked-by: Richard Weinberger <richard@nod.at> [for uml] Acked-by: David S. Miller <davem@davemloft.net> [for sparc] Acked-by: Ralf Baechle <ralf@linux-mips.org> [for mips] Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> [for ppc]		2012-01-17 16:16:56 -05:00
..
acpi	x86, acpi: Skip acpi x2apic entries if the x2apic feature is not present	2011-12-23 11:00:50 -08:00
apic	Merge branch 'x86-apic-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2012-01-06 13:58:21 -08:00
cpu	Merge branch 'driver-core-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core	2012-01-07 12:03:30 -08:00
.gitignore	…
Makefile	x86, NMI: Add NMI IPI selftest	2011-12-05 12:00:16 +01:00
alternative.c	x86: Call stop_machine_text_poke() on all CPUs	2011-11-14 13:05:15 +01:00
amd_gart_64.c	doc: fix broken references	2011-09-27 18:08:04 +02:00
amd_nb.c	Merge branch 'linux-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/pci	2012-01-11 18:50:26 -08:00
apb_timer.c	Merge branch 'timers-clocksource-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip	2011-07-23 10:34:47 -07:00
aperture_64.c	memblock, x86: Replace memblock_x86_reserve/free_range() with generic ones	2011-07-14 11:47:53 -07:00
apm_32.c	doc: fix broken references	2011-09-27 18:08:04 +02:00
asm-offsets.c	x86, efi: EFI boot stub support	2011-12-12 14:26:10 -08:00
asm-offsets_32.c	lguest: use a special 1:1 linear pagetable mode until first switch.	2011-07-22 14:39:48 +09:30
asm-offsets_64.c	x86: Partly unify asm-offsets_{32,64}.c	2011-02-10 13:31:37 +01:00
audit_64.c	…
bootflag.c	…
check.c	memblock, x86: Replace memblock_x86_reserve/free_range() with generic ones	2011-07-14 11:47:53 -07:00
cpuid.c	switch device_get_devnode() and ->devnode() to umode_t *	2012-01-03 22:54:55 -05:00
crash.c	x86, nmi: Wire up NMI handlers to new routines	2011-10-10 06:56:57 +02:00
crash_dump_32.c	crash_dump: export is_kdump_kernel to modules, consolidate elfcorehdr_addr, setup_elfcorehdr and saved_max_pfn	2011-03-23 19:47:19 -07:00
crash_dump_64.c	crash_dump: export is_kdump_kernel to modules, consolidate elfcorehdr_addr, setup_elfcorehdr and saved_max_pfn	2011-03-23 19:47:19 -07:00
devicetree.c	x86: Fix files explicitly requiring export.h for EXPORT_SYMBOL/THIS_MODULE	2011-10-31 19:30:35 -04:00
doublefault_32.c	…
dumpstack.c	Merge branch 'driver-core-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core-2.6	2011-05-19 18:24:11 -07:00
dumpstack_32.c	x86, dumpstack: Fix code bytes breakage due to missing KERN_CONT	2011-12-19 13:09:56 -08:00
dumpstack_64.c	x86, dumpstack: Fix code bytes breakage due to missing KERN_CONT	2011-12-19 13:09:56 -08:00
e820.c	Merge branch 'x86-mm-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2012-01-11 19:12:10 -08:00
early-quirks.c	x86, quirk: Fix SB600 revision check	2011-03-16 14:03:32 +01:00
early_printk.c	Merge branch 'x86-platform-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2012-01-11 19:13:40 -08:00
entry_32.S	Audit: push audit success and retcode into arch ptrace.h	2012-01-17 16:16:56 -05:00
entry_64.S	Audit: push audit success and retcode into arch ptrace.h	2012-01-17 16:16:56 -05:00
ftrace.c	x86/ftrace: Fix compiler warning in ftrace.c	2011-05-25 19:56:26 -04:00
head.c	memblock, x86: Replace memblock_x86_reserve/free_range() with generic ones	2011-07-14 11:47:53 -07:00
head32.c	memblock: Kill memblock_init()	2011-12-08 10:22:07 -08:00
head64.c	memblock: Kill memblock_init()	2011-12-08 10:22:07 -08:00
head_32.S	Merge branch 'x86-platform-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip	2011-03-15 20:01:36 -07:00
head_64.S	x86, trampoline: Common infrastructure for low memory trampolines	2011-02-17 21:02:43 -08:00
hpet.c	Merge branch 'driver-core-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core	2012-01-07 12:03:30 -08:00
hw_breakpoint.c	…
i386_ksyms_32.c	…
i387.c	treewide: fix potentially dangerous trailing ';' in #defined values/expressions	2011-07-21 14:10:00 +02:00
i8237.c	x86: Use syscore_ops instead of sysdev classes and sysdevs	2011-03-23 22:15:54 +01:00
i8253.c	x86: Use common i8253 clockevent	2011-07-01 10:37:14 +02:00
i8259.c	atomic: use <linux/atomic.h>	2011-07-26 16:49:47 -07:00
init_task.c	…
io_delay.c	…
ioport.c	x86: Use bitmap library functions	2011-02-17 14:59:22 +01:00
irq.c	Merge branch 'x86-apic-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2012-01-06 13:58:21 -08:00
irq_32.c	x86: Fix the 32-bit stackoverflow-debug build	2011-12-05 12:25:44 +01:00
irq_64.c	x86: Add stack top margin for stack overflow checking	2011-12-07 09:27:11 +01:00
irq_work.c	…
irqinit.c	driver-core: remove sysdev.h usage.	2011-12-21 16:26:03 -08:00
jump_label.c	jump_label, x86: Fix section mismatch	2011-12-06 20:41:02 +01:00
kdebugfs.c	…
kgdb.c	x86, nmi: Wire up NMI handlers to new routines	2011-10-10 06:56:57 +02:00
kprobes.c	Merge branch 'perf-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2011-10-26 17:03:38 +02:00
kvm.c	KVM guest: remove KVM guest pv mmu support	2011-12-27 11:17:08 +02:00
kvmclock.c	KVM guest: prevent tracing recursion with kvmclock	2011-11-20 10:53:48 +02:00
ldt.c	…
machine_kexec_32.c	…
machine_kexec_64.c	…
mca_32.c	x86: Fix common misspellings	2011-03-18 10:39:30 +01:00
microcode_amd.c	x86, microcode, AMD: Update copyrights	2011-12-14 12:46:52 +01:00
microcode_core.c	Merge branch 'driver-core-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core	2012-01-07 12:03:30 -08:00
microcode_intel.c	x86, intel: Output microcode revision in /proc/cpuinfo	2011-10-14 13:16:35 +02:00
mmconf-fam10h_64.c	…
module.c	modules: make arch's use default loader hooks	2011-07-24 22:06:04 +09:30
mpparse.c	Merge branch 'memblock-kill-early_node_map' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc into core/memblock	2011-12-20 12:14:26 +01:00
msr.c	switch device_get_devnode() and ->devnode() to umode_t *	2012-01-03 22:54:55 -05:00
nmi.c	x86, ioapic: Only print ioapic debug information for IRQs belonging to an ioapic chip	2011-11-10 18:31:23 +01:00
nmi_selftest.c	x86, NMI: Add to_cpumask() to silence compile warning	2011-12-07 23:26:57 +01:00
paravirt-spinlocks.c	…
paravirt.c	Merge branch 'x86-vdso-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-tip	2011-08-12 20:46:24 -07:00
paravirt_patch_32.c	…
paravirt_patch_64.c	…
pci-calgary_64.c	treewide: Convert uses of struct resource to resource_size(ptr)	2011-06-10 14:55:36 +02:00
pci-dma.c	iommu: Add option to group multi-function devices	2011-11-15 12:22:31 +01:00
pci-iommu_table.c	arch/x86/kernel/pci-iommu_table.c: Convert sprintf_symbol to %pS	2011-05-10 10:21:35 +02:00
pci-nommu.c	…
pci-swiotlb.c	…
pcspeaker.c	…
probe_roms.c	x86: Fix files explicitly requiring export.h for EXPORT_SYMBOL/THIS_MODULE	2011-10-31 19:30:35 -04:00
process.c	x86: Fix rflags in FAKE_STACK_FRAME	2011-12-06 10:02:38 +01:00
process_32.c	nohz: Remove tick_nohz_idle_enter_norcu() / tick_nohz_idle_exit_norcu()	2011-12-11 10:31:57 -08:00
process_64.c	Merge branch 'x86-cleanups-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2012-01-06 14:00:12 -08:00
ptrace.c	Audit: push audit success and retcode into arch ptrace.h	2012-01-17 16:16:56 -05:00
pvclock.c	…
quirks.c	x86, amd: Fix up numa_node information for AMD CPU family 15h model 0-0fh northbridge functions	2011-12-05 18:13:11 +01:00
reboot.c	x86: Fix "Acer Aspire 1" reboot hang	2011-12-05 15:06:17 +01:00
reboot_32.S	x86, reboot: Fix relocations in reboot_32.S	2011-05-02 14:44:46 -07:00
reboot_fixups_32.c	…
relocate_kernel_32.S	kexec, x86: Fix incorrect jump back address if not preserving context	2011-07-21 11:19:28 +02:00
relocate_kernel_64.S	kexec, x86: Fix incorrect jump back address if not preserving context	2011-07-21 11:19:28 +02:00
resource.c	…
rtc.c	x86/rtc, mrst: Don't register a platform RTC device for for Intel MID platforms	2011-12-05 17:09:21 +01:00
setup.c	Merge branch 'x86-efi-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2012-01-11 19:12:33 -08:00
setup_percpu.c	x86: Unify CPU -> NUMA node mapping between 32 and 64bit	2011-01-28 14:54:09 +01:00
signal.c	signal: add block_sigmask() for adding sigmask to current->blocked	2012-01-10 16:30:54 -08:00
smp.c	x86, reboot: Fix typo in nmi reboot path	2012-01-07 12:19:37 +01:00
smpboot.c	Merge branch 'x86-platform-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2012-01-11 19:13:40 -08:00
stacktrace.c	x86: Swap save_stack_trace_regs parameters	2011-06-14 22:48:51 -04:00
step.c	x86-64: Add user_64bit_mode paravirt op	2011-08-04 16:13:49 -07:00
sys_i386_32.c	…
sys_x86_64.c	x86, amd: Include linux/elf.h since we use stuff from asm/elf.h	2011-09-28 10:34:31 +02:00
syscall_64.c	…
syscall_table_32.S	Cross Memory Attach	2011-10-31 17:30:44 -07:00
tboot.c	x86: Fix files explicitly requiring export.h for EXPORT_SYMBOL/THIS_MODULE	2011-10-31 19:30:35 -04:00
tce_64.c	…
test_nx.c	x86: Eliminate various 'set but not used' warnings	2011-05-21 19:10:33 +02:00
test_rodata.c	…
time.c	x86: Fix files explicitly requiring export.h for EXPORT_SYMBOL/THIS_MODULE	2011-10-31 19:30:35 -04:00
tls.c	…
tls.h	…
topology.c	x86: Fix files explicitly requiring export.h for EXPORT_SYMBOL/THIS_MODULE	2011-10-31 19:30:35 -04:00
trampoline.c	memblock, x86: Replace memblock_x86_reserve/free_range() with generic ones	2011-07-14 11:47:53 -07:00
trampoline_32.S	x86, trampoline: Common infrastructure for low memory trampolines	2011-02-17 21:02:43 -08:00
trampoline_64.S	x86-64, trampoline: Remove unused variable	2011-02-18 15:50:36 -08:00
traps.c	x86: Clean up and extend do_int3()	2011-12-06 08:20:37 +01:00
tsc.c	Merge branch 'x86-platform-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2012-01-11 19:13:40 -08:00
tsc_sync.c	x86, tsc: Skip TSC synchronization checks for tsc=reliable	2011-12-05 18:00:31 +01:00
verify_cpu.S	x86: Fix common misspellings	2011-03-18 10:39:30 +01:00
vm86_32.c	Audit: push audit success and retcode into arch ptrace.h	2012-01-17 16:16:56 -05:00
vmlinux.lds.S	x86-64: Rework vsyscall emulation and add vsyscall= parameter	2011-08-10 19:26:46 -05:00
vsmp_64.c	…
vsyscall_64.c	x86: Default to vsyscall=emulate	2011-12-05 12:17:29 +01:00
vsyscall_emu_64.S	x86-64: Rework vsyscall emulation and add vsyscall= parameter	2011-08-10 19:26:46 -05:00
vsyscall_trace.h	x86-64: Add vsyscall:emulate_vsyscall trace event	2011-08-04 16:13:53 -07:00
x86_init.c	Merge branch 'linux-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/pci	2012-01-11 18:50:26 -08:00
x8664_ksyms_64.c	x86-64, mem: Convert memmove() to assembly file and fix return value bug	2011-01-25 16:58:39 -08:00
xsave.c	x86: Fix common misspellings	2011-03-18 10:39:30 +01:00