Duoming Zhou 9c34c33893 nfc: pn533: Fix use-after-free bugs caused by pn532_cmd_timeout ... [ Upstream commit f1e941dbf8 ] When the pn532 uart device is detaching, the pn532_uart_remove() is called. But there are no functions in pn532_uart_remove() that could delete the cmd_timeout timer, which will cause use-after-free bugs. The process is shown below: (thread 1) | (thread 2) | pn532_uart_send_frame pn532_uart_remove | mod_timer(&pn532->cmd_timeout,...) ... | (wait a time) kfree(pn532) //FREE | pn532_cmd_timeout | pn532_uart_send_frame | pn532->... //USE This patch adds del_timer_sync() in pn532_uart_remove() in order to prevent the use-after-free bugs. What's more, the pn53x_unregister_nfc() is well synchronized, it sets nfc_dev->shutting_down to true and there are no syscalls could restart the cmd_timeout timer. Fixes: c656aa4c27 ("nfc: pn533: add UART phy driver") Signed-off-by: Duoming Zhou <duoming@zju.edu.cn> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-08-31 17:16:38 +02:00
..
Kconfig	…
Makefile	…
i2c.c	nfc: pn533: drop unneeded braces {} in if	2021-05-31 21:32:37 -07:00
pn533.c	nfc: pn533: Fix buggy cleanup order	2022-06-06 08:43:36 +02:00
pn533.h	…
uart.c	nfc: pn533: Fix use-after-free bugs caused by pn532_cmd_timeout	2022-08-31 17:16:38 +02:00
usb.c	nfc: pn533: drop ftrace-like debugging messages	2021-05-31 21:32:37 -07:00