Vladimir Oltean c26a2c2ddc gianfar: Fix TX timestamping with a stacked DSA driver ... The driver wrongly assumes that it is the only entity that can set the SKBTX_IN_PROGRESS bit of the current skb. Therefore, in the gfar_clean_tx_ring function, where the TX timestamp is collected if necessary, the aforementioned bit is used to discriminate whether or not the TX timestamp should be delivered to the socket's error queue. But a stacked driver such as a DSA switch can also set the SKBTX_IN_PROGRESS bit, which is actually exactly what it should do in order to denote that the hardware timestamping process is undergoing. Therefore, gianfar would misinterpret the "in progress" bit as being its own, and deliver a second skb clone in the socket's error queue, completely throwing off a PTP process which is not expecting to receive it, _even though_ TX timestamping is not enabled for gianfar. There have been discussions [0] as to whether non-MAC drivers need or not to set SKBTX_IN_PROGRESS at all (whose purpose is to avoid sending 2 timestamps, a sw and a hw one, to applications which only expect one). But as of this patch, there are at least 2 PTP drivers that would break in conjunction with gianfar: the sja1105 DSA switch and the felix switch, by way of its ocelot core driver. So regardless of that conclusion, fix the gianfar driver to not do stuff based on flags set by others and not intended for it. [0]: https://www.spinics.net/lists/netdev/msg619699.html Fixes: f0ee7acfcd ("gianfar: Add hardware TX timestamping support") Signed-off-by: Vladimir Oltean <olteanv@gmail.com> Acked-by: Richard Cochran <richardcochran@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-12-28 11:43:40 -08:00
..
accessibility	…
acpi	ACPI: PM: Avoid attaching ACPI PM domain to certain devices	2019-12-10 00:22:18 +01:00
amba	…
android	binder: fix incorrect calculation for num_valid	2019-12-14 09:10:47 +01:00
ata	pci-v5.5-changes	2019-12-03 13:58:22 -08:00
atm	fore200e: Fix incorrect checks of NULL pointer dereference	2019-12-16 16:28:17 -08:00
auxdisplay	auxdisplay: charlcd: deduplicate simple_strtoul()	2019-12-04 19:44:12 -08:00
base	Merge branch 'remove-ksys-mount-dup' of git://git.kernel.org/pub/scm/linux/kernel/git/brodo/linux	2019-12-15 11:36:12 -08:00
bcma	bcma: remove set but not used variable 'sizel'	2019-12-18 20:55:25 +02:00
block	block-5.5-20191221	2019-12-22 10:36:55 -08:00
bluetooth	Bluetooth: btusb: Disable runtime suspend on Realtek devices	2019-12-05 10:31:29 +01:00
bus	bus: ti-sysc: Fix missing reset delay handling	2019-12-12 08:20:10 -08:00
cdrom	cdrom: respect device capabilities during opening action	2019-11-26 13:02:24 -07:00
char	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-12-22 15:15:05 -08:00
clk	clk: qcom: Avoid SMMU/cx gdsc corner cases	2019-12-18 22:02:27 -08:00
clocksource	Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2019-12-03 12:20:25 -08:00
connector	…
counter	…
cpufreq	cpufreq: vexpress-spc: Switch cpumask from topology core to OPP sharing	2019-12-09 11:52:50 +00:00
cpuidle	cpuidle: Drop unnecessary type cast in cpuidle_poll_time()	2019-12-12 17:56:08 +01:00
crypto	cxgb4/chtls: fix ULD connection failures due to wrong TID base	2019-12-17 22:33:54 -08:00
dax	libnvdimm for 5.5	2019-12-01 18:43:25 -08:00
dca	…
devfreq	PM / devfreq: Use PM QoS for sysfs min/max_freq	2019-12-09 12:19:16 +09:00
dio	…
dma	dmaengine: Fix Kconfig indentation	2019-11-22 11:16:26 +05:30
dma-buf	- A fix for a memory leak in the dma-buf support	2019-12-09 17:13:19 +10:00
edac	riscv: move sifive_l2_cache.c to drivers/soc	2019-12-20 03:40:24 -08:00
eisa	…
extcon	Char/Misc driver patches for 5.5-rc1	2019-11-27 10:53:50 -08:00
firewire	FireWire (IEEE 1394) subsystem updates:	2019-12-02 14:13:00 -08:00
firmware	Merge branch 'efi-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2019-12-17 10:39:55 -08:00
fpga	…
fsi	fsi: aspeed: Fix OPB0 byte order register values	2019-11-08 11:28:21 +01:00
gnss	…
gpio	spi: Fixes for v5.5	2019-12-17 13:06:31 -08:00
gpu	Merge tag 'drm-intel-fixes-2019-12-19' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes	2019-12-21 06:08:20 +10:00
greybus	…
hid	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid	2019-12-01 18:20:54 -08:00
hsi	…
hv	Merge branch 'akpm' (patches from Andrew)	2019-12-01 20:36:41 -08:00
hwmon	compat_ioctl: remove most of fs/compat_ioctl.c	2019-12-01 13:46:15 -08:00
hwspinlock	hwspinlock: u8500_hsem: Remove redundant PM runtime implementation	2019-11-08 16:42:26 -08:00
hwtracing	intel_th: msu: Fix window switching without windows	2019-12-17 15:45:59 +01:00
i2c	i2c: remove i2c_new_dummy() API	2019-12-10 23:15:09 +01:00
i3c	…
ide	compat_ioctl: remove most of fs/compat_ioctl.c	2019-12-01 13:46:15 -08:00
idle	cpuidle: Drop disabled field from struct cpuidle_state	2019-11-29 11:48:39 +01:00
iio	First set of fixes for IIO in the 5.5 cycle.	2019-12-09 09:27:52 +01:00
infiniband	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-12-22 15:15:05 -08:00
input	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2019-12-07 18:33:01 -08:00
interconnect	interconnect: qcom: msm8974: Walk the list safely on node removal	2019-12-12 10:28:54 +01:00
iommu	IOMMU Fixes for Linux v5.5-rc2	2019-12-20 10:42:25 -08:00
ipack	…
irqchip	pci-v5.5-changes	2019-12-03 13:58:22 -08:00
isdn	compat_ioctl: remove most of fs/compat_ioctl.c	2019-12-01 13:46:15 -08:00
leds	Merge tag 'leds-5.5-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds	2019-12-01 16:09:28 -08:00
lightnvm	…
macintosh	powerpc updates for 5.5	2019-11-30 14:35:43 -08:00
mailbox	mailbox changes for v5.5	2019-12-01 18:42:02 -08:00
mcb	…
md	for-linus-20191212	2019-12-13 14:27:19 -08:00
media	treewide: Use sizeof_field() macro	2019-12-09 10:36:44 -08:00
memory	memory: tegra: Fixes for v5.5-rc1	2019-12-06 08:28:51 -08:00
memstick	pci-v5.5-changes	2019-12-03 13:58:22 -08:00
message	netdev: pass the stuck queue to the timeout handler	2019-12-12 21:38:57 -08:00
mfd	chrome platform changes for v5.5	2019-12-03 14:37:12 -08:00
misc	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-12-22 15:15:05 -08:00
mmc	mmc: sdhci-of-esdhc: re-implement erratum A-009204 workaround	2019-12-19 08:13:43 +01:00
mtd	TTY/Serial patches for 5.5-rc1	2019-12-03 14:09:14 -08:00
mux	…
net	gianfar: Fix TX timestamping with a stacked DSA driver	2019-12-28 11:43:40 -08:00
nfc	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-12-22 15:15:05 -08:00
ntb	Add Hygon Device ID to the AMD NTB device driver	2019-12-07 18:38:17 -08:00
nubus	…
nvdimm	libnvdimm for 5.5	2019-12-01 18:43:25 -08:00
nvme	for-linus-20191212	2019-12-13 14:27:19 -08:00
nvmem	ARM: SoC-related driver updates	2019-12-05 11:43:31 -08:00
of	net: mdio: of: Register discovered MII time stampers.	2019-12-25 19:51:33 -08:00
opp	PM / OPP: Support adjusting OPP voltages at runtime	2019-11-11 10:27:15 +05:30
oprofile	Printk changes for 5.5	2019-11-25 19:40:40 -08:00
parisc	…
parport	parport: daisy: use new parport device model	2019-11-13 19:09:49 +08:00
pci	PCI: rockchip: Fix IO outbound ATU register number	2019-12-12 15:25:37 -06:00
pcmcia	pcmcia: remove unused dprintk definition	2019-11-22 07:03:45 +01:00
perf	perf/smmuv3: Remove the leftover put_cpu() in error path	2019-12-18 16:15:36 +00:00
phy	ARM: SoC-related driver updates	2019-12-05 11:43:31 -08:00
pinctrl	pinctrl: ingenic: Fixup PIN_CONFIG_OUTPUT config	2019-12-16 11:38:20 +01:00
platform	platform/x86: pcengines-apuv2: Spelling fixes in the driver	2019-12-20 19:01:59 +02:00
pnp	…
power	Additional power management updates for 5.5-rc1	2019-12-04 10:48:09 -08:00
powercap	…
pps	…
ps3	…
ptp	ptp: Add a driver for InES time stamping IP core.	2019-12-25 19:51:34 -08:00
pwm	pwm: Changes for v5.5-rc1	2019-12-05 11:28:14 -08:00
rapidio	drivers/rapidio/rio-access.c: fix missing include of <linux/rio_drv.h>	2019-12-04 19:44:13 -08:00
ras	…
regulator	regulator: Fixes for v5.5	2019-12-17 13:08:41 -08:00
remoteproc	remoteproc: stm32: fix probe error case	2019-11-18 20:35:16 -08:00
reset	reset: Do not register resource data for missing resets	2019-12-10 11:43:37 +01:00
rpmsg	rpmsg updates for v5.5	2019-12-01 18:39:24 -08:00
rtc	RTC for 5.5	2019-12-03 13:31:08 -08:00
s390	s390/qeth: remove QETH_RX_PULL_LEN	2019-12-26 15:23:50 -08:00
sbus	…
scsi	SCSI fixes on 20191214	2019-12-14 12:51:57 -08:00
sfi	…
sh	…
siox	…
slimbus	…
soc	riscv: move sifive_l2_cache.c to drivers/soc	2019-12-20 03:40:24 -08:00
soundwire	Merge 5.4-rc7 into char-misc-next	2019-11-11 06:24:30 +01:00
spi	spi: Fixes for v5.5	2019-12-17 13:06:31 -08:00
spmi	…
ssb	…
staging	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-12-22 15:15:05 -08:00
target	treewide: Use sizeof_field() macro	2019-12-09 10:36:44 -08:00
tc	…
tee	Merge mainline/master into arm/fixes	2019-12-05 13:18:54 -08:00
thermal	thermal: power_allocator: Fix Kconfig warning	2019-12-07 21:49:06 +08:00
thunderbolt	thunderbolt: Power cycle the router if NVM authentication fails	2019-11-19 17:35:57 +01:00
tty	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-12-22 15:15:05 -08:00
uio	uio: fix irq init with dt support & irq not defined	2019-11-14 11:49:48 +08:00
usb	usb: xhci: Fix build warning seen with CONFIG_PM=n	2019-12-18 19:23:42 +01:00
vfio	VFIO updates for v5.5-rc1	2019-12-07 14:51:04 -08:00
vhost	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-12-08 13:28:11 -08:00
video	pci-v5.5-changes	2019-12-03 13:58:22 -08:00
virt	compat_ioctl: remove most of fs/compat_ioctl.c	2019-12-01 13:46:15 -08:00
virtio	virtio_balloon: divide/multiply instead of shifts	2019-12-11 08:14:07 -05:00
visorbus	…
vlynq	…
vme	…
w1	w1: new driver. DS2430 chip	2019-11-14 13:06:33 +08:00
watchdog	linux-watchdog 5.5-rc1 tag	2019-12-01 18:01:03 -08:00
xen	xen: branch for v5.5-rc3	2019-12-21 06:24:56 -08:00
zorro	…
Kconfig	…
Makefile	…