Tyler Hicks d066fd9d7e eCryptfs: don't pass up plaintext names when using filename encryption ... [ Upstream commit e86281e700 ] Both ecryptfs_filldir() and ecryptfs_readlink_lower() use ecryptfs_decode_and_decrypt_filename() to translate lower filenames to upper filenames. The function correctly passes up lower filenames, unchanged, when filename encryption isn't in use. However, it was also passing up lower filenames when the filename wasn't encrypted or when decryption failed. Since 88ae4ab980, eCryptfs refuses to lookup lower plaintext names when filename encryption is enabled so this resulted in a situation where userspace would see lower plaintext filenames in calls to getdents(2) but then not be able to lookup those filenames. An example of this can be seen when enabling filename encryption on an eCryptfs mount at the root directory of an Ext4 filesystem: $ ls -1i /lower 12 ECRYPTFS_FNEK_ENCRYPTED.FWYZD8TcW.5FV-TKTEYOHsheiHX9a-w.NURCCYIMjI8pn5BDB9-h3fXwrE-- 11 lost+found $ ls -1i /upper ls: cannot access '/upper/lost+found': No such file or directory ? lost+found 12 test With this change, the lower lost+found dentry is ignored: $ ls -1i /lower 12 ECRYPTFS_FNEK_ENCRYPTED.FWYZD8TcW.5FV-TKTEYOHsheiHX9a-w.NURCCYIMjI8pn5BDB9-h3fXwrE-- 11 lost+found $ ls -1i /upper 12 test Additionally, some potentially noisy error/info messages in the related code paths are turned into debug messages so that the logs can't be easily filled. Fixes: 88ae4ab980 ("ecryptfs_lookup(): try either only encrypted or plaintext name") Reported-by: Guenter Roeck <linux@roeck-us.net> Cc: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Tyler Hicks <tyhicks@canonical.com> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-06-21 04:02:42 +09:00
..
9p	fs/9p: Compare qid.path in v9fs_test_inode	2017-11-30 08:40:49 +00:00
adfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
affs	affs_lookup(): close a race with affs_remove_link()	2018-05-30 07:51:47 +02:00
afs	afs: Fix missing error handling in afs_write_end()	2018-03-03 10:24:32 +01:00
autofs4	autofs: mount point create should honour passed in mode	2018-04-24 09:36:39 +02:00
befs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
bfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
btrfs	btrfs: define SUPER_FLAG_METADUMP_V2	2018-06-11 22:49:18 +02:00
cachefiles	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ceph	ceph: fix potential memory leak in init_caches()	2018-05-30 07:52:09 +02:00
cifs	smb3: directory sync should not return an error	2018-05-16 10:10:30 +02:00
coda	coda: fix 'kernel memory exposure attempt' in fsync	2017-11-24 08:37:05 +01:00
configfs	configfs: Introduce config_item_get_unless_zero()	2017-06-12 13:20:20 +02:00
cramfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
crypto	fscrypt: lock mutex before checking for bounce page pool	2017-11-30 08:40:44 +00:00
debugfs	Merge branch 'work.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-07-15 12:00:42 -07:00
devpts	devpts: fix error handling in devpts_mntget()	2018-02-16 20:23:11 +01:00
dlm	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ecryptfs	eCryptfs: don't pass up plaintext names when using filename encryption	2018-06-21 04:02:42 +09:00
efivarfs	VFS: Kill off s_options and helpers	2017-07-11 06:09:21 -04:00
efs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
exofs	Merge branch 'for-4.14/block' of git://git.kernel.dk/linux-block	2017-09-07 11:59:42 -07:00
exportfs	…
ext2	do d_instantiate/unlock_new_inode combinations safely	2018-05-30 07:51:47 +02:00
ext4	ext4: don't complain about incorrect features when probing	2018-05-30 07:52:30 +02:00
f2fs	f2fs: fix to check extent cache in f2fs_drop_extent_tree	2018-05-30 07:52:33 +02:00
fat	fs/fat/inode.c: fix sb_rdonly() change	2017-12-05 11:26:29 +01:00
freevxfs	…
fscache	fscache: Fix hanging wait on page discarded by writeback	2018-05-30 07:52:25 +02:00
fuse	fuse: fix READDIRPLUS skipping an entry	2017-10-25 16:34:27 +02:00
gfs2	gfs2: Fix fallocate chunk size	2018-05-30 07:52:35 +02:00
hfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
hfsplus	hfsplus: stop workqueue when fill_super() failed	2018-05-25 16:17:35 +02:00
hostfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
hpfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
hugetlbfs	hugetlbfs: fix bug in pgoff overflow checking	2018-04-19 08:56:21 +02:00
isofs	isofs: fix potential memory leak in mount option parsing	2018-06-21 04:02:41 +09:00
jbd2	ext4: set h_journal if there is a failure starting a reserved handle	2018-05-01 12:58:06 -07:00
jffs2	do d_instantiate/unlock_new_inode combinations safely	2018-05-30 07:51:47 +02:00
jfs	do d_instantiate/unlock_new_inode combinations safely	2018-05-30 07:51:47 +02:00
kernfs	kernfs: fix regression in kernfs_fop_write caused by wrong type	2018-02-16 20:22:59 +01:00
lockd	race of lockd inetaddr notifiers vs nlmsvc_rqst change	2018-02-03 17:39:08 +01:00
minix	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ncpfs	staging: ncpfs: memory corruption in ncp_read_kernel()	2018-03-28 18:24:43 +02:00
nfs	nfs: system crashes after NFS4ERR_MOVED recovery	2018-05-30 07:52:01 +02:00
nfs_common	lockd: fix "list_add double add" caused by legacy signal interface	2018-02-03 17:39:08 +01:00
nfsd	nfsd: fix incorrect umasks	2018-04-19 08:56:21 +02:00
nilfs2	do d_instantiate/unlock_new_inode combinations safely	2018-05-30 07:51:47 +02:00
nls	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
notify	fsnotify: fix ignore mask logic in send_to_group()	2018-06-21 04:02:41 +09:00
ntfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ocfs2	ocfs2/dlm: don't handle migrate lockres if already in shutdown	2018-05-30 07:52:24 +02:00
omfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
openpromfs	…
orangefs	do d_instantiate/unlock_new_inode combinations safely	2018-05-30 07:51:47 +02:00
overlayfs	ovl: fix lookup with middle layer opaque dir and absolute path redirects	2018-04-19 08:56:21 +02:00
proc	fs/proc/proc_sysctl.c: fix potential page fault while unregistering sysctl table	2018-05-30 07:52:23 +02:00
pstore	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
qnx4	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
qnx6	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
quota	quota: Check for register_shrinker() failure.	2018-02-03 17:39:11 +01:00
ramfs	mm: make pagevec_lookup() update index	2017-09-06 17:27:26 -07:00
reiserfs	do d_instantiate/unlock_new_inode combinations safely	2018-05-30 07:51:47 +02:00
romfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
squashfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
sysfs	sysfs: symlink: export sysfs_create_link_nowarn()	2018-03-31 18:10:38 +02:00
sysv	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
tracefs	VFS: Don't use save/replace_mount_options if not using generic_show_options	2017-07-06 03:31:46 -04:00
ubifs	ubifs: Fix uninitialized variable in search_dh_cookie()	2018-04-26 11:02:07 +02:00
udf	udf: Provide saner default for invalid uid / gid	2018-05-30 07:52:38 +02:00
ufs	do d_instantiate/unlock_new_inode combinations safely	2018-05-30 07:51:47 +02:00
xfs	xfs: detect agfl count corruption and reset agfl	2018-06-05 11:41:55 +02:00
Kconfig	fs/Kconfig: kill CONFIG_PERCPU_RWSEM some more	2017-07-12 16:26:00 -07:00
Kconfig.binfmt	…
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
aio.c	fix io_destroy()/aio_complete() race	2018-06-05 11:41:54 +02:00
anon_inodes.c	…
attr.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
bad_inode.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
binfmt_aout.c	fs: fix kernel_read prototype	2017-09-04 19:05:15 -04:00
binfmt_elf.c	Merge branch 'work.set_fs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-09-14 18:13:32 -07:00
binfmt_elf_fdpic.c	Merge branch 'work.set_fs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-09-14 18:13:32 -07:00
binfmt_em86.c	…
binfmt_flat.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
binfmt_misc.c	fs/binfmt_misc.c: node could be NULL when evicting inode	2017-10-13 16:18:33 -07:00
binfmt_script.c	exec: load_script: kill the onstack interp[BINPRM_BUF_SIZE] array	2017-10-03 17:54:25 -07:00
block_dev.c	fs/mpage.c: fix mpage_writepage() for pages with buffers	2017-10-13 16:18:33 -07:00
buffer.c	fs: guard_bio_eod() needs to consider partitions	2017-11-30 08:40:45 +00:00
char_dev.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
compat.c	fs/compat.c: trim unused includes	2017-04-17 12:52:27 -04:00
compat_binfmt_elf.c	…
compat_ioctl.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
coredump.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
dax.c	fs/dax.c: release PMD lock even when there is no PMD support in DAX	2018-04-26 11:02:14 +02:00
dcache.c	fs: dcache: Use READ_ONCE when accessing i_dir_seq	2018-05-30 07:52:03 +02:00
dcookies.c	…
direct-io.c	direct-io: Fix sleep in atomic due to sync AIO	2018-03-08 22:41:06 -08:00
drop_caches.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
eventfd.c	There has been a fair amount of activity in the docs tree this time	2017-07-03 21:13:25 -07:00
eventpoll.c	fs/epoll: use faster rb_first_cached()	2017-09-08 18:26:49 -07:00
exec.c	exec: avoid gcc-8 warning for get_task_comm	2018-03-03 10:24:21 +01:00
fcntl.c	fcntl: don't cap l_start and l_end values for F_GETLK64 in compat syscall	2017-12-17 15:07:59 +01:00
fhandle.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
file.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
file_table.c	fput: Don't reinvent the wheel but use existing llist API	2017-08-28 00:50:23 -04:00
filesystems.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
fs-writeback.c	bdi: Fix oops in wb_workfn()	2018-05-16 10:10:25 +02:00
fs_pin.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
fs_struct.c	…
inode.c	Merge branch 'overlayfs-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs	2017-09-13 09:11:44 -07:00
internal.h	Merge branch 'overlayfs-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs	2017-09-13 09:11:44 -07:00
ioctl.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
iomap.c	fs: invalidate page cache after end_io() in dio completion	2017-10-16 12:11:56 -07:00
libfs.c	fs: convert __generic_file_fsync to use errseq_t based reporting	2017-07-06 07:02:29 -04:00
locks.c	locks: restore a warn for leaked locks on close	2017-07-21 13:57:31 -04:00
mbcache.c	mbcache: initialize entry->e_referenced in mb_cache_entry_create()	2018-02-22 15:42:25 +01:00
mount.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
mpage.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
namei.c	getname_kernel() needs to make sure that ->name != ->iname in long case	2018-04-19 08:56:19 +02:00
namespace.c	Don't leak MNT_INTERNAL away from internal mounts	2018-04-24 09:36:39 +02:00
no-block.c	…
nsfs.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
open.c	ovl: don't allow writing ioctl on lower layer	2017-09-05 12:53:12 +02:00
pipe.c	pipe: fix off-by-one error when checking buffer limits	2018-02-16 20:23:05 +01:00
pnode.c	mnt: Make propagate_umount less slow for overlapping mount propagation trees	2017-05-23 08:41:17 -05:00
pnode.h	…
posix_acl.c	…
proc_namespace.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
read_write.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
readdir.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
select.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
seq_file.c	seq_file: fix incomplete reset on read from zero offset	2018-02-22 15:42:28 +01:00
signalfd.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
splice.c	fs: move kernel_write to fs/read_write.c	2017-09-04 19:05:15 -04:00
stack.c	…
stat.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
statfs.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
super.c	fs: don't scan the inode cache before SB_BORN is set	2018-05-30 07:51:47 +02:00
sync.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
timerfd.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
userfaultfd.c	userfaultfd: clear the vma->vm_userfaultfd_ctx if UFFD_EVENT_FORK fails	2018-01-10 09:31:17 +01:00
utimes.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xattr.c	lsm: fix smack_inode_removexattr and xattr_getsecurity memleak	2017-10-04 18:03:15 +11:00