fix: remove NaN from fastpass report by removing concatenation in OutcomeSummaryBar (#857)

This commit is contained in:
Karan 2019-06-25 14:05:14 -07:00 коммит произвёл GitHub
Родитель b4f7b2d0b0
Коммит 3729799d42
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: 4AEE18F83AFDEB23
2 изменённых файлов: 14 добавлений и 10 удалений

Просмотреть файл

@ -26,7 +26,8 @@ export const OutcomeSummaryBar = NamedSFC<OutcomeSummaryBarProps>('OutcomeSummar
return (
<div key={outcomeType} style={{ flexGrow: count }}>
<span className={kebabCase(outcomeType)}>
{outcomeIcon} {count + countSuffix} <span className="outcome-past-tense">{text}</span>
{outcomeIcon} {count}
{countSuffix} <span className="outcome-past-tense">{text}</span>
</span>
</div>
);

Просмотреть файл

@ -16,7 +16,7 @@ exports[`OutcomeSummaryBar render inverted badges 1`] = `
>
<CheckIconInverted />
NaN
42
<span
className="outcome-past-tense"
@ -37,7 +37,7 @@ exports[`OutcomeSummaryBar render inverted badges 1`] = `
>
<CrossIconInverted />
NaN
13
<span
className="outcome-past-tense"
@ -58,7 +58,7 @@ exports[`OutcomeSummaryBar render inverted badges 1`] = `
>
<CircleIcon />
NaN
7
<span
className="outcome-past-tense"
@ -86,7 +86,8 @@ exports[`OutcomeSummaryBar show by percentage 1`] = `
>
<CheckIcon />
42%
42
%
<span
className="outcome-past-tense"
@ -107,7 +108,8 @@ exports[`OutcomeSummaryBar show by percentage 1`] = `
>
<CrossIcon />
13%
13
%
<span
className="outcome-past-tense"
@ -128,7 +130,8 @@ exports[`OutcomeSummaryBar show by percentage 1`] = `
>
<CircleIcon />
7%
7
%
<span
className="outcome-past-tense"
@ -156,7 +159,7 @@ exports[`OutcomeSummaryBar show by percentage 2`] = `
>
<CheckIcon />
NaN
42
<span
className="outcome-past-tense"
@ -177,7 +180,7 @@ exports[`OutcomeSummaryBar show by percentage 2`] = `
>
<CrossIcon />
NaN
13
<span
className="outcome-past-tense"
@ -198,7 +201,7 @@ exports[`OutcomeSummaryBar show by percentage 2`] = `
>
<CircleIcon />
NaN
7
<span
className="outcome-past-tense"