fix: remove unnecessary changes for auto-update and add comments (#5338)

pipeline/scripts/zip-mac-folder.js

@@ -5,7 +5,7 @@
     The macOS electron-builder update process requires a zip file
     (electron-builder #4230), but the zip file produced by 
     electron-builder is corrupted (electron-builder #3534).
-    We use 7z to create the zip file ourselves.
+    We use ditto to create the zip file ourselves.
 */
 
 const child_process = require('child_process');

src/electron/electron-builder/electron-builder.template.yaml

@@ -38,10 +38,14 @@ linux:
 appImage:
     license: src/electron/resources/mit_license.txt
 
+# electron-userland/electron-builder#2199 suggests we should produce a zip using electron-builder
+# even if we do not use it (for auto-update to work) but that actually leads to issues when updating
+# (accessibility-insights-web/3942#issuecomment-1090857396). As such, we only build the dmg with
+# electron-builder and build the zip ourselves.
 mac:
     artifactName: ${productName}.${ext}
     icon: TARGET_SPECIFIC
-    target: dmg # we also need zip (electron-userland/electron-builder#2199) & add it in grunt
+    target: dmg
     identity: null
 
 win:

src/electron/resources/entitlements.plist

@@ -8,7 +8,5 @@
     <true/>
     <key>com.apple.security.cs.disable-library-validation</key>
     <true/>
-    <key>com.apple.security.cs.allow-dyld-environment-variables</key>
-    <true/>
 </dict>
 </plist>