#### Details
As called out in #5251, we were providing instructions that were
targeting only Windows 10, not Windows 11 or macOS. We were also
referring to "Microsoft Edge" as either "new Microsoft Edge" or
"Microsoft Edge Insider", since that was the appropriate name when the
code was written. Times have changed, so we've updated the following:
- In Assessment 17.1 (title: "High contrast mode"), we have replaced the
Windows 10 instructions with a link that opens a new page containing
instructions for selecting a high contrast theme, with instructions for
Windows 10 or Windows 11. We have also added a note that macOS high
contrast settings are not picked up in the browser (at least it didn't
when I tested it).
- In Assessment 17.2 (title: Resize text), we have replaced the Windows
10 instructions with a link that opens a new page instructions for
setting the logical screen size on both Windows or macOS. The macOS
instructions are less precise because of how macOS settings work,
especially if using an external monitor. For example, on my external 4K
display, the smallest available width is 1920.
- Consistently use "Microsoft Edge" as the displayed browser name
##### Screenshots
High contrast:
Description | Screenshot
--- | ---
Old |
New |
Instructions |
Text Resize:
Description | Screenshot
--- | ---
Old |
New |
Instructions |
##### Motivation
Address #5251
##### Context
<!-- Are there any parts that you've intentionally left out-of-scope for
a later PR to handle? -->
<!-- Were there any alternative approaches you considered? What
tradeoffs did you consider? -->
Something to note: The Windows-recommended way to increase text size (in
both Win 10 and Win11) is via the Resize Text option in accessibility.
However, that option does not constrain the viewport, so running the
test that way on a full desktop display doesn't really cover the
scenario that is supposed to be tested here. For that reason, we persist
with the way you'd do this on Win7 and earlier.
#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [x] Addresses an existing issue: #5651
- [x] Ran `yarn fastpass`
- [ ] Added/updated relevant unit test(s) (and ran `yarn test`)
- [ ] Verified code coverage for the changes made. Check coverage report
at: `<rootDir>/test-results/unit/coverage`
- [x] PR title *AND* final merge commit title both start with a semantic
tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See
`CONTRIBUTING.md`.
- [x] (UI changes only) Added screenshots/GIFs to description above
- [x] (UI changes only) Verified usability with NVDA/JAWS
#### Details
Remove Android references from docs
##### Motivation
Android deprecation feature
##### Context
<!-- Are there any parts that you've intentionally left out-of-scope for
a later PR to handle? -->
<!-- Were there any alternative approaches you considered? What
tradeoffs did you consider? -->
#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [n/a] Addresses an existing issue (part of Android deprecation
feature)
- [x] Ran `yarn fastpass`
- [n/a] Added/updated relevant unit test(s) (and ran `yarn test`)
- [n/a] Verified code coverage for the changes made. Check coverage
report at: `<rootDir>/test-results/unit/coverage`
- [x] PR title *AND* final merge commit title both start with a semantic
tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See
`CONTRIBUTING.md`.
- [x] (UI changes only) Added screenshots/GIFs to description above
- [x] (UI changes only) Verified usability with NVDA/JAWS
This commit updates the project readme to include a deprecation notice for
the Android project, consistent with our intent to shut it down.
Part of Feature 2044298 (internal access required to view).
#### Details
Dependabot's README badges broke when the old non-GitHub Dependabot migrated to GitHub. This PR removes the broken badge.
##### Motivation
Fixes broken link/image at top of README
##### Context
There isn't currently a replacement for the badge feature in the native GitHub Dependabot. https://github.com/dependabot/dependabot-core/issues/1912 tracks the request to add it, but hasn't seen activity in some time.
#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox -->
- [n/a] Addresses an existing issue: #0000
- [x] Ran `yarn fastpass`
- [n/a] Added/updated relevant unit test(s) (and ran `yarn test`)
- [n/a] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage`
- [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`.
- [n/a] (UI changes only) Added screenshots/GIFs to description above
- [n/a] (UI changes only) Verified usability with NVDA/JAWS
#### Description of changes
This PR sets up the repo for migrating our public PR/CI builds from https://dev.azure.com/ms to https://dev.azure.com/accessibility-insights
Right now, the builds have been set up to run in both; we'll be turning off the /ms/ ones once we've merged this PR and updated the repo branch policies.
* Updates CI build badge on README
* Updates reliability builds to run on a nightly schedule instead of continuously with merges to master (at least until our support request to add additional parallel job capacity for our public projects in accessibility-insights goes through, but maybe we'll keep it like this)
#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox -->
- [n/a] Addresses an existing issue: #0000
- [x] Ran `yarn fastpass`
- [n/a] Added/updated relevant unit test(s) (and ran `yarn test`)
- [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage`
- [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`.
- [n/a] (UI changes only) Added screenshots/GIFs to description above
- [n/a] (UI changes only) Verified usability with NVDA/JAWS
* Rework contributing info with clearer unified vs web guidance
* Cleanup
* Improve list formatting
* Remove stray period
* Clean up link format to match updated page title
* Fix broken dev logo in moved content
* Clean up double-mention of watch:test
* yarn format:fix
* Move connect to service info to a more clear place
* Fix grammar per PR feedback
We just added support for runing code-cov bot on our PRs and CI builds so it makes sense to update our code coverage badge from Azure Dev Ops to codecov.
* adjust drop for electron drop
* update deploy grunt with new drop folder path
* PR feedback updates
* update launch.json with correct electron path
* fix path in e2e for dev drop
* update path for electron test
#### Description of changes
Addresses feedback from the team that came up during 10/31/19 engineering discussion, in particular:
* Makes `format:*`, `lint:*`, and `copyright:*` commands use consistent naming
* Corrects documentation about use of `yarn test -- -- <files>`
* Makes `yarn watch:test` watch unit tests only, not e2e tests
* Removes `yarn precheckin` in favor of separate `yarn fastpass` (runs lints/format checks only) and `yarn assessment` (works like old precheckin)
* Parallelizes `yarn fastpass` subtasks (on my machine at home, which is slower than my work machine, fastpass now takes about a minute; prettier is the long-pole)
* Updates build scripts/PR templates/documentation accordingly
#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox -->
- [n/a] Addresses an existing issue: #0000
- [x] Ran `yarn fastpass`
- [n/a] Added/updated relevant unit test(s) (and ran `yarn test`)
- [n/a] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage`
- [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). Check workflow guide at: `<rootDir>/docs/workflow.md`
- [n/a] (UI changes only) Added screenshots/GIFs to description above
- [n/a] (UI changes only) Verified usability with NVDA/JAWS
* Add run script to emulate CI build docker e2e testing
* document new run script in readme
* Enable passing through extra arguments to jest
* Fixes to README
Before this change, the windows E2E test logs showed the following warning:
```
warning From Yarn 1.0 onwards, scripts don't require "--" for options to be forwarded. In a future version, any explicit "--" will be forwarded as-is to the scripts.
```
This addresses it in the CI build and also in our README suggested commands (I searched the codebase for uses of the string ` -- `)
* move stuff to yarn
* change build.yaml
* change build to work better
* change name of installation task
* change more stuff from npm to yarn
* make some more simple changes
* run npm upgrade
* remove unncessary changes
* update yarn.lock
* try -frozen-lockfile param
* testing with a minor change to trigger build again
* update readme
* fix formatting
* update documentation
* remove package-lock from prettierignore since the file doesn't exist anymore
* change version and other pr comments
* change occurance of npm
* change workflow.md
* update setup file
* update setting up vscode document
* README changes
* Bug report template changes
* Address Chrome references in How to Test text
* Update allow file access prompt
* Clean up empty list items
* Update snapshot of allow file access prompt
* Add bookmarklet instructions for Edge Insider
* Show Edge Insider version on reports
* Update open dev tools instructions
* Adding a faq page and linking to it from the readme
* FAQ is in docs
* Removing the Q as suggested by Peter
* Typo !
Co-Authored-By: flyingUnderTheRadar <45673569+flyingUnderTheRadar@users.noreply.github.com>
* Removing the FAQ page and pointing to the product web faq page
* upgrading jest to support global setup on multi-projects;
https://github.com/facebook/jest/pull/6865
updating deprecated property
remove tsconfig.jest.json
ignore d.ts files form coverage
* fix e2e root dir path
* Updated readme to tell user do not use admin cli to run e2e test. Also mentioned how to udpate snapshot file by cmd.
* Updated text.
* partial changes
* Added the reason why non-admin cli should not be used on e2e test.
* Fixed pr comments.
* Run dev and prod webpack separately, integrate tslint into webpack
* Add comments clarifying ForkTsCheckerWebPlugin usage
* Update package-lock
* Fix build.yaml issue in final PublishBuildArtifacts task (and remove unnecessary copy task)
* Add job timeouts to build.yaml (in response to overlong-running e2e task in this PR)
* Update readme with changes Deva suggested
* Bump build.yaml timeout to 15 minutes to allow for future increases/build machine contention
Dave Tryon
Bill Dengler
Dan Bjorge
Rob Gallo
John Alkire
Karan
Sebastian Morales
Shobhit
lisli1
Annika Kouhia
Peter Durham
flyingUnderTheRadar
Shobhit
Risa Naka
devaradhanm
Ada
Dan Bjorge
mslonli
Liu Haonan
Mark Reay
Microsoft Open Source