Rename ReactWrapperComponent's detectChanges() to markForCheck()

Better reflects what the method does.
This commit is contained in:
Ben Grynhaus 2018-10-19 21:46:37 +03:00
Родитель c69f01e24b
Коммит 9e011ca753
2 изменённых файлов: 8 добавлений и 6 удалений

Просмотреть файл

@ -94,10 +94,11 @@ export abstract class ReactWrapperComponent<TProps extends {}> implements AfterV
/** /**
* Creates an instance of ReactWrapperComponent. * Creates an instance of ReactWrapperComponent.
* @param elementRef The host element. * @param elementRef The host element.
* @param setHostDisplay Whether the host's `display` should be set to the root child node's `display`. defaults to `false` * @param changeDetectorRef The change detector for the component.
* @param renderer The Angular renderer.
*/ */
constructor( constructor(
public readonly elementRef: ElementRef, public readonly elementRef: ElementRef<HTMLElement>,
private readonly changeDetectorRef: ChangeDetectorRef, private readonly changeDetectorRef: ChangeDetectorRef,
private readonly renderer: Renderer2, private readonly renderer: Renderer2,
private readonly setHostDisplay: boolean = false private readonly setHostDisplay: boolean = false
@ -127,13 +128,14 @@ export abstract class ReactWrapperComponent<TProps extends {}> implements AfterV
ngOnChanges(changes: SimpleChanges) { ngOnChanges(changes: SimpleChanges) {
this._passAttributesAsProps(); this._passAttributesAsProps();
this.detectChanges(); this.markForCheck();
} }
/** /**
* Trigger change detection on the component. * Mark the component as one that needed re-rendering on the React side,
* and mark for change detection on the Angular side.
*/ */
protected detectChanges() { protected markForCheck() {
if (isReactNode(this.reactNodeRef.nativeElement)) { if (isReactNode(this.reactNodeRef.nativeElement)) {
this.reactNodeRef.nativeElement.setRenderPending(); this.reactNodeRef.nativeElement.setRenderPending();
} }

Просмотреть файл

@ -187,7 +187,7 @@ export class FabCommandBarComponent extends ReactWrapperComponent<ICommandBarPro
this._subscriptions.push( this._subscriptions.push(
directive.onItemChanged.subscribe(({ key, changes }: CommandBarItemChangedPayload) => { directive.onItemChanged.subscribe(({ key, changes }: CommandBarItemChangedPayload) => {
setItems(items => items.map(item => (item.key === key ? mergeItemChanges(item, changes) : item))); setItems(items => items.map(item => (item.key === key ? mergeItemChanges(item, changes) : item)));
this.detectChanges(); this.markForCheck();
}) })
); );
} }